From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>, <grive@u256.net>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process
Date: Wed, 27 Oct 2021 09:37:29 +0100 [thread overview]
Message-ID: <95b23ff9-b175-0189-7b66-ac130d608544@intel.com> (raw)
In-Reply-To: <20211027034918.17619-1-kumaraparamesh92@gmail.com>
On 10/27/2021 4:49 AM, Kumara Parameshwaran wrote:
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Hi Kumara,
Can you please provide more detail in the commit log?
> ---
> drivers/net/failsafe/failsafe.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
> index 8216063..1adccaf 100644
> --- a/drivers/net/failsafe/failsafe.c
> +++ b/drivers/net/failsafe/failsafe.c
> @@ -329,8 +329,7 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev)
> INFO("Initializing " FAILSAFE_DRIVER_NAME " for %s",
> name);
>
> - if (rte_eal_process_type() == RTE_PROC_SECONDARY &&
> - strlen(rte_vdev_device_args(vdev)) == 0) {
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> eth_dev = rte_eth_dev_attach_secondary(name);
> if (!eth_dev) {
> ERROR("Failed to probe %s", name);
>
prev parent reply other threads:[~2021-10-27 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 3:49 Kumara Parameshwaran
2021-10-27 8:37 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95b23ff9-b175-0189-7b66-ac130d608544@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=kumaraparamesh92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).