From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Eduard Serra Miralles <eserra@vmware.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Yong Wang <yongwang@vmware.com>
Subject: Re: [dpdk-dev] [PATCH] [v3] net/vmxnet3: fix RSS setting on v4
Date: Thu, 5 Mar 2020 14:19:55 +0000 [thread overview]
Message-ID: <96006620-7dda-0ed7-4c58-3f5f0760f9c3@intel.com> (raw)
In-Reply-To: <1583289349-21583-1-git-send-email-eserra@vmware.com>
On 3/4/2020 2:35 AM, Eduard Serra Miralles wrote:
> When calling to setup RSS on v4 API, ESX will expect
> IPv4/6 TCP RSS to be set/requested mandatorily.
>
> This patch will:
> - Set IPv4/6 TCP RSS when these have not been set. A warning
> message is thrown to make sure we warn the application we are
> setting IPv4/6 TCP RSS when not set.
> - An additional check has been added to dodge RSS configuration
> altogether unless MQ_RSS has been requested, similar to v3.
>
> The alternative (returning error) was considered, the intent
> is to ease the task of setting up and running vmxnet3 in situations
> where it's supposted to be most strightforward (testpmd, pktgen).
>
> Open bug for this:
> https://bugs.dpdk.org/show_bug.cgi?id=400
>
> Signed-off-by: Eduard Serra <eserra@vmware.com>
> Acked-by: Yong Wang <yongwang@vmware.com>
> Fixes: 643fba770705 ("net/vmxnet3: v4 boot and guest UDP RSS configuration")
Bugzilla ID: 400
Fixes: 643fba770705 ("net/vmxnet3: add v4 boot and guest UDP RSS config")
Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-03-05 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 16:37 [dpdk-dev] [PATCH] " Eduard Serra Miralles
2019-09-13 18:44 ` Yong Wang
2019-09-13 20:10 ` Eduard Serra Miralles
2019-09-16 19:01 ` Yong Wang
2019-10-08 17:55 ` Ferruh Yigit
2020-03-03 20:44 ` [dpdk-dev] [PATCH v2] " Eduard Serra Miralles
2020-03-04 2:35 ` [dpdk-dev] [PATCH] [v3] " Eduard Serra Miralles
2020-03-05 14:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96006620-7dda-0ed7-4c58-3f5f0760f9c3@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=eserra@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).