From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1EC8F1B51F for ; Wed, 19 Dec 2018 10:09:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2018 01:09:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,372,1539673200"; d="scan'208";a="119617597" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.66]) ([10.237.221.66]) by FMSMGA003.fm.intel.com with ESMTP; 19 Dec 2018 01:09:53 -0800 To: Thomas Monjalon , Liang Ma Cc: dev@dpdk.org, anatoly.burakov@intel.com References: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com> <1544793093-9971-1-git-send-email-liang.j.ma@intel.com> <2602247.RKfj1taVKr@xps> From: "Hunt, David" Message-ID: <96158e0f-6454-2e5c-f843-cb91221ed304@intel.com> Date: Wed, 19 Dec 2018 09:09:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <2602247.RKfj1taVKr@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3] libs/power: add p-state driver compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 09:09:56 -0000 On 19/12/2018 3:18 AM, Thomas Monjalon wrote: > 14/12/2018 14:11, Liang Ma: >> Previously, in order to use the power library, it was necessary >> for the user to disable the intel_pstate driver by adding >> “intel_pstate=disable” to the kernel command line for the system, >> which causes the acpi_cpufreq driver to be loaded in its place. >> >> This patch adds the ability for the power library use the intel-pstate >> driver. >> >> It adds a new suite of functions behind the current power library API, >> and will seamlessly set up the user facing API function pointers to >> the relevant functions depending on whether the system is running with >> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest, >> using kvm. The library API and ABI is unchanged. >> >> Signed-off-by: Liang Ma >> >> Reviewed-by: Anatoly Burakov >> --- > Please write a changelog when sending a new version. > > Dave, any comment on this patch? Looks good to me. Acked-by: David Hunt >> --- /dev/null >> +++ b/lib/librte_power/power_pstate_cpufreq.c >> @@ -0,0 +1,770 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2018-2018 Intel Corporation > Something wrong here :) Yes, should simply be "Copyright(c) 2018 Intel Corporation" >