From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06078A055D; Wed, 3 Mar 2021 15:43:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 491001606F0; Wed, 3 Mar 2021 15:43:26 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 807FC40683 for ; Wed, 3 Mar 2021 15:43:24 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id d2so4456949pjs.4 for ; Wed, 03 Mar 2021 06:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7XFmXVRTivkyRPiPpeLHcA6tTImF7mHBNQwuxpHhOgg=; b=x86V+VmYugAu3XKEhbhDKhUbl5C9fNbQ+PZG3DwcfLkrmCDonUblqpFmWPFwcfal8x OcerkpzrbY2YygFe1HUH9tyUV2kIqZ8X+Qg9yP2QnHV5WgRhi/xrA0NUfj9ygSgIXYzg N91RPGf8c12jECoDshDnwssSDhsq1g2q1lYjWOl+01bSVsj+6Kpx5JICK0KzH5xcZImW 8Nz95IMD2OAQvllpiqDnZznlT6ZEABrUCzJH96PGOdOBexWpu1zuVWvBYibeJd5ez8HY d1w97qXqoWrUnonhux5xGQJmJ+2zp8NXVEOyMotcRpJbLBApPfiPP4UiX8bUiDS64/hP 6IiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7XFmXVRTivkyRPiPpeLHcA6tTImF7mHBNQwuxpHhOgg=; b=XArLmvyndkQEx5/jOFhux72hL+ec7rKJzrvEMJaH26a+XVI20rPJ6v/OGM2RgxZnYo W1ZakFCxVCQNIKTw/xPNzbt55Z7TX4Vk3N72kNpbvAosM8ZCsguRom0+ji3i3qASxvWF u2I9CIAsYRzIYLSe7vGdV3/f5AsFI/rg5qQCds4Crr/ozhqKtqXaauJ1XmLF49gp2UtV NjPNrYBSrJpl4ixD5A7cIqqST1qMPz9Y5wEFIkhbFdwCwEMS/zXuowYOokjJHMps/bav BzUrkC1AtioG8AnSQ5WLXZ9rtdhlglhXj+xsNurQTZg+OPQ2JXhHtnyStcOxn9jPAHLN rO8Q== X-Gm-Message-State: AOAM532qIjsVfNUMURCmYvQJLIIvvg2OZuE5sp/X4R4awykEH/rJi224 TVf00TQ3bPEGAGzUq1A8Njs+cA== X-Google-Smtp-Source: ABdhPJxrzmxB+eZKCUHP0vS0cylwaBIimGLLCAhnkfrcvt0brdPv9h4w2B4GiUnJg36nvjbPHp7qqA== X-Received: by 2002:a17:90a:5206:: with SMTP id v6mr9995231pjh.22.1614782603619; Wed, 03 Mar 2021 06:43:23 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:d51f:7a71:2188:236b? ([2600:1700:6b0:fde0:d51f:7a71:2188:236b]) by smtp.gmail.com with ESMTPSA id l22sm6979478pjy.51.2021.03.03.06.43.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Mar 2021 06:43:23 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: Andrew Boyer In-Reply-To: Date: Wed, 3 Mar 2021 09:43:20 -0500 Cc: Anatoly Burakov , Andrew Rybchenko , dev , dpdk stable Content-Transfer-Encoding: quoted-printable Message-Id: <961D2062-BCA4-4687-877A-4EA8238299AB@pensando.io> References: To: David Marchand X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [dpdk-dev] [PATCH] fbarray: fix uninitialized variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Mar 3, 2021, at 3:17 AM, David Marchand = wrote: >=20 > On Fri, Feb 19, 2021 at 6:55 PM Anatoly Burakov > wrote: >>=20 >> When file truncation fails, the log message attempts to print a path = of >> file we failed to truncate, but this path was never set to anything = and, >> what's worse, was uninitialized. Fix it by passing path from the = caller. >>=20 >> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") >> Cc: stable@dpdk.org >> Coverity ID: 366122 >>=20 >> Signed-off-by: Anatoly Burakov >=20 > Andrew had reported it too, and proposed something close: > = http://patchwork.dpdk.org/project/dpdk/patch/20201211170615.32827-1-aboyer= @pensando.io/ >=20 > I prefer Anatoly's version. > If no one objects, I'll proceed with this one. >=20 >=20 > --=20 > David Marchand >=20 Fine with me=