From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 004534CA7 for ; Tue, 30 Oct 2018 15:36:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 85795E42; Tue, 30 Oct 2018 10:35:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Oct 2018 10:35:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aDZtC5ndC8KP7Y7dZrfe3ZI/d+UPq/c3xgPgWHu0QFo=; b=e9eYkR/0RVrN TWGEpCR77R3YgqOXRmetmaPJAO4qeO/iTiG9h6SLYDzURjf7N327fo2rLHEARKi9 6+v5WWzumOZx1khcQo2fZXojbArVJ+1Ck23uijOevRbyTfaCMdK4yWS3wqK+4B1Y 4vutAq7uaiD2P3Nnhmv54prND24y/fo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=aDZtC5ndC8KP7Y7dZrfe3ZI/d+UPq/c3xgPgWHu0Q Fo=; b=LThybzLTJMOe+5H1fCFaO1z1ZvwjEc2Na5gKk72pAyPuZp21WA3VddzUj ifNfA/Y9U4lThvhDZVZe/1tGGoZNCHckJeXChiSBjdDUhDtaKj1+xn9iS7fkNIB8 KoEFZIV18umQEt78iS6sUdO9khRuOhAtafKcBFKv/vlgUybUwGeR10lbXFBZqIlk IJqKek4tgSUokN47JI52UoGxx9hvjqSXPeRLIcVsaQLi34bpgUu9HXkuCprGE1PA Lo5qO3kjREUhUWTbPM1KRIYNq733a8rx0oeGLQrM2cbKiK5/K/7zzYL6XHnK2MAa dE9NiqQXX924iEDdPGzeGwaKJ49vw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EDEAE4119; Tue, 30 Oct 2018 10:35:55 -0400 (EDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: Cody Doucette , "dev@dpdk.org" , Gaetan Rivet , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" Date: Tue, 30 Oct 2018 15:36:02 +0100 Message-ID: <9635910.y5ZcffoGi6@xps> In-Reply-To: <2601191342CEEE43887BDE71AB97725801030656B1@irsmsx105.ger.corp.intel.com> References: <20180727135243.147744-1-doucette@bu.edu> <5318192.uTAyPRLYMi@xps> <2601191342CEEE43887BDE71AB97725801030656B1@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 14:36:01 -0000 30/10/2018 10:46, Ananyev, Konstantin: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 28/10/2018 21:54, Cody Doucette: > > > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon wrote: > > > > 27/07/2018 15:52, Cody Doucette: > > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > > > other IPv6 extension headers when finding the fragment header. > > > > > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > > > Fragment extension header will come before any other extension > > > > > header, even though it is recommended. > > > > > > > > > > Signed-off-by: Cody Doucette > > > > > Signed-off-by: Qiaobin Fu > > > > > Reviewed-by: Michel Machado > > > > > --- > > > > > v3: > > > > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > > > > failsafe driver to allow compilation on freebsd. > > > > > > > > How failsafe is related to ip_frag? > > > > > > > > > > > > > v2: > > > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > > > > > drivers/net/failsafe/Makefile | 1 - > > > > > drivers/net/failsafe/meson.build | 1 - > > > > > examples/ip_reassembly/main.c | 6 ++-- > > > > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > > > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > > > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++ > > > > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > > > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > > > > lib/librte_port/rte_port_ras.c | 6 ++-- > > > > > > > > Changes in failsafe, rte_net and rte_port look like garbage. > > > > > > > > Anyway, the ip_frag part requires some review. > > > > +Cc Konstantin, the maintainer. > > > > > > Garbage in what sense? I would be happy to amend with a little more > > > information. > > > > > > The changes to failsafe and rte_net were from previous reviews from > > > Konstantin: > > > > > > https://mails.dpdk.org/archives/dev/2018-June/106023.html > > > > > > https://mails.dpdk.org/archives/dev/2018-July/108701.html > > > > After a better look, the change in rte_port is fine. > > > > But the changes in failsafe and rte_net would be better in their own patch. > > You can have 3 patches in a patchset (with a cover letter to explain the > > global idea). > > Then, failsafe and rte_net changes must be reviewed by their maintainers. > > > > The patch looks good to me. > About failsafe changes - the reason for that was that failsafe driver didn't build > properly with the proposed changes. > Gaetan was ok to remove that extra compiler flag: > https://mails.dpdk.org/archives/dev/2018-July/108826.html OK. Please send the failsafe patch as the first of the series. Thanks