From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C817A0C4E; Tue, 2 Nov 2021 15:34:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1731441139; Tue, 2 Nov 2021 15:34:50 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E0B594068F for ; Tue, 2 Nov 2021 15:34:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="231528973" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231528973" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 07:34:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="541229978" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 02 Nov 2021 07:34:23 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 07:34:23 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 07:34:22 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 07:34:22 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 07:34:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mfwxhicOaSv5ZEXQMa/qi+k0qndn86UVFDfZDozN2M7sdI2f5Zwn9b5NyIV7+L4jflK9keqvQ5DfUmujghQulAS1wb7icvkqzmjS+Q6guims38q488PxyObhdIsJ5+vtA6//mPul9X8txSzdM8zSYofEJ+kzUdkigAEHvLXHM6hasVuJJrQj0a6nJSqZ/SPuJrmZ5n1hDFEBreqOEbhLwEU/ivS4u2jinnDG7WkSWnWvCgSL36wt+fJCqJlM/B7oz+3chzHJdW0GIgUldsMjBllJwgiOIReicdogIIcleGe7CnstK1VNQszOVyF89QVbrJtD5Z3nvZTU0dCoQOGG/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0udmLuuTK6XwKgkyiAgeBxUCIsWygyPuRWfRDTaepzM=; b=B2RgoOjd1GLGynKSGfxBp2OXMbjZHDKZ6az8RfCWp+gty6F80U8976Q8JvlZlk2wo9VkY95ZK7M7P75KXY0eZ5akwfsHKr8BUEBPwXQGJsoNzDq0Er6AbGW+e3cKPNIJt5pMhnj3asAwd+By1DLhpuzyUAO7WsYNgACv3WhixTA8mPIjGW6ArZiJKGVMBcTE+TkEiLWRYIJGIBWIctQKOwPJERohlFHAzsdduboumJnFppQo0bb13Xz17s7o5oGWqghHotBJh4xoi6La6iFTvPl5unDhRfN+xn/iKtsvjZftyDNKQ2bfxdhWURwsZ+6vshVr3mqOQGzDxYQXHX5NWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0udmLuuTK6XwKgkyiAgeBxUCIsWygyPuRWfRDTaepzM=; b=ceZa2JfdIBcJ+7pvl7w9kY3NirZ8gLa+CzOIJoGpLYl2+2Za6+q+nZJBQYWon8WSHyUaah3l21mk3FTq+IZ76CwhXPLckxeXibBT2aDmam/MyJYc2BsEyroXaK93aR0qwyqWe4CmwA+m4plsIm0D3ysUyzGjVnfDc64FUakz9kE= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5078.namprd11.prod.outlook.com (2603:10b6:510:3e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 14:34:21 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 14:34:21 +0000 Message-ID: <964468ed-17ce-45ce-c9d5-b500cc979365@intel.com> Date: Tue, 2 Nov 2021 14:34:15 +0000 Content-Language: en-US To: Andrew Rybchenko , Thomas Monjalon , Jerin Jacob CC: , David Marchand , Ivan Malov References: <20211102125058.3872552-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:10:3b::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:10:3b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Tue, 2 Nov 2021 14:34:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ead9ed18-6cda-460b-0a24-08d99e0ddbf0 X-MS-TrafficTypeDiagnostic: PH0PR11MB5078: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: elFjmAqKNPg7MYePAMzLe7j2d9v0s3NwxxHj60r4877cZV2S0GtS3D93uZ/RBgAfC39PLpWz0nhKl/eULLuZenGa1vefnUaRZD/zxuvTLppgYPtgttNuIsKomzyp197cBVisgG5o9kHcAJUZHF9ko7B9ydBbSSon2Khj25mQKlKS50Ch+LOyMrua284nbBoo2LscSDZNrPGSyamUcpy+3ve7jCggaRlqcaLLiVyug0PP/EvPk2c3RrNbAB8SDR5MUtuQAwCXvPE4wMJKaTTyejt7b90hfp/dHOR44aaIZHmK4smGgv87ZM6vMUwBpO9f7wJubej9QIkowvs1ARVw9Z9uZ8AD+yDHXoEdiAmdEJX4ULIQC/eXfC2C4B+fWgnfjk9Rkn6zMfNpl1pUvRJzhkyV2nE9riAICxERi5MxiqUK87tX/uHHlM2yMKjl00gnvmQhMYG5bnMjmKJs9+egYtMzLdvegMuJigzPqV+6Cxhejxj/HNzVTn4XxbfaHvHmQQ7uQivJSPz5JP2f6leqNsJ4z8OCpBrU4AYiSjuMhaQOitWo2Un5i0DSHrFz/eN1WENk+ypZ9+NEMd66bnrSOcknCBVcaXlymz0AHnnmqmdy2I1IX4m2LFtSfQG2OXiS/3g2T0nGaTSKYBnC2Bb/IPjWyvGsM+r3fb1l72tmb6L4tO1FTpkSTVZoWJwzxmy9BO0dyxpPS9fTcJ665hkW0g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(44832011)(6666004)(2616005)(6486002)(86362001)(26005)(8676002)(31696002)(956004)(82960400001)(4326008)(38100700002)(83380400001)(508600001)(54906003)(8936002)(2906002)(316002)(66476007)(66946007)(66556008)(16576012)(186003)(53546011)(5660300002)(110136005)(31686004)(15650500001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enVkSzU5anVvQ2ZEUjJSYUJHRWVtMWpQU3pmeVdOaGx0dGVFeVZaSkJhNk0r?= =?utf-8?B?L2tzSSt6ejluSEZCV0RFaGxDcVZvTitlSHh5TWJKY1BBSHNZbS9iTkZTK3lY?= =?utf-8?B?eGxJU3ovUUNJWlV4MVFVaVNQZlpZK1RHWlRsOEpxUjdkYXlBaDJ5WWszaHZj?= =?utf-8?B?V1A0cEUyaDZCVnVOeTFueDN4aTlPaTdLSlREWXQ2TmJNNHdLUCs3djE1TE5h?= =?utf-8?B?Qnd1WWtVQ2RyZEVCbDZaSDFXbVNiL1pFRGtodE56c0VPUzlQR3pmVW92enAx?= =?utf-8?B?ejU5bjluSHY4dmJqREUyeXlZZDdwSFVaN09wcUlBbkxodkxNZkJ2K2JpMWtB?= =?utf-8?B?LzlNUGpOOGRhMmZSdWxjdzNPbWNjcmF5cW00UWgyTzlvaGVMbWNPVlU1R3dl?= =?utf-8?B?bGNBVkdIemlSNTBZcTFldXpKbFEvUzd6N2FWSnJOanRaZ0RQYndzQjVuTXpm?= =?utf-8?B?R3hyTTlYVjJtVy93VTZFRmwyc1VBS0FIWlRaNVBmNE1HL00ybkNqTXQ3NHc5?= =?utf-8?B?aWIzRHRWWEpKL3k2K2dpRHJjTnBXZWp6WHZtTVNmQ0xwbVo5aVFZZDIxU3Bq?= =?utf-8?B?cXovT2dzbU9LWmJYZjlDZzhTNjQ4ZFg5c1RzRDJweE9VZVVUWU8weXp1WEhF?= =?utf-8?B?SkFYL1BTYmFpNVVhbmdXRW1HSjhHRHRFMlNkZ2g2Zm1ObDdiZ2Mvc01YNXcw?= =?utf-8?B?cGY2VUFsdTZnRmwzZDRBRWJJbDdtQklkNEtYRHZtcVJybGtUckF4amhVYkpE?= =?utf-8?B?SHlkVC9pQVBjYjYveWxEd0ROS0NHSmtZdHRXVXE3c0VqaUw5dWU2NXFNbjFW?= =?utf-8?B?Y0Zyb25JWkZCMU5rbUxmM1JySEhzSWZnTXNyVC9sNW9qMkVKNDZzd1pUSzFi?= =?utf-8?B?TWluQnlHNW9wZVVZS1FkWXM5TU5qMUZQVFg2MUlSdUFpR29UcStjZFlQTlNq?= =?utf-8?B?T1ZpemR0WjZoeHZ3U1kwbWlCUmNJT3dRd1pnNFB1UlBSZ09Ra0JEa0VUbDlH?= =?utf-8?B?VVBlUU4wbzZsL0cyTU16TUpXdU5uMFYxaHR0YjNJaWt3Wjd4MWF0NkVoYlIx?= =?utf-8?B?L3ordkt3UXhOTjMxNUExdHVPcEdsbGFiakc3UVdIblZPR1hFbVpVdmt3N1Nk?= =?utf-8?B?OG9QY0wzN0JxYnVvRkN6amgzb2tLYVJxNkFLNmd2R0JmMHJOR3FMaUhrYllm?= =?utf-8?B?L3VNK3ZCYSsrazRjanhYcTBIRDlNcTZ5Z3ZSZkpCUXEySVpCOHBDakpSaFM1?= =?utf-8?B?VGplWWJwOHhjaHBBVU9sRmFFVHVTVE1pUVV1TXg0emVJUU9WcG9PVndicFNE?= =?utf-8?B?OGM4d3Q1MFdFaXh5YUhXVlVYY1F4UGdiRjhpaEx5b3JJbm95ZDlnQmdzUUJF?= =?utf-8?B?RXR2TzFPSExQU1NVeUJzajBFK1MxMjhYTENTY3RIOFN6RDBBbUFKMVVOb2lw?= =?utf-8?B?NEdSaG9yK01jZDFSeXMxb2lQVlJaVDU1RHQ2TlBlTkkrTzdFaGVoSkxBOVcx?= =?utf-8?B?N0tGcVgyd1lPMUZ6WUtjb1M2aXk4Nzl2WnlEVFdLWjhGWlhJRWlza1p0TnNk?= =?utf-8?B?SVRncHd4YVMwVzdiMXJzbElqMm5VSEJ5MHZvd2k0eGtBUzMxL0VMV0ZLTTh2?= =?utf-8?B?U0FMV2psMGdFMlJIaEFXVzE4WlRzUGRmU3I5Vms2OEZya1pKSWZjTjA0NUQy?= =?utf-8?B?U21CTVdVTDh4Wm15TUxpZTlPQ3dUUDhNa28yczd2ejJaVURBeGQxVlJCcnNo?= =?utf-8?B?ZUVYUkk3ZlJMVFM4Lzh2R2lsTVh0WFRMOXU1eThseUFCUkZsQ0ZuckN1Mjg2?= =?utf-8?B?SlNENVpSS3h3RzdNczl4Z0JOQk5IOXNFRmw1Rjh2N3VyZnloSjlyT2VjYTVM?= =?utf-8?B?REg1dExjWVlPYmp4UHpCbDRBcHM1WlpxR3JtUStXZXMrNVZTM1M0ZDRZUXBO?= =?utf-8?B?b2dwL0REODZIczRwQkhoa0UzZysycktXSWN5aEllR1dBL2l1NkMrd2hQcHRX?= =?utf-8?B?N1J2YmU4V2F6RHNBSDhhTnFTMzVaYllVcE43eUVzNTBveHREakZRTGdiYkxL?= =?utf-8?B?UHFCUzhBcU0rM0RVOEwxeWhTNHMydUZMR3IvVms3dXh5emx4UWQreW02WVdV?= =?utf-8?B?YVV1RVoxZDZXUVMvczFDNXFtSWs1NHdid3U5dEhEUThVcWlvSXRhV2Zick9J?= =?utf-8?Q?qNfxA8kLGPi8eZzLJj9GD6o=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ead9ed18-6cda-460b-0a24-08d99e0ddbf0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 14:34:21.3819 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IRzI/cDYiaTe+mCMlHtl7aupo6xV63G28Wr42LpYhDie8h1s4QeyQ8cqaNgbZUxGY1Rw97PdlrDKCDI7HtWosg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5078 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: cleanup flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2021 2:09 PM, Andrew Rybchenko wrote: > On 11/2/21 4:47 PM, Ferruh Yigit wrote: >> On 11/2/2021 12:50 PM, Andrew Rybchenko wrote: >>> The problem is solved using Rx metadata delivery negotiation API [1]. >>> >> >> Can this API replace RX_OFFLOAD_RSS_HASH too? > > It can, but it should not. RSS hash is an offload since it is a > calculation of the hash in HW and delivery of the result to SW. > Like checksums: check in HW and delivery of the result to SW. > There is a slight difference, RSS hash is always calculated if RSS is enabled, independent from RSS offload enabled or not. That is why some PMDs always provides RSS hash and force enables this offload, I would be happy to get rid of this quirk if possible. >> >>> [1] commit f6d8a6d3fad7 ("ethdev: negotiate delivery of packet metadata from HW to PMD") >>> >>> Signed-off-by: Andrew Rybchenko >>> --- >>>   doc/guides/rel_notes/deprecation.rst | 8 -------- >>>   1 file changed, 8 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >>> index 4366015b01..ec5073908f 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -69,14 +69,6 @@ Deprecation Notices >>>     and the related structures (``rte_fdir_*`` and ``rte_eth_fdir_*``), >>>     will be removed in DPDK 20.11. >>> -* ethdev: New offload flags ``RTE_ETH_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. >>> -  This will allow application to enable or disable PMDs from updating >>> -  ``rte_mbuf::hash::fdir``. >>> -  This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields on Rx and >>> -  thereby improve Rx performance if application wishes do so. >>> -  In 19.11 PMDs will still update the field even when the offload is not >>> -  enabled. >>> - >>>   * ethdev: Announce moving from dedicated modify function for each field, >>>     to using the general ``rte_flow_modify_field`` action. >>> >