From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FFC642D73; Tue, 27 Jun 2023 16:52:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF5E240F18; Tue, 27 Jun 2023 16:52:45 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DD66840EE1 for <dev@dpdk.org>; Tue, 27 Jun 2023 16:52:43 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8D12C5C0063; Tue, 27 Jun 2023 10:52:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 27 Jun 2023 10:52:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687877562; x=1687963962; bh=2hLafAG+zPijbh4n48ntElUGEWxyWF7kyBn uorraB8Q=; b=ZlEw7ElCe0AWu8znrCQMXrHjOB46hw6TTxDPkCQU8QH6yaEnuK2 UjaNXhpa2t2cRvovweY1Q38+kB0s3B6cJiYRd73pTXy+hewOuMlcaBwTUKNsjr0j B0oGj+JRfp+sT1AtxcEOyT5q/5uXThzW/DkYkadAy3RURpcuvbri18dXhlzRcxQv 5aWm4trBZP4OvJa4tBbzFdSbq37lN9eYeSGHerRssuoYNzrT5sAg8x7GrsgOaO4/ Ifr2fvAi5Xkd6+2yydo0G0qsmWpWEZu7XMvycoAGTkLroFPZ+Dk9Idi1tKPARLsR rZfyKDPrr+/2XFLv+itKWMA7zkpl5HK1J/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687877562; x=1687963962; bh=2hLafAG+zPijbh4n48ntElUGEWxyWF7kyBn uorraB8Q=; b=Wj53raVviofdGgxpCJWMoXHHA4WPRI4OdcY6leYWN3WTPqoyIBK JNeSZEJ5cbNDCcdpEczyRqeNp/1xmXg1w16tykYGBdZ3Bh5IuzMHsF2g7BhEha+b T8/rinfbWCA2Gdhj/NWD4p2p9WhIa8NqcGxJKQmDBX5UUMJQ4UudFic9D+130YEx hgX2dcV0AeOktxEC2MJNwI0JH49lQU/Zoyy46w5GGMuus6dvizgZDRS0dY6+dDD1 1o/r0uMwoy9tckj0wD4AZbfcto6pv9+Y/BzTTUzSC039mwwpX8EzblX7kGNkfj9r OKy7rCASD6RNAHalSevHDevIJ0y9GYkzShA== X-ME-Sender: <xms:uveaZAC_5COz0Rs52kNJJoZ9sxiw_Qwn4x47UKaxiVTejFdvG7PPzg> <xme:uveaZChv9ScWkGYYNUqBzrYDdbEYkU5mXop8aETSfrNrdvfyGF7jc76l5_U7HrhU9 SI31ehJxUylFNBmlg> X-ME-Received: <xmr:uveaZDmcnqU4fG9THgi4XIrFGZMGIXYuGFhwAT790Ic6OH5bFWqVL7o5LqkprIlLWH5AX6GZkng6gCS5Qz_kXNDnkg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddtgdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:uveaZGwmU7wEqqU82wTlmxrQkP7duu9OsO-OF6yfxZVJzFDck4H0mQ> <xmx:uveaZFQowDPjJZIIgYwNSeZ_BkCiRjLxx5ISXI3J0ykOj6XquetQEQ> <xmx:uveaZBZAYzPMT0rHv9wTRXw9F6-Ewko0LRTlluTv2Mozr7OW8Kweyg> <xmx:uveaZEITiKjci9WXuoz5W1WcZVBW9_FkZkF5oea2DidR-1zyao3Lfg> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 10:52:41 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com>, Ruifeng Wang <ruifeng.wang@arm.com> Subject: Re: [PATCH 0/5] cleanup in library header files Date: Tue, 27 Jun 2023 16:52:39 +0200 Message-ID: <9646715.ag9G3TJQzC@thomas> In-Reply-To: <ZInSq1LHse0ptPkN@bricha3-MOBL.ger.corp.intel.com> References: <20230614142651.1456116-1-thomas@monjalon.net> <ZInSq1LHse0ptPkN@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 14/06/2023 16:46, Bruce Richardson: > On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > > While pulling some trees for DPDK 23.07-rc1, > > I've seen that some wrong coding style for comments > > were copied over and over. > > > > In order to avoid copying wrong comment style, > > the three first patches are fixing a lot of comments. > > As it is not critical, they are not marked for backport. > > > > While looking the header files, I've fixed some misuses of "extern". > > > > > > Thomas Monjalon (5): > > lib: remove blank line ending comment blocks > > lib: remove extra asterisks ending comment blocks > > lib: align comment blocks > > lib: restrict use of keyword extern > > cryptodev: fix comments of modular operation parameters > > > > Some really good cleanup here, thanks. > > Not sure we need to fix the use of extern for functions, but removing the > extern is harmless so ok for it. > > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied