From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 081DB43C9F; Wed, 13 Mar 2024 12:27:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0A2C40A84; Wed, 13 Mar 2024 12:27:07 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 02BB9402B8 for ; Wed, 13 Mar 2024 12:27:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a59w1EX/3XO1VL1Q9Knbsy++7Z+tHyBZUOFAgA7aGkudH7cGSejhuJU4f5LHZLU260AaqSJjRw10EFPKd4qKEjv3dA3qnsQeXo2D/nerbuE0Cp2McNMgjsKsRQzOghTTdPQ6xPvWFvj+3DMAad089cM6cTJFudaDkcZVKbHXoO8jbcEubsIXYwPBYh78Qy2PqEH5UcV2EdvhyzeKJ2Ga2hZzo5HfOP/ME3RXXjxf7568XFKcHvhbatLmGonk8G2ugv1JHwY1AsSwwA4+MyGakPzgsOkmMBztKMyLa4Qp7wshkDGcaW+W7311wF1J2A0KcgVHju8PKLn1G7evCDKg9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RER+GYkd9mB3koEaexJLHAUAikyVNi9o9FyGX6Vi0AY=; b=DyDp8VRpHiMmJFYpLHibwRI87LamscRQgrleVjV4SBWUJAiWC0FGbSiIMQmeJRjlhfzTxATHqFLYu5xAozc4Xvh3xo9lexI4xKem727Gzet2rjPu9b2K8rDtnuW8pwqCkq6DCRunYrO4ixd1xm/Xa75RJnLCAxrT2+2lN/2G/zjGx7gxBTejWC3dWogDSR2QuXmWMQlU9/HjA3rIe0rirlhgMzBzitoBfPrdmulPbBUvH3O2Ijb0hM5iJsb3/qNdp8iSk09bn/Vdg+/bXamIuELjh93U/gqkIe1gX84WgCqnsjuXncUIlG6SZPmUGAB6vSJL2puqFm0KE7yEQxKrPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RER+GYkd9mB3koEaexJLHAUAikyVNi9o9FyGX6Vi0AY=; b=uypEr6ygs/HrSy5DjUHi2UIyM2SJFWNHfyKBnGWNMCRxn/IEXWPL6pq6nRG9wY6zQQcrQzGMXpscaMwrYBRTf2N/nuro6q+zL8a+65x3F2rRsqnTWzjqulTIEBS1Xs+/IrRGE39ESziEPC61AVtetsrRj113xvoQS8wcsDp9f3A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7371.namprd12.prod.outlook.com (2603:10b6:806:29a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 11:27:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 11:27:01 +0000 Message-ID: <964948b1-303c-45ba-ad7e-0ee5d4bcddf2@amd.com> Date: Wed, 13 Mar 2024 11:27:00 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/33] net/ena/hal: added a bus parameter to ena memcpy macro Content-Language: en-US To: "Brandes, Shai" Cc: "dev@dpdk.org" References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-11-shaibran@amazon.com> <0a5ae67f4fa6456b91536e09d171a259@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <0a5ae67f4fa6456b91536e09d171a259@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0104.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7371:EE_ X-MS-Office365-Filtering-Correlation-Id: c9744d8d-0d25-4787-f2a1-08dc4350808f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2vwy/PBA9vmZTlG3ps8XZcj0RoeIKkKPMrHHNVKiPzDLfI7UgOeH1zV8VVc//naniuynkPjVxQl/Zh4wzPiOY8SqzF7xC9u+PeUfp/mu/643kUTlk7ZYsJI3ZfE6YRPCON7c30J5l6QNW8En3XKxVLaMLESbD5wirdzYF0IsAjckmAsxS4c6MSEA/tYQZiJk3TWaYPLF0OUutlzTnLtWUcd/zHZLA3qMNlvGwsbK3OWXH6TEA8udCIZ5mSrc1z7SQzvVj2b0Ib7MsqS4neXJGfn2vB9V8uO1hHrXSJM1ujbAkXeI3rPVLbGPu85z2Y15QXjMJRpvfYso1OjhBMebtYdStj4nKlvUzKpcLMfdvh4fje2ZAZbeewpaEHfp7CbLOT6iyUEXpgAk/+2xzMy6cK91ux6IY6IatXMnUWx8t2h7asxRc8/rouyDpDmZjkR1A79hh1LpJEhsIzkl78iUzwlbEN8FdI0I0H8vkg/QxbroQkZgrCypMsvwQnrmzp91tCy5hwfkm2IuzzDHUFG6fKmEQ2aYI+sj1qcRKfzo1SwHY7mmL7wzRvrZ185JQ/imIAyKmXVI/8bH//rEKTCLaNSrYa+1Vr4oNnYPhZHveRsdIT4C9bdci3ALLjJTGtyvIRVos9zgnZ/7NW9C3qiCm70vY+yUsatmro+CW2iG6/8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1V6eEhzZlRuWFFJek9PeVJQb2RkRjBMSjlLeWY1RisrS3llNzRXRG10ZlZn?= =?utf-8?B?dFh1RkZad08xZXJWRlppSmFINU1TcE5Ib1JnWXpTRE8xbktsSWUxVjd4RHh5?= =?utf-8?B?TEJkclNIVzl2dkgxOXhaUncramhVcEFTWUkrZ1NoTk9MZnozeDYwb3BLM1Mr?= =?utf-8?B?eXJVK0lKMHBXSHZpNDV3NVhmQ1g2MFJxZndOb0Y3bmlNNXZnRGlzWjY0NXc5?= =?utf-8?B?M2oydi96UDJvejJ6OUdETnhDVnRDSnV5bHBqdi93WU95QzYyeW93aVFZbHBn?= =?utf-8?B?U2p5QmJZd05ZZXE0aXZCQ1MrUWt6U3B0WVJzd2pmaC9OQVNSb1J5d2l2UzZO?= =?utf-8?B?VkxqenlEalQrdHZJSHlTemhGSnNuSjFuQTE4MlhINi9YZ3Q0Rk1KQ1NWd3Fh?= =?utf-8?B?NCtuanc3dlBJUUZHZmdGcGhTVmcrZnVKOHFpRy8rcmR6OWR5TEQwMHNiekRO?= =?utf-8?B?dHhNak14dHVpa3hrQ0o3U3Zmd3Q4T0lXNmt1VVh2dXJmUVZpRllwQ1FocHhp?= =?utf-8?B?dkN2NVlwdXZQb1p4VW0wbDFrZXMyVjl5aFVzdHJ6ZzBXelo3ekxDbDVQSFUr?= =?utf-8?B?ZU1tRHlqRHJjYlZSQlQ1RmR4dlpHbzZ5V01nZFJTRUxZdW5lNnFESXNOK3A2?= =?utf-8?B?QkIxT05mbWpoeG5mMHBxM29xMTRsNFRXdm85dmRjSjZMcHFvR1FpR3EySVg5?= =?utf-8?B?VUQzc0FOWStVMGErM2V0VEVhZWQ3ZkxhU0k2QTVyS1F0ZlhHa3JSU0tpMm5m?= =?utf-8?B?clVUVkdoYzREZjAyck5oblJKNTFSN1k4UmluUzJMQTZpWWJLQ2pseVBrdmV2?= =?utf-8?B?SzBoTXY4ekdTb3pUNCt2TGZTU1JUU0pSQXdRVGwzajRRMDBrS3dwc2Jlc1RQ?= =?utf-8?B?dGRheUs4ZDQ1QkVkSldvVkx3R3pISTJmczdVQUhBMkFEdVFCL1VLcFNQL0JO?= =?utf-8?B?Yi9MTHpUZ1h0cmlGeDZDTk9GWHV1blhMcWFMNVp4U3NtMk9TbEFaaVFKZlgr?= =?utf-8?B?YXBVMlgwZWdDaG1NUVd4aTk1aHJqTWlJUTlnZkJzV2VWem01RVVzbGx3K3Bt?= =?utf-8?B?c002emNjcXpJbEVSd1BCVWVFY3lKK3ZDcng0b0xleGxQSWtSZTNoUjVoYXNz?= =?utf-8?B?cmRVTi9RbGdaUzRlRGtBZHlRMnhpQ3ZHend4cVI1UVowQTRtc3dHYkVrVFRh?= =?utf-8?B?RGNDZFE5dlIwdXhXeHUrSjJ5NkNVNDZsc212MmhjM0FuVUZHMlJjRmdydWw3?= =?utf-8?B?cm5DNjNFSU5MYVM4clY3d2hJOS9rbXJjbi8vMDJKOTY0YjVET0NIMzdmeXgr?= =?utf-8?B?MnNxVGppcTlkT3U1VlhCdjlIblJTTThTOXRyVittRjNBYVo3bDJPeUZTOUg1?= =?utf-8?B?YldKV3NxMnlDNFByUndIOWY0N3JQakk5VktyK3I0eVcwUkFZTFpVY1hkb2FJ?= =?utf-8?B?cXdtbjhkeE5SVWlONWk4MWljNTRmenpxSHNDSmg1VmNuUXV5YUlIR1o1UEJs?= =?utf-8?B?bnpMcjVTZGJnSUkwTjZBZlJ2RWcwemgxQjI4Y3EwblR5UnZOVjczSDZQN0Fa?= =?utf-8?B?b1RsMXVqNE45NmFQeU9EZmFuaHJVMkpiTUpVbUprMXJCZGliN05GSFpDRHpQ?= =?utf-8?B?ck9kQWgycW1uU1lyVkZxSmRsUm84WFhhRXg1U3dSWVZvakY0YXhCYStBNEtq?= =?utf-8?B?WThLSDh0TXYyOTdkUVBXM3FRa2xjRkdNblJhcE1lVmdSa3dYbWtNMHFIUEdU?= =?utf-8?B?Mi96ZmU3ZnJJL3hvVkhCNHpHU0JxZzJtbjhWb1BXYkFCdVpidFpDK2xJVVZW?= =?utf-8?B?WDhhR2hlc2M3czlHeUxodGljYmV2T0ZaSDI5SjRBWnh4MkcrUW04Y2JYemFF?= =?utf-8?B?VWhJenkzU0c5MTZTTWloNkh0T1ZMWU0waThCaUlpNEJwdml5Vkk2VXg1YXNW?= =?utf-8?B?RlYvVmMxOFQxVjRKYWtSTW4yNXZJUzgwU2NxclpnYnpLeFJ5TzczbUEvcEx4?= =?utf-8?B?V1FyWTFDNFQ5aG53YVQzaUtBKzJTVy9xbXkxb3Nhd1VuZ0tvVmMvTEpSTUk5?= =?utf-8?B?Y0VnSUlMdkZEbW1xeGZFRkNUUWE3UjhmQjNkZnpjRmJlNEEvUkVtaVVaeEVq?= =?utf-8?Q?uvLjcgJwB4lNn7sOo9G9VbhsH?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9744d8d-0d25-4787-f2a1-08dc4350808f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 11:27:01.4910 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vbB/qLYS0/doZZoQdwXCPn+V3kDg38HJ7NHnFUQryGZbsyNyPBhP3rlb9Yky5Zcf X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7371 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/10/2024 3:08 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:25 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 10/33] net/ena/hal: added a bus >> parameter to ena memcpy macro >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: >>> From: Shai Brandes >>> >>> ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order to write to >>> the device memory when using llq. >>> >> >> As far as I can see macro doesn't use 'bus' at all, "(void)(bus);", how/why it is >> needed for LLQ? Can you please describe it more? > [Brandes, Shai] I understand the confusion. > This is part of a hal change that concerns mac OS and required to modify the common ENA_MEMCPY_TO_DEVICE_64. > Since we expose only the DPDK-specific implementation, where this parameter is unused, it appears as void. > Avoiding this will create differences between the internal and upstream versions which will make it hard to maintain. > It is OK to have it, as you said to reduce the diff, but please update the commit log with above detail, and it will be OK.