From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BCD9A04C3; Mon, 28 Sep 2020 17:24:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B336E1D9F0; Mon, 28 Sep 2020 17:24:31 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 3A6DD1D9BF; Mon, 28 Sep 2020 17:24:29 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B788E5C004D; Mon, 28 Sep 2020 11:24:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 28 Sep 2020 11:24:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= W9/WkPtL2W2m1cYN6sPvyeN++AmwTz+HiOCL5Gw0FVM=; b=sdRp0YZi6mWhKqAR 5EO9oUw4nQQs3gWnsSQgzSwVh8DX1dJe3ooj1+Xipyv14UrkzPffuAwEykUqXWuq yOV0I4IBJYsFyNvvpMr5Hvf0kKvUAzYwC9j4NA/e7KpjIg072OdmCnrAlM92SdgG nCVjmsDqBCicV/UlCYM/rcBOWdvZrYrUY+okIDKuZZQZn4000Yr8EJ98dgkr0YSC g7h4dk4YqJ+2wr0CtbE6RDUZkFPzbmXiOL0Lh+odEtnUa5Eve62lqzfDkdpzAsEv BKcuy1W1W8Ld0Vk4JBGHMptE0OANpQxicJN/bYWh4n+rumuhK37T+zd1zykEpMZK 3PsV/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=W9/WkPtL2W2m1cYN6sPvyeN++AmwTz+HiOCL5Gw0F VM=; b=oc67B03lXaNyHEIFkTRmQl/K8voX2Qxa2wy8TZFs9rA7EwoE6H//BW6DE PrAo2OE9r6JmRk11NoxsTBLQuLxKR6pjUdP6Z20fyfnrXY4JhVqiQPJpaUCRg6tI ErZIit5PZHa4xHqHJ8eG77DcFh1+y4VPoON3dbTtFDUMfHELqTyOL4yb+YjUe5O7 8pRxxOxL2Pkr+LQ5hKsrSCIeW/liMqEUtXwW/hOa5CBLrNaLZjtSgtd5yorE2SSE gpX6+6AfT5l3b9WMry33ZCZq9nsgl5m5JhZHnXOvpOytGqNZn+wf4KjANyIMwFOq TROczxhToO8F8DumTB+jouVP5mIcw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 58A063064685; Mon, 28 Sep 2020 11:24:27 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: "Min Hu (Connor)" , "techboard@dpdk.org" , stephen@networkplumber.org, bruce.richardson@intel.com, "jerinj@marvell.com" , Ray Kinsella , dev@dpdk.org Date: Mon, 28 Sep 2020 17:24:26 +0200 Message-ID: <9656261.dg2788STim@thomas> In-Reply-To: References: <1598845317-55956-1-git-send-email-humin29@huawei.com> <32785804.XpyAPG8jY8@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH V5 1/2] dpdk: resolve compiling errors for per-queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/09/2020 15:53, Ferruh Yigit: > On 9/28/2020 10:16 AM, Thomas Monjalon wrote: > > 28/09/2020 10:59, Ferruh Yigit: > >> On 9/27/2020 4:16 AM, Min Hu (Connor) wrote: > >>> From: Huisong Li > >>> > >>> Currently, only statistics of rx/tx queues with queue_id less than > >>> RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > >>> application scenario that it needs to use 256 or more than 256 queues > >>> and display all statistics of rx/tx queue. At this moment, we have to > >>> change the macro to be equaled to the queue number. > >>> > >>> However, modifying the macro to be greater than 256 will trigger > >>> many errors and warnings from test-pmd, PMD drivers and librte_ethdev > >>> during compiling dpdk project. But it is possible and permitted that > >>> rx/tx queue number is greater than 256 and all statistics of rx/tx > >>> queue need to be displayed. In addition, the data type of rx/tx queue > >>> number in rte_eth_dev_configure API is 'uint16_t'. So It is unreasonable > >>> to use the 'uint8_t' type for variables that control which per-queue > >>> statistics can be displayed. > > > > The explanation is too much complex and misleading. > > You mean you cannot increase RTE_ETHDEV_QUEUE_STAT_CNTRS > > above 256 because it is an 8-bit type? > > > > [...] > >>> --- a/lib/librte_ethdev/rte_ethdev.h > >>> +++ b/lib/librte_ethdev/rte_ethdev.h > >>> int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t port_id, > >>> - uint16_t tx_queue_id, uint8_t stat_idx); > >>> + uint16_t tx_queue_id, uint16_t stat_idx); > > [...] > >>> int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, > >>> uint16_t rx_queue_id, > >>> - uint8_t stat_idx); > >>> + uint16_t stat_idx); > > [...] > >> cc'ed tech-board, > >> > >> The patch breaks the ethdev ABI without a deprecation notice from previous > >> release(s). > >> > >> It is mainly a fix to the port_id storage type, which we have updated from > >> uint8_t to uint16_t in past but some seems remained for > >> 'rte_eth_dev_set_tx_queue_stats_mapping()' & > >> 'rte_eth_dev_set_rx_queue_stats_mapping()' APIs. > > > > No, it is not related to the port id, but the number of limited stats. > > > > Right, it is not related to the port id, it is fixing the storage type for index > used to map the queue stats. > > >> Since the ethdev library already heavily breaks the ABI this release, I am for > >> getting this fix, instead of waiting the fix for one more year. > > > > If stats can be managed for more than 256 queues, I think it means > > it is not limited. In this case, we probably don't need the API > > *_queue_stats_mapping which was invented for a limitation of ixgbe. > > > > The problem is probably somewhere else (in testpmd), > > that's why I am against this patch. > > > > This patch is not to fix queue stats mapping, I agree there are problems related > to it, already shared as comment to this set. > > But this patch is to fix the build errors when 'RTE_ETHDEV_QUEUE_STAT_CNTRS' > needs to set more than 255. Where the build errors seems around the > stats_mapping APIs. It is not said this API is supposed to manage more than 256 queues mapping. In general we should not need this API. I think it is solving the wrong problem.