From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0BFE11B206 for ; Thu, 16 Nov 2017 18:27:39 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2017 09:27:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,404,1505804400"; d="scan'208";a="3463325" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 16 Nov 2017 09:27:38 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 16 Nov 2017 09:27:38 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.51]) by FMSMSX151.amr.corp.intel.com ([169.254.7.181]) with mapi id 14.03.0319.002; Thu, 16 Nov 2017 09:27:37 -0800 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: Adrien Mazarguil , Olivier Matz , "Wu, Jingjing" , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit Thread-Index: AQHTWWDZPY7QQo2jgkmExtAq8OdUd6MVYyeAgAHpdACAAIFIgIAABduA Date: Thu, 16 Nov 2017 17:27:37 +0000 Message-ID: <966D87A8-0B36-4B01-862C-EC9DB55667B3@intel.com> References: <1510234868-31053-1-git-send-email-adrien.mazarguil@6wind.com> <48C2CD08-29E1-444C-BF60-B96BE58865A5@intel.com> <20171116092356.GM24849@6wind.com> <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com> In-Reply-To: <6df8c8c1-325c-e924-94bf-9fced812ecf9@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.241.224.135] Content-Type: text/plain; charset="us-ascii" Content-ID: <675503EF6FBD3246910B59C09E5C209D@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] cmdline: rework as a wrapper to libedit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2017 17:27:40 -0000 > On Nov 16, 2017, at 9:06 AM, Yigit, Ferruh wrote= : >=20 > On 11/16/2017 1:23 AM, Adrien Mazarguil wrote: > <...> >=20 >>> I do not agree it has severed DPDK well, just look at test-pmd and the = hoops people have to jump thru to get a new command or variation of an exis= ting command integrated into test-pmd it is very difficult. Also if you loo= k at the command sets in test-pmd they are very odd in that similar command= s can some times be set up completely different as cmdline is too rigid and= difficult to use. >>=20 >> Testpmd is indeed messy, but this is not librte_cmdline's fundamental fa= ult >> in my opinion, more likely the result of using a copy/paste approach to = new >> commands due to lack of time or interest in making things nicer than the >> bare minimum to validate features. There's no design direction for it he= nce >> the lack of uniformity in the command hierarchy. >=20 > Unrelated to cmdline discussion +1 for this paragraph. As a side note should CLI change the test-pmd commands to be more reasonabl= e or maintain the current commands to not break testing. I would like to fi= x these commands with CLI, but as I have both built into test-pmd currently= we can could keep the old cmdline commands and if you use the new CLI then= it would be the new cleaner commands. Regards, Keith