From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FFAFA04F1; Mon, 9 Dec 2019 15:41:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 229B92C12; Mon, 9 Dec 2019 15:41:52 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 35F251F5 for ; Mon, 9 Dec 2019 15:41:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 06:41:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,296,1571727600"; d="scan'208";a="414090529" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by fmsmga006.fm.intel.com with ESMTP; 09 Dec 2019 06:41:46 -0800 To: Andrew Rybchenko , Ajit Khaparde Cc: dpdk-dev , Thomas Monjalon , Konstantin Ananyev References: <20191207005919.10962-1-ajit.khaparde@broadcom.com> <20191207005919.10962-2-ajit.khaparde@broadcom.com> <096af21e-a1c7-e19a-04f0-b5bb35e0e4aa@solarflare.com> <39b351d7-1569-102e-2ee3-180219422d22@solarflare.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <967067ad-9c93-58b0-4de3-03a1177f4428@intel.com> Date: Mon, 9 Dec 2019 14:41:46 +0000 MIME-Version: 1.0 In-Reply-To: <39b351d7-1569-102e-2ee3-180219422d22@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add RSS hash level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/9/2019 7:35 AM, Andrew Rybchenko wrote: > On 12/7/19 10:56 PM, Ajit Khaparde wrote: >> On Sat, Dec 7, 2019 at 1:14 AM Andrew Rybchenko >> wrote: >> >>> On 12/7/19 3:59 AM, Ajit Khaparde wrote: >>>> This patch adds ability to configure RSS hash level in hardware. >>>> This feature will allow an application to select RSS hash calculation >>>> on outer or inner headers for tunneled packets. >>>> >>>> Signed-off-by: Ajit Khaparde >>>> --- >>>> lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++ >>>> 1 file changed, 27 insertions(+) >>>> >>>> diff --git a/lib/librte_ethdev/rte_ethdev.h >>> b/lib/librte_ethdev/rte_ethdev.h >>>> index 18a9defc2..5189bdbab 100644 >>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>> @@ -444,11 +444,35 @@ struct rte_vlan_filter_conf { >>>> * The *rss_hf* field of the *rss_conf* structure indicates the >>> different >>>> * types of IPv4/IPv6 packets to which the RSS hashing must be applied. >>>> * Supplying an *rss_hf* equal to zero disables the RSS feature. >>>> + * >>>> + * The *rss_level* field of the *rss_conf* structure indicates the >>>> + * Packet encapsulation level RSS hash @p types apply to. >>>> + * >>>> + * - @p 0 requests the default behavior. Depending on the packet >>>> + * type, it can mean outermost, innermost, anything in between or >>>> + * even no RSS. >>>> + * >>>> + * It basically stands for the innermost encapsulation level RSS >>>> + * can be performed on according to PMD and device capabilities. >>>> + * >>>> + * - @p 1 requests RSS to be performed on the outermost packet >>>> + * encapsulation level. >>>> + * >>>> + * - @p 2 and subsequent values request RSS to be performed on the >>>> + * specified inner packet encapsulation level, from outermost to >>>> + * innermost (lower to higher values). >>>> + * >>>> + * Support for values other than @p 0 is dependent on the underlying >>>> + * hardware in use. >>>> + * >>>> + * Requesting a specific RSS level on unrecognized traffic results >>>> + * in undefined behavior. >>>> */ >>>> struct rte_eth_rss_conf { >>>> uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ >>>> uint8_t rss_key_len; /**< hash key length in bytes. */ >>>> uint64_t rss_hf; /**< Hash functions to apply - see below. */ >>>> + uint32_t rss_level; /**< RSS hash level */ >>>> }; >>> >>> I'm not sure that offload flag is required in this case. >>> I think maximum supported rss_level in dev_info will provide >> >> more information and per-queue level does not make sense > > I think information about maximum RSS hash level could be > useful. At least it provides clear information about > limitations instead of attempt to configure with RSS level > equal to 3 and getting error without clear understanding why > if the level is not supported. +1 to not have 'DEV_RX_OFFLOAD_RSS_LEVEL' offload flag. The existing 'DEV_RX_OFFLOAD_RSS_HASH' offload flag is just to enabling copying calculated hash value to mbuf field, RSS configuration still done via the configure API and related config structs. Since there is single field in mbuf for rss hash, no need additional offload flags. But I think we can have new field in rss config, and Andrew's suggestion to have it in dev_info looks reasonable. As Konstantin's point, do we really have multiple level, or just inner/outer? If it is just inner/outer perhaps we can simplify the config/logic to enums instead of 32bit rss levels? > >>> in this case. Even if per-queue group control is required, >>> it should be doable via rte_flow API RSS action. >>> >> This is dev config and not flow specific configuration. Ofcourse while >> passing >> the rss_config, not all the queues may be specified, but that is not a new >> behavior and it is upto the application anyway. > > Yes, of course. I was just trying to explain why Rx offload is > not required and it should be just dev_info field with maximum > RSS level supported. > >> Are we transitioning the device level configuration to rte_flow/flow >> based scheme? > > No-no, see above. > >>> Anyway, it looks like it is ABI breakage with all consequences. >>> In 64-bit case it is possible to put it before rss_hf to avoid >>> ABI breakage, but it will break ABI on 32-bit anyway. >>> >> Right. >> I sent the proposal for review early to get it cleaned up and ready >> when the window opens. > > OK, good. Just to reminder that unless something changes that window is 20.11, so there is quite a lot of time for it. We can clarify with Thomas, but as far as I understand we still need to update (and ack) the deprecation notices for possible ABI breakages for next breakage window. > >>> >>>> /* >>>> @@ -599,6 +623,8 @@ rte_eth_rss_hf_refine(uint64_t rss_hf) >>>> ETH_RSS_GENEVE | \ >>>> ETH_RSS_NVGRE) >>>> >>>> +#define ETH_RSS_LEVEL_DEFAULT 0 >>>> + >>>> /* >>>> * Definitions used for redirection table entry size. >>>> * Some RSS RETA sizes may not be supported by some drivers, check the >>>> @@ -1103,6 +1129,7 @@ struct rte_eth_conf { >>>> #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 >>>> #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 >>>> #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 >>>> +#define DEV_RX_OFFLOAD_RSS_LEVEL 0x00100000 >>>> >>>> #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ >>>> DEV_RX_OFFLOAD_UDP_CKSUM | \ >>>> >>> >>> >