From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EDCBA0588; Tue, 21 Apr 2020 11:11:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5BF11D8DE; Tue, 21 Apr 2020 11:11:30 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E78231D5DB for ; Tue, 21 Apr 2020 11:11:28 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 89DD05C01D2; Tue, 21 Apr 2020 05:11:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 21 Apr 2020 05:11:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= p69doiJkTFsb4Kwkurg6Yg3rxo36f2lvr/iOTHvtG4I=; b=ai4iVaN8N9NRYafs C91f7JYfT4I2eIhf4St+Zi5mUHnv9u4zG50LPLJTlgidg7lI8bJno3Ie7yJQiVK3 ud+aAdxwH8NAJeRIFV+vo4afgUYpUkc7BnF85wxyJOjlVP+jh72iv8rHzF9mBq5G shYs5h7ohYxj7YnFXyEVN0TvguWZXpINvxzmaO9e4vJKfQDU23yLYMPDbN+09gHp 2w7kgFjXFqStyH6eWHpzG2sgjbTZu1EsZMWlyLu4L+3uJkLOLUgx0O87X9Jcguu8 FkFq5XpNZmQT4Q4DNss5RbLqJl2La5a0/4BhKzU+RoNKHhKoEKiLqQptDv3y0ODL kHdkYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=p69doiJkTFsb4Kwkurg6Yg3rxo36f2lvr/iOTHvtG 4I=; b=4l2VlgfNv2PCU6swMQoILW9NW/l/6WZvF+q1E2BDIV6UGiYZ4ePoXUaI7 ziNUoj/a2G8TL2zLXfKYMwPqKcR/uW1X2rAVI/cFEOX/2pm48ZEbRb5RAA5mC/93 OqD56LwFVqBNuPZsobKoyu1cbDMOHphEsifLv4xf3V9wbXAJVJZW001iCwOMCtLy 5l15ODUrmZq5oAd9z5R/un+6BnM7RvDnAy3mTbt3ayZ7qlsFNeRUDc2v/fI06tMs fZTct9EYq+LOTjxkrsCVJJAode//S4sexHbAfcx7UGAzIpddf1nKmMXd4qKocykc q/ABmhLxbfZTKLxFY4hohipKpmOHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeehgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E46CD328005A; Tue, 21 Apr 2020 05:11:26 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: Jerin Jacob , Sunil Kumar Kori , John McNamara , Marko Kovacevic , dpdk-dev , "Richardson, Bruce" , David Marchand , Mattias =?ISO-8859-1?Q?R=F6nnblom?= Date: Tue, 21 Apr 2020 11:11:25 +0200 Message-ID: <9680747.nUPlyArG6x@thomas> In-Reply-To: References: <20200413150116.734047-1-jerinj@marvell.com> <3354690.gORTcIGjah@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2020 07:47, Jerin Jacob: > On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > > > Hi, > > > > Below is a doc review. > > General comment: it is better to split lines after punctuation signs > > in order to make future patches easier to read. > > Thanks for the review. > Except below two comments, Everything else accepted and fixed in v7. > > > > + > > > +Register the tracepoint > > > +~~~~~~~~~~~~~~~~~~~~~~~ > > > + > > > +.. code-block:: c > > > + > > > + #define RTE_TRACE_POINT_REGISTER_SELECT /* Select trace point register macros */ > > > > I don't understand this #define. > > See the headerfile. > /** > * Macro to select rte_trace_point_emit_* definition for trace register function > * > * rte_trace_point_emit_* emits different definitions for trace function. > * Application must define RTE_TRACE_POINT_REGISTER_SELECT before including > * rte_trace_point.h in the C file where RTE_TRACE_POINT_REGISTER used. > * > * @see RTE_TRACE_POINT_REGISTER > */ > #define RTE_TRACE_POINT_REGISTER_SELECT Please add an explanation in the doc about why it is needed, the rationale. > > > +Trace file location > > > +------------------- > > > + > > > +On ``rte_trace_save()`` or ``rte_eal_cleanup()`` invocation, the library saves > > > +the trace buffers to the filesystem. By default, library saves trace files at > > > +``$HOME/dpdk-traces/rte-yyyy-mm-dd-[AP]M-hh-mm-ss/``. It can be overridden by > > > > Please don't create a specific directory, but use rte_eal_get_runtime_dir(). > > Trace files are huge in size, /var/run is not the correct place to store it. > User needs to have control over where the trace file generated.It can > be different than rte_eal_get_runtime_dir(). > Multiple DPDK application running case has been taken care of by using > eal_get_hugefile_prefix() in trace session creation. At least, the default directory should be the runtime_dir I think. It's not good to create new directories without user approval. > > > +the ``--trace-dir=`` EAL command line option. > > > > I don't think this option is needed. > > XDG_RUNTIME_DIR environment variable can do the same.