From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A42FAA04B2; Mon, 4 May 2020 18:51:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33A191D177; Mon, 4 May 2020 18:51:37 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 30B7B1D172 for ; Mon, 4 May 2020 18:51:35 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A5B855C01D7; Mon, 4 May 2020 12:51:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 04 May 2020 12:51:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= fYwsFb2A9OA0L7JezwlchS3zPoWHJHBrrV7DFEbn+iA=; b=ubpAu6PcYU0dWocS kpHeZJvZRxnLCBsoCWBCU1rhjlqdS8n6Ev3JlA7Jy+ZGng2zykRva0vPRYLobuZM r8ds+mvvItP/ZXbKPa0rih/Z3Rm2s/9ALZtlW9os38LDhUfwvucUYGQWbXJJytfJ 96SGyna8Gb8y0i4Vs6T7QgUUBPhFL5KxxZ+XzDzVid1CzvOfS3ccKlXOZR+edwnn hUblkwnmV2tChf+BnqXBWfbCJlN/vw5p1lMX1cirKA/VyTgNX782AfyzqNkp1HVW rkT3TJWVwLHntl9rkhYwbsdEyquu6wDc9ytpd/WzT01hj6JMIbEvQpYXWwPQ+Q3+ OrxqoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=fYwsFb2A9OA0L7JezwlchS3zPoWHJHBrrV7DFEbn+ iA=; b=Yur2OI+H35L6trDvK0meNoF5ZIaJSRBTPQ/zYS92bFvPNeWcEPoQM8xeV uAo/VRoryW434YZg42h6dvuJeIipC8n61MwukYmlkmoY19NXvqgO1cfiIQIjpGoc 8F6JPzTS+YN5L1HFrBO4c0Q8pk/4HQNssC4Cy4MEyjeKlHYUnznjUMvUDJovUNiQ veRV2A0PnkRjKexbTS41M+8kOgpug63BJMYukY2pK7RCw13PRYlBAUad4QNKFGpy 2YMKlrZ7hKDHjVQkzFreu3av2vUflthblbdGGKwZI5+RxcIRPT4mdphHg5XWu/7U 8xWxK7yP+U6DPt+vwwZlqlR+ImYRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrjeeggdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeeuueefjedtfedtvdfhffeigfetueelgfelueduieekkefhtdegfffh tddtledvteenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhmihgtrhhoshhofhhtrd gtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 758523280068; Mon, 4 May 2020 12:51:33 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , Ranjit Menon Cc: Pallavi Kadam , dev@dpdk.org, Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com Date: Mon, 04 May 2020 18:51:32 +0200 Message-ID: <9687790.nUPlyArG6x@thomas> In-Reply-To: <9807143d-1a85-eef9-5ea2-0609b044b147@intel.com> References: <20200429232427.7112-1-pallavi.kadam@intel.com> <20200430103051.5df8b23a@Sovereign> <9807143d-1a85-eef9-5ea2-0609b044b147@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/05/2020 03:08, Ranjit Menon: > On 4/30/2020 12:30 AM, Dmitry Kozlyuk wrote: > > On 2020-04-30 08:52 GMT+0200 Thomas Monjalon wrote: > >> 30/04/2020 01:24, Pallavi Kadam: > >>> Added fnmatch implementation on Windows to support > >>> log level arguments. > >>> The source file is with BSD-3-Clause license. > >>> https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c > >> > >> Sorry for the naive question, I don't know Windows programming. > >> > >> Do we really need this external code? > >> Why RtlIsNameInExpression from Windows cannot be used? > >> https://docs.microsoft.com/en-us/windows/win32/devnotes/rtlisnameinexpression > > > > The general reason not to use Win32 API for globbing is poorly documented > > contract: what are the exact matching rules? They're definitely incompatible > > with fnmatch(3). IMO small external code is better than unknown behavior. > > > > RtlIsNameInExpression is an internal call for drivers and services with a > > cumbersome API. PathMatchSpecA is the user-mode interface, but see above. > > > > https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-pathmatchspeca > > > > I will agree with Dmitry here. The fnmatch external code is shipping, > production quality code. So it's better to use it than writing something > new. OK thank you for the explanations and opinions.