DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, marko.kovacevic@intel.com, john.mcnamara@intel.com,
	sanjay.padubidri@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] doc/testpmd: update compile steps for bpf examples
Date: Wed, 29 May 2019 13:17:52 +0200	[thread overview]
Message-ID: <9691966.DS2kSCyb6N@xps> (raw)
In-Reply-To: <20190523134744.73755-1-vipin.varghese@intel.com>

23/05/2019 15:47, Vipin Varghese:
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -4651,6 +4651,10 @@ For example:
>     cd examples/bpf
>     clang -O2 -target bpf -c t1.c
>  
> +.. note::
> +
> +   To built other BPF examples, the compiler requires additional command-line options.

"To built" -> "To build"

I think this note is vague. Don't you think it may confuse user
if we don't explicit which kind of options are required?




  reply	other threads:[~2019-05-29 11:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07  8:41 [dpdk-dev] [PATCH] " Vipin Varghese
2019-05-07  8:41 ` Vipin Varghese
2019-05-07 15:07 ` Mcnamara, John
2019-05-07 15:07   ` Mcnamara, John
2019-05-09 22:31 ` Thomas Monjalon
2019-05-09 22:31   ` Thomas Monjalon
2019-05-10  1:41   ` Varghese, Vipin
2019-05-10  1:41     ` Varghese, Vipin
2019-05-23 13:47 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2019-05-29 11:17   ` Thomas Monjalon [this message]
2019-05-30 15:40     ` Varghese, Vipin
2019-06-10  5:41   ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2023-06-12 16:31     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9691966.DS2kSCyb6N@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=sanjay.padubidri@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).