From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C6937C134 for <dev@dpdk.org>; Wed, 27 Jan 2016 19:07:01 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p63so39035928wmp.1 for <dev@dpdk.org>; Wed, 27 Jan 2016 10:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=//kyx4Hgpaanz9h0ZnQUm7VIWek8Gd2ogOvbV74wPZ4=; b=lPiMwAiaWOkOCS4q+rVoEndkONDtFAp5g4bZMb7CfMRiujW+dBWtzcXmKuiayBB8bS PzpgqOi1Yta1pPCw516JM8xTM89Qs7WN4WO7MvPt+8huCeHAgielT54OopjTqLHXrqwu 1XKoiQ29R6YfViHLHZEEIDCacJvNy1Js72XuK0wD6dFcks4/LD75DdHeg7KOnxdEh8C3 nJAsaDFhcnvMt2+UDMcjd10VvMlBe4uwm9L9j4ib9DQNUHO+6syCd+jGWodq6yutw9bO bcEny6gAjlDblwUPAqiXLKytkmzgQJbZoBMGqX3GIq8EegYzaFdHolxsodHtpTr+4ftn t25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=//kyx4Hgpaanz9h0ZnQUm7VIWek8Gd2ogOvbV74wPZ4=; b=SxMTGDGECMIZaM9aTh1ORdxzKo4LXOoiq/QEd76Uj7QouzDwXhi3pSnSevsCggL5De lODI01LEeOz8pvHjnf3YtXI9c0BMktmGJzdZwLiHrFI7Y92knB5m3q3J2fc3JLdOLFjW PQTp0XJWRoqAeY32EBngcIXqqulxIyYF1CIT//yKAtYhhcHhSWS8wc3+26tdzP95vB4W Ss8TYLin/MOCCil6AIWkTr5Y5QfgieLU8rGqLh9ErA97gg6eIK81p6AORZLAcVMrSSHg jo/spLrqocnfdpCR2Yxbnvnx6QD4mBrQTwAGevk/0CZW4Mfm8Fm1Xd9qYg+1fTu6O7d0 gsFg== X-Gm-Message-State: AG10YORILtRwtnc0SzLqj1eTxKpsOcrfCiyGtB2mbH80P6gqlN2HgCa+PPo6H2F3RqfTZMpY X-Received: by 10.194.19.101 with SMTP id d5mr17112070wje.72.1453918021663; Wed, 27 Jan 2016 10:07:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ll9sm7306712wjc.29.2016.01.27.10.07.00 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 10:07:00 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Date: Wed, 27 Jan 2016 19:05:52 +0100 Message-ID: <96929867.upEFuzBccp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com> References: <1453716075-28150-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] lib: remove "extern" keyword for functions from header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Jan 2016 18:07:02 -0000 2016-01-25 10:01, Ferruh Yigit: > Remove "extern" keywords in header files, the ones for function > prototypes I've seen a lot of other extern keywords. Why not removing all? > -extern int rte_eth_dev_configure(uint8_t port_id, > - uint16_t nb_rx_queue, > - uint16_t nb_tx_queue, > - const struct rte_eth_conf *eth_conf); > +int rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_queue, > + uint16_t nb_tx_queue, > + const struct rte_eth_conf *eth_conf); The indent is weird. Why not follow the guideline with 2 tabs? http://dpdk.org/doc/guides-2.2/contributing/coding_style.html#c-indentation