From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 694657D19 for ; Tue, 2 Jan 2018 07:39:22 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56D4F8763A; Tue, 2 Jan 2018 06:39:21 +0000 (UTC) Received: from [10.36.112.13] (unknown [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FB6B600CA; Tue, 2 Jan 2018 06:39:20 +0000 (UTC) To: Zhiyong Yang , dev@dpdk.org Cc: yliu@fridaylinux.org References: <20171226092500.53594-1-zhiyong.yang@intel.com> From: Maxime Coquelin Message-ID: <969398e8-be23-a487-e826-238e66ea943f@redhat.com> Date: Tue, 2 Jan 2018 07:39:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171226092500.53594-1-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 02 Jan 2018 06:39:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove unnecessary macro definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jan 2018 06:39:22 -0000 On 12/26/2017 10:25 AM, Zhiyong Yang wrote: > DPDK has already the definition of Ethernet numeric link speeds in Mbps in > the file Rte_ethdev.h, it is unnecessary to rededine virtio specific link > speeds macros again. > > Signed-off-by: Zhiyong Yang > --- > drivers/net/virtio/virtio_ethdev.c | 2 +- > drivers/net/virtio/virtio_ethdev.h | 5 ----- > 2 files changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime