From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
Shepard Siegel <shepard.siegel@atomicrules.com>,
Qiming Yang <qiming.yang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>, Rosen Xu <rosen.xu@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
Ciara Power <ciara.power@intel.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 0/7] support set thread name
Date: Fri, 16 Apr 2021 20:40:25 +0200 [thread overview]
Message-ID: <9694923.JHvA49bgKg@thomas> (raw)
In-Reply-To: <a7fa69c8-a402-672a-817a-967c6b619188@huawei.com>
13/04/2021 03:12, Min Hu (Connor):
> 在 2021/4/12 15:19, David Marchand 写道:
> > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) <humin29@huawei.com> wrote:
> >>
> >> This set of patches support set thread name for debugging.
> >>
> >> Chengwen Feng (7):
> >> net/ark: support set thread name
> >> net/ice: support set VSI reset thread name
> >> vdpa/ifc: support set notify and vring relay thread name
> >> raw/ifpga: support set monitor thread name
> >> examples/performance-thread: support set thread name
> >> telemetry: support set init threads name
> >> examples/vhost_blk: support set ctrl worker thread name
> >
> > Rather than add those calls, can maintainers check if their component
> > can use ctrl threads instead?
> > rte_ctrl_thread_create ensures both that the name is set, and that the
> > ctrl thread won't run on the same cpu as "datapath" threads.
> >
> > I also saw some issues with components creating threads.
> > I'll post a series addressing those later (net/ark, net/ice not
> > detaching/joining created threads + telemetry not checking
> > pthread_create failures).
> >
> Totally agree with David.
> By the way, for "telemetry not checking pthread_create failures", I have
> sent patches to fix it. Please check it out.
> Thanks.
Do I understand correctly that we prefer switching
to rte_ctrl_thread_create() instead of this patch series
adding rte_thread_setname()?
Any volunteer to add the use of rte_ctrl_thread_create()
in these drivers and examples?
next prev parent reply other threads:[~2021-04-16 18:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 10:40 Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 1/7] net/ark: " Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 2/7] net/ice: support set VSI reset " Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 3/7] vdpa/ifc: support set notify and vring relay " Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 4/7] raw/ifpga: support set monitor " Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 5/7] examples/performance-thread: support set " Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 6/7] telemetry: support set init threads name Min Hu (Connor)
2021-04-10 10:40 ` [dpdk-dev] [PATCH 7/7] examples/vhost_blk: support set ctrl worker thread name Min Hu (Connor)
2021-04-12 7:19 ` [dpdk-dev] [PATCH 0/7] support set " David Marchand
2021-04-12 14:26 ` Power, Ciara
2021-04-13 1:12 ` Min Hu (Connor)
2021-04-16 18:40 ` Thomas Monjalon [this message]
2021-04-17 6:15 ` Min Hu (Connor)
2021-04-13 1:20 ` fengchengwen
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 1/7] net/ark: " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 2/7] net/ice: support set VSI reset " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 3/7] vdpa/ifc: support set notify and vring relay " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 4/7] raw/ifpga: support set monitor " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 5/7] examples/performance-thread: support set " Min Hu (Connor)
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 6/7] telemetry: support set init threads name Min Hu (Connor)
2021-04-21 10:39 ` Bruce Richardson
2021-04-17 9:09 ` [dpdk-dev] [PATCH v2 7/7] examples/vhost_blk: support set ctrl worker thread name Min Hu (Connor)
2021-04-21 13:58 ` [dpdk-dev] [PATCH v2 0/7] support set " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9694923.JHvA49bgKg@thomas \
--to=thomas@monjalon.net \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=john.mcnamara@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=qiming.yang@intel.com \
--cc=rosen.xu@intel.com \
--cc=shepard.siegel@atomicrules.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).