From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09979A04C7; Mon, 14 Sep 2020 18:13:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D98561BFC4; Mon, 14 Sep 2020 18:13:42 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 32055160 for ; Mon, 14 Sep 2020 18:13:41 +0200 (CEST) IronPort-SDR: z6w2t5xrClx3J/+r5cNNYY9PuPw/s8Kan/FiOR6fxeRUAXSHTV0Ji2Gnm9FdofWfwhrPNdD9KH GUJSmH9VAJ1w== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="158387341" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="158387341" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:13:40 -0700 IronPort-SDR: 0PM3SYaay0NNcm/ngtqPqGSLZw430/gkgIaow/IJyepSX2L2183Mj1mOgb8dxKqGaSN4jKzf+F RAXjP/5qP4uA== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="507193849" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.225]) ([10.213.247.225]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:13:38 -0700 To: "Wei Hu (Xavier)" , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Shahaf Shuler Cc: dev@dpdk.org, xavier.huwei@huawei.com References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200820014204.25035-1-huwei013@chinasoftinc.com> <20200820014204.25035-3-huwei013@chinasoftinc.com> From: Ferruh Yigit Message-ID: <9699ec7f-b809-fe99-4d0f-0e298428b675@intel.com> Date: Mon, 14 Sep 2020 17:13:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200820014204.25035-3-huwei013@chinasoftinc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/4] app/testpmd: fix VLAN offload configuration when config fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > When failing to configure VLAN offloads after the port was started, there > is no need to update the port configuration. Currently, when user > configure an unsupported VLAN offloads and fails, and then restart the > port, it will fails since the configuration has been refreshed. > > This patch makes the function return directly insead of refreshing the > configuration when execution fails. > > Fixes: 384161e00627 ("app/testpmd: adjust on the fly VLAN configuration") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Wei Hu (Xavier) Reviewed-by: Ferruh Yigit