From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 11ECE5591
 for <dev@dpdk.org>; Fri, 11 Nov 2016 12:22:09 +0100 (CET)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga104.jf.intel.com with ESMTP; 11 Nov 2016 03:22:08 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208";a="30062238"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga004.jf.intel.com with ESMTP; 11 Nov 2016 03:22:08 -0800
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <1478706261-31261-1-git-send-email-thomas.monjalon@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <969aae35-9129-d26c-70a7-fb61f0f985d1@intel.com>
Date: Fri, 11 Nov 2016 11:22:06 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1478706261-31261-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] improve git diff
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Nov 2016 11:22:10 -0000

On 11/9/2016 3:44 PM, Thomas Monjalon wrote:
> Sometimes git does not print the name of the function being changed
> after @@. It happens especially after a goto label which is not indented.
> Giving a hint about the languages of files .c, .h and .py
> will improve hunk headers of "git diff" rendering.
> 
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  .gitattributes | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 .gitattributes
> 
> diff --git a/.gitattributes b/.gitattributes
> new file mode 100644
> index 0000000..fe555f8
> --- /dev/null
> +++ b/.gitattributes
> @@ -0,0 +1,3 @@
> +*.c   diff=cpp
> +*.h   diff=cpp

Can't git auto detect to use C/C++ language diff use for .c/.h files?

Do you have a sample that generates bad hunk header, just to test?

> +*.py  diff=python
>