From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60EFD42B2C; Wed, 17 May 2023 18:45:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50B3242B8B; Wed, 17 May 2023 18:45:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 31607411F3 for ; Wed, 17 May 2023 18:45:09 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34HGRnnl016848; Wed, 17 May 2023 09:45:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=RkGCGHoZqhGkkxuyuFPbLesd7uD6YpMc9/mb4/I1+kk=; b=LEyY3Earri/t9XWEJEKcW0xyTITWaqmnsi0QbpKW9O7BbZpEGME+RfZaKF+lbXpVS51U wmKx6H+zYXTb+roScMMOinPexQ0cOx+311IDzQ1KfXoJLcGtm2eTPjQaZYpccQ+YvIfU PHxWrrLv8aM7U21klnXm7r2t8DhOXF2uByuoOV97n8aU/6A5EodnpUawndldM7btZiCY MLPaSfSagSy6O3EMkNPRNfYL9lXrOPpCIu/+DlwuQg5n4YzXysGAF7q9XfCn04BqwBkx FqIE3xJf1Tm5O9bP9Y4KPUf0dSr2g3ohVLg5J1A8nHe6wHEOx28R8V2qLYO0UQM1kSkX 8A== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3qmyex8ta5-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 09:45:08 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 17 May 2023 09:45:03 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 17 May 2023 09:45:03 -0700 Received: from BG-LT91401.marvell.com (unknown [10.193.69.246]) by maili.marvell.com (Postfix) with ESMTP id 50B185B6928; Wed, 17 May 2023 09:44:59 -0700 (PDT) From: Gowrishankar Muthukrishnan To: CC: , Akhil Goyal , Kai Ji , Gowrishankar Muthukrishnan Subject: [PATCH] crypto/openssl: fix memory leak Date: Wed, 17 May 2023 22:14:58 +0530 Message-ID: <96b2fd6a6341603426ad79f71c4bcf1342460e71.1684341281.git.gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: UHd8reSaXHVeshvjXtAcgvjEeNiSU6as X-Proofpoint-ORIG-GUID: UHd8reSaXHVeshvjXtAcgvjEeNiSU6as X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-17_02,2023-05-17_02,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Memory allocated through OPENSSL_malloc should be freed only through OPENSSL_free. Signed-off-by: Gowrishankar Muthukrishnan --- drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index 384d262621..f65fbca300 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -1927,7 +1927,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, if (EVP_PKEY_sign(dsa_ctx, dsa_sign_data, &outlen, op->message.data, op->message.length) <= 0) { - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); goto err_dsa_sign; } @@ -1935,7 +1935,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, DSA_SIG *sign = d2i_DSA_SIG(NULL, &dsa_sign_data_p, outlen); if (!sign) { OPENSSL_LOG(ERR, "%s:%d\n", __func__, __LINE__); - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); goto err_dsa_sign; } else { const BIGNUM *r = NULL, *s = NULL; @@ -1947,7 +1947,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_op *cop, } DSA_SIG_free(sign); - free(dsa_sign_data); + OPENSSL_free(dsa_sign_data); return 0; err_dsa_sign: -- 2.25.1