From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 327A4432B7;
	Mon,  6 Nov 2023 08:23:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DC93A402A9;
	Mon,  6 Nov 2023 08:23:33 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id 47FEF4027F
 for <dev@dpdk.org>; Mon,  6 Nov 2023 08:23:32 +0100 (CET)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.57])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SP2rR49cbzVls4;
 Mon,  6 Nov 2023 15:23:19 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Mon, 6 Nov 2023 15:22:45 +0800
Subject: Re: [PATCH v4 4/5] common/nfp: use new API to parse kvargs
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Chaoyong He
 <chaoyong.he@corigine.com>, <dev@dpdk.org>
References: <20230314124813.39521-1-fengchengwen@huawei.com>
 <20231105054539.22303-1-fengchengwen@huawei.com>
 <20231105054539.22303-5-fengchengwen@huawei.com>
 <20231105191906.144e7015@hermes.local>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <96babd79-aa5d-c3ce-58c9-a6566e027857@huawei.com>
Date: Mon, 6 Nov 2023 15:22:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20231105191906.144e7015@hermes.local>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Stephen,

On 2023/11/6 11:19, Stephen Hemminger wrote:
> On Sun, 5 Nov 2023 05:45:38 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
>>  	if (rte_kvargs_count(kvargs, RTE_DEVARGS_KEY_CLASS) != 0) {
>> -		rte_kvargs_process(kvargs, RTE_DEVARGS_KEY_CLASS,
>> -				nfp_kvarg_dev_class_handler, &dev_class);
>> +		rte_kvargs_process_opt(kvargs, RTE_DEVARGS_KEY_CLASS,
>> +				       nfp_kvarg_dev_class_handler, &dev_class);
>>  	}
> 
> Since kvargs_process() already does a scan, the kvargs_count() cause an extra pass.

will fix in v5

Thanks
Chengwen

> 
> .
>