From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF5EC44079; Mon, 20 May 2024 19:52:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DD4140693; Mon, 20 May 2024 19:52:37 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2060.outbound.protection.outlook.com [40.107.236.60]) by mails.dpdk.org (Postfix) with ESMTP id 59D48402EF for ; Mon, 20 May 2024 19:52:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=On14OIYYBPhxNnrr2s4Z42uGo+wmz8UW2w5JLZPdl20uRqbWn76mhbkMe/RDO7qJUeHnDdwGc7RTGzYSRVMbbWO1GsS4ZruagYHlDVmhmNVc6uQ+6Zc2mctDUaAk2q704Y6ZmutCRNlkIh5bFJliJR9dEcj6/98JQrljROovoY/jdE0kUHQNMZCGmVlGBsf7sd9Am86DNE0OE3zXw65UMGna36YMrKGAbRGc9dxqqjQqH5f+eiRX4w9QPR1O6L1fgxnUIEfsCsluE6HrhOllFP/Y0pFjf0JJkYBNH4aRURT2x4qAL9meon0y3Iz025/aO7vkajNOi/gsQqWHj/QtNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LSJTVuZYhz8fsgN3n5myq1BKYfC1jwglb0JrX2lAEl8=; b=U1W3xYV98WhPagS/KvP9hgslo09MdoNDMt+p8oHBfnoGB/xIl5uqZEJAvuL8+crk3KQYY3n1UdkHbXXZNvXUBDTW8yO19Kn6rCnGijHaudJVekvqHM8J6lQhDD6F/ws4wvzTlioHixskBGS9djsOWLS6VpfptpfmBKlF9NV8y73S6vwA8FaPZV8OnK2RflkyWlvSom7wImRAbSBSjfU8hkBB1MzLv6bulYpRZ6/NXhH0/X0bPmRXorP3EEqKRU21ri/AtMybAmmAiK/LumM0El5dEj1ZQlMKkywEi5YlYT9qXPmVKi3S2eg0pBSMexsERN32W1KP9PahOsiV7QB50A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LSJTVuZYhz8fsgN3n5myq1BKYfC1jwglb0JrX2lAEl8=; b=kM+Gy7B1vcTWhQmdywa9bcNg0q48i4XJfy9pu041t3jWtsdNp+dMMV3qsvT2rhBcSDwP7juV91Rx816ysRDtjwafbdsaSvpnwzPzreeDRN/VTUc9xG368MnVl9QlIp1Igoh4eaUxjy37jqNDhpI5oqvRhS2vlZXvbxcppBlU7MA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB8223.namprd12.prod.outlook.com (2603:10b6:208:3f3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.35; Mon, 20 May 2024 17:52:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7587.035; Mon, 20 May 2024 17:52:30 +0000 Message-ID: <96d648dc-94ac-45bc-8398-0759083d4ca1@amd.com> Date: Mon, 20 May 2024 18:52:27 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 11/12] net/tap: do not mark queue full as error To: Stephen Hemminger , dev@dpdk.org References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-12-stephen@networkplumber.org> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240502213618.11391-12-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0326.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB8223:EE_ X-MS-Office365-Filtering-Correlation-Id: 142c931d-c621-4c11-b378-08dc78f59eec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|366007|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R0hmblo4TmFRNG1sL1BueXlyT3dGMlowbFAvUzV5SXdxWFladjVwdGx5SlNz?= =?utf-8?B?YVFtTDJocTNNTmJmaVlNOEh5ZUh5ZnFIK3VsUnFsZnF4aVRhTnlITWtNN0Jy?= =?utf-8?B?aVE1SlVLL1htdHFEb2pJUDVoTHBGaCtvSHMxc0Z3dzh0MzI2TFhYT2RUR2Nq?= =?utf-8?B?N1ltMFpmY2N6Y25LQ2NoakxRUzJ3cCtMY0JDUFp3VThNVGRTUGVBOGkwc3ZH?= =?utf-8?B?YlZzaUVyam1EUFVGQVZDQW5QV05DTTRMb3ZpRG15cGxacU5kSEJEN3JuTk42?= =?utf-8?B?a2Z5ZFY4VzRaK3NwaWtzeXZjbGN0Vk5qVTZBMlIwek91T0kzU3NDd2JQbVk0?= =?utf-8?B?M1ByNERidmEzNG5CS2xwZDc3VW92dFJ5VENVcDZqcmtDU0NCcmF4N2x5L3RU?= =?utf-8?B?Wi9zTlArNnNLbnBPWGdTL2d5QmZndk1kZEx6RzAvWUVzN0ZLWXA1S3F5SE1l?= =?utf-8?B?MGNUcytaZm1Ta3BRT3pYb2dXMUZPR25ydmZjK2xib3lQdVRDdFNmbU9ydGNy?= =?utf-8?B?SlI2dStDV0xTeWRJWDc0M2xSVWs2cDZtUGxlc3dwNlgxUEIyWTZES21HMzNm?= =?utf-8?B?MEwwMm5CVDd4TmQ2b2RCZ056T0UxTVBrcXBjVHpTZmRwRG5zbGRGa0pXMWk2?= =?utf-8?B?RVpIekl3QkkrRU84Nk1RdG0wSkQ4dkplR2ZNYzBDdnpWa0JpMFdQNmhqM09H?= =?utf-8?B?U3AyYnk5eUpUYjRVcTdCaTh0WVhqbjREa1V1bEpHMmFidUE0a2lYVHR4OTQ0?= =?utf-8?B?N0dDTjYyZ1BFaEQ4aC9MY1p5TUI4NTVwbStEWlIybUlVQnY3dTI3Wmcvenhk?= =?utf-8?B?R2Ezbm0wdVRXR1Y5TGNaQ0JiZGY2UnZiNDB4S0lCcWJCSXVrZ3l1MlI2ZlZt?= =?utf-8?B?S1FJdGY3cUQ4eU1hSE4rTGpmaHRFNzAzTDBWK3IvajA1QkxaS3BtdzhFZ0dv?= =?utf-8?B?TGRtZDZLSWYyWFQxLzRleGc4ZTY2UGJjQ3J3NnlGUndkSjVpUjFuNFVSbmRI?= =?utf-8?B?TnlXekU0YlZZMmk1cThmSUhQMWlwcVhiZFRFZ2REU3JxbFN1TmFUNWsyK2tl?= =?utf-8?B?R1Uza3FrbEdsQVJ0MW9PZUdMb0ZQK3MvdkR5SDlCWmJRNEFRUWhiSi9JSjRi?= =?utf-8?B?cFRXdDRPMHF3V2tJWTRwcDkwM0VUK1M1YUQwOHFwRjBXQ1hxYWpnNGh1L29K?= =?utf-8?B?WVBxMmpQQTNXeXhCU2VJSkNoWGpPL2lHOGJJNmtwd0FXcXJteVFiMnREOTJm?= =?utf-8?B?Mzk1b2E5V1c1T0hBYlFkNWV4U3pnaldnMW5xWjBRQmVBV21XV2ZmYmphSmVW?= =?utf-8?B?REc2cFhLcHpPRFpkNngxSWhHNkZ5SFl3aXJlcStwQ0xmak1tNGRKNnE3dG1P?= =?utf-8?B?TVhIU1lTZHhNZ3A5V05rK3dsVXdoOVRzNFlRRVRnSHpnaTJpYi9nUW4wNnlY?= =?utf-8?B?L212N0pjTmxaSTN4cG9oZGNNbm9selkycjk4dFJkWlgwdlVVS1pnSFlodEdI?= =?utf-8?B?dEIyL1ViS3BhMEJ2SC9mWWRwY21IczllWmZCWm5yaFdqYWVRK3BzOWFaRE5a?= =?utf-8?B?V1Njd3JGQUhEbnBqdlJ2YWFHYjlUTFF0a3VHMk9veWNzTzBPZ016czZndUgz?= =?utf-8?B?YlJVTG1hWU12TVRTWWVuZzZ3VDlDbzBmNVZRbGxMelRCd1pQTURwSExNWG9w?= =?utf-8?B?WUdPZUdXNURmcXJ1OTdXdzVVbUtENlN5UWNYVjBtMXBJTlJ6OUZHN09BPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUZveEFkbnFjalFPcXZsUVV0cktUVHhzMEtwaHJCQUtBaHNleVRIMUtvbGJh?= =?utf-8?B?Y3YzYWEzWFRUTkNNbTI4WTcrbzU4d3hFa1Y1ZEk3aE1RREVTMG1yVnZCRlkw?= =?utf-8?B?UVhFTTM3VUM0NTVDdVUzSzE1Z003bVRhVnJKVzBST0lNSXZzY2tieTBNRW92?= =?utf-8?B?UnVlN3lJczlvMHhGOWFlM0lVcXJ2VWU0TGxuYVowd2tpQk9qUjBia3Z0QWVl?= =?utf-8?B?cVR4ZW5FSUNrY2kyOXMwUmxoUWpIaTgwYzkxRXRWUWxsMGxFa0JDUTdDbVpB?= =?utf-8?B?NHk3aG93SldmVzVPUXEvMW5jaFJnUlFsWVZGZXdoVTF2YXpBang5MlZ3ZGhr?= =?utf-8?B?YTN2K2JZZ0J5TU9HWkQ2MVUxY2UrcWxjelBNdDFHN2NxdTdMTmNjK1RkSUpU?= =?utf-8?B?RjBIaHA3ZUY4ZHE0WjRaYm84RGdURjhkNUJVaW92b2R0RDV3N0g4SUNDdEpl?= =?utf-8?B?N0pBdno4Zk82cWlWUmVvT3J5TEhVRjNVM2h3NW1vMGF0TUEvSzREWHluZmln?= =?utf-8?B?SzgyTG1oZGVwWEtRSkZCaFNyZmZ1YWQwd2FSRlk4ZlA3UE5rZU5PVG4zeUlx?= =?utf-8?B?bHVvWDBxTERxS29aSlRGcHNRRWJUMTU0bGQ4OUo4V3lpN2xpdUhMbVRHbHRK?= =?utf-8?B?Q1hIUWk4SVR4M29zMERBaDNFc3dhNnhiUkxGQ0trOTRUejZWRUlaZWR1YmZX?= =?utf-8?B?dE9NbUgxQmV5ZkE1WmplQjBaVmFZdU9kZmtzRktrUG8yOFFweDVBWEVEM0xi?= =?utf-8?B?ZXljYW9yRHNyWEt0SlliSW5iblBHUUtYUDNsK1Y0UitCZk5UbHdKb2RSdnpp?= =?utf-8?B?b3lERmNpV0hCK2J3UlBxejBjbnJDWTEwRTN3WTdNb0Yyb2tmV3FvTUJ1cllB?= =?utf-8?B?MnBtWENyd2YxTmFoTFZYN2NGRy9oY1gvZWtlWW9HWm4vMnVLVU0za1R2N0hN?= =?utf-8?B?eE5Rb1lSQ2RmYithOW1TMEUrc0ROTm1YSkd3K3JFelJIcjk0RnUzcVpzazIx?= =?utf-8?B?MUZ6b3cxeTdWUjVkdDBxRnRDK3RocjIrNTMrRys2eGg0dnMrNE1mWEZ3dHRn?= =?utf-8?B?QlFHaExtQUdEWHJSdStiNkNZOTY3NTRtZ2IybVdEcFZzRFhuMWV0cklFbThE?= =?utf-8?B?V3QzSUVsb0NsdGEzUWZ1QVIyL3k1RTFxeisxSFZablR4T1Y2T3VIYUtWQUFC?= =?utf-8?B?SVFsNURrMUdxRVZVVHFteitFQjB4UEZjTGlZaWl2cmRQUWpIelE2OEI5alZO?= =?utf-8?B?VlhHUFdELzlzMlNaQk5QY0E1UVVOYnY5WWR1c1JZNXBCTndHcUdXNDhjMWVX?= =?utf-8?B?UEI0ZVJHWDZraFh5TUd5eElYekhabERYTDJLMW4vdktlU2JZWlF3clh3cDBW?= =?utf-8?B?SHYxZVNQSXp5azNFOHRsa1k1eW56TVJmS1FtQmtmWGpIM1kveUxwSlZaOWc1?= =?utf-8?B?bXU0SGhtTGtGai8vTmpMbThXbWFmbG5iZWozVTFFZDN1bWcyQVVyNDdxNjNO?= =?utf-8?B?L1VYdCt5aCtDekVpSTgxTFFnR3k1eVU2UWsxckYvQkYrQ3ZYL1orcHVvQ05C?= =?utf-8?B?RFdBZXptQXFwMms0NDJzWmNQRWtiNVZpSElBeHB3UDVNUW1kdVNuM0pqRFBm?= =?utf-8?B?aklNMk1JNXFJZ25jQmlET1ZyTUtFZC9CdlIvYmZFZHpIa3JvaWtyYkZOU0p1?= =?utf-8?B?alBRQTFkN3BQajEwWUJFUEJnbUo3RFJuQnF5ekREa0VKU2IzajVEK0JhZlhp?= =?utf-8?B?cEk0ZXVqK05lQUU0Y2NqRW9WWWlmcjRVYlZHYlMydS9BVGZhaDZPLys4d05I?= =?utf-8?B?aWU0VWVacXJSQ2RUN05PUHhOS1AvOU5Sd3VmRFg1eGdTR1ZPRWxCRXJqMjM4?= =?utf-8?B?YUxrcnhNcWFQeURDYTZrSG56b0c5R1I4SkRRL2g0LzBQc0FOUm9NUFRTWnBx?= =?utf-8?B?NHBJRWZ6RW5iTXlJYlZQQjRLZk1yM0F5MnRvV0dtT0FQcmprOUxWYkoyRm9G?= =?utf-8?B?YU1VUGF2ZnJ4eUlaMS9vbm05cTJ4aUxyZW11UHJhLzNzekE4RHBBRG5VVGNO?= =?utf-8?B?bTdhRldhWEcza3Q4dHhOMnRBUmNRVFU0Y2dac2JCR0ZhM0xVeWtKZlJRNDVo?= =?utf-8?Q?KUvdlwCYUiJulf+KYImiRb5gu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 142c931d-c621-4c11-b378-08dc78f59eec X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2024 17:52:30.9266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ssgGERhrAPIpBP2m+cJUWjpw4fe2Q8adWYKUHLVEPZDTbQheqtay8WP9+xT77aFE X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8223 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/2/2024 10:31 PM, Stephen Hemminger wrote: > If tap device in kernel returns EAGAIN that means it is full. > That is not an error. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index 2484a82ccb..485bd35912 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -542,7 +542,6 @@ tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs, > struct rte_mbuf *seg = mbuf; > uint64_t l4_ol_flags; > int proto; > - int n; > int j; > int k; /* current index in iovecs for copying segments */ > > @@ -647,14 +646,18 @@ tap_write_mbufs(struct tx_queue *txq, uint16_t num_mbufs, > } > > /* copy the tx frame data */ > - n = writev(process_private->fds[txq->queue_id], iovecs, k); > - if (n <= 0) > - return -1; > + if (unlikely(writev(process_private->fds[txq->queue_id], iovecs, k) < 0)) { > + TAP_LOG(DEBUG, "writev (qid=%u fd=%d) %s", > + txq->queue_id, process_private->fds[txq->queue_id], > + strerror(errno)); > Do we really want logging in datapath? > + return (errno == EAGAIN) ? 0 : -1; > Nack. Returning '0' will cause 'pmd_tx_burst()' to continue and increase 'num_tx', this will mislead as packet sent successfully. We should have three return values from 'tap_write_mbufs()': <0 -> Error, 'pmd_tx_burst()' should break, stats.errors updated. 0 -> 'pmd_tx_burst()' should break, valid num_tx returned >0 -> 'pmd_tx_burst()' work as it is. > + } > > (*num_packets)++; > (*num_tx_bytes) += rte_pktmbuf_pkt_len(mbuf); > } > - return 0; > + > + return 1; > Why '1', wouldn't it be better to return number of packets written successfully.