From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A3F0A2030 for ; Wed, 19 Jul 2017 16:03:16 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2017 07:03:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="1174394380" Received: from clegutko-mobl.ger.corp.intel.com (HELO [10.252.24.143]) ([10.252.24.143]) by fmsmga001.fm.intel.com with ESMTP; 19 Jul 2017 07:03:11 -0700 To: Kirill Rybalchenko , roy.fan.zhang@intel.com References: <1500374138-6262-1-git-send-email-kirill.rybalchenko@intel.com> Cc: dev@dpdk.org From: Declan Doherty Message-ID: <96dc8c1e-b5a7-2de7-93db-4b53d7d04d5f@intel.com> Date: Wed, 19 Jul 2017 15:03:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1500374138-6262-1-git-send-email-kirill.rybalchenko@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:03:17 -0000 On 18/07/2017 11:35 AM, Kirill Rybalchenko wrote: > Operations can be dequeued from the reordering ring only after they > were dequeued from the crypto pmd with rte_cryptodev_dequeue_burst() > function. It is not correct to dequeue them when status just changed > from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED to any other value, as the > operations still can be processed by crypto pmd internally. > Now multicore scheduler workers mark status of all dequeued from > crypto pmd operations with CRYPTO_OP_STATUS_BIT_COMPLETE bit set. > Scheduler will dequeue crypto operations from reordering ring only > when this status bit is set. Prior to put this operation to output > buffer, scheduler clears this bit, so the application gets > unmodified status from crypto pmd. > > Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode") > > Signed-off-by: Kirill Rybalchenko > --- ... > Acked-by: Declan Doherty