From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69A9BA00C2; Thu, 10 Feb 2022 09:54:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5263F4013F; Thu, 10 Feb 2022 09:54:55 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 52D3D40041 for ; Thu, 10 Feb 2022 09:54:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644483293; x=1676019293; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=HmlguGvCihOcO/u0LdsRQCj2Y5SRjG5xJk/0p3umudA=; b=Ng9IEE9wBYjfcUuoE90rSE3WxCoMK4lXJPwTSEz9Zallotr+Ka7cMD9l CeTJUmWHtSTkN0YTJBP/QomDDHGcrB8hdJjIiYifbRAsxU5ugGnD31u08 OwusRIocpd8Mp5rHRB1tIUFK8Tjok6pDwM7aTeTEw6TdQwvbsNqGQ/Z+j do/v9bluH9y9i2m1rTvr/QaKxmu/uLZVXVoGKUagvZu1TOavoqF75CnWE GQaOUQMasA6EMufN3DbTnprbXMAiO/ZWLJC2CpsjXuzgjylbZ6iFtiDv2 SHofoZJyV4c2/554+Mwv79pHGJELxjirw2mnXMG3YbF1JiwvDrWRj/WiS w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="230092035" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="230092035" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 00:54:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="773804578" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2022 00:54:52 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:51 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:51 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 00:54:51 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cabdR/rYxJaOwlwVX2hY0sToLrcQoSaCOUKGjO8UGy2IUKIy3ZuFYJNwlOtpACRK0kdhTv1MqbRVnTDfGaj2fFnm57drPxDAxXjafzfG9MyOIHTbch+cagDZ15AHllY05Zfb4K5oEtsMGtJJYpEeuinJ5fBnJIzu0yu6yj14/qYkMXzUuWgUX/zEndYvb11BOG7/ZMh2N3Ic170iTIj0fsX04dkIjHOFuU5bgjwr88chW7xYOoLk8dj9lG0tRnHjk2pNVPup8gm31m4rFKqyO5Gen5V9NGJnZeMw6tMql3P0e7tZShoxU8MLIyb9/o6hd3wVLmGamSN22WAtMm97nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bi1KEuwvka6PInTDyXsguz1DfW+Jsbxeyq9GbqDriqE=; b=jM1Zfqw80qQ40x6HAkhSNcMjKgl8KE6U6CzLbUBcR0KLaMMFR0UdkM7U9UUy7DMZ2dBT3fVQCyhzUMHCh7aF3emzscODG7pMLqD73/PdJR8+xhulPv/iFJRFXEvp5trV1aOIc6a0rDKxvIIgTF1xBu7ZER82fj8WwMyp0cG3em3MTt8j1S+pKOMErVqPY5l5orBxFGdOmndmkFS7Exmqef9O0mHWagIpaX1zD/CEsL+NiRz50JpuhEWRM1OdfODJyk7sb4flq1APR28TUD9TsOUu0JM2ThsiFbFMzpt2cyZ+KTGQfpzxXXwU3LV5ybQVr8n5/njDPYorRLhpJimdMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB3374.namprd11.prod.outlook.com (2603:10b6:805:c5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 08:54:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 08:54:49 +0000 Message-ID: <972cd443-af26-c482-efab-7b239ee58f53@intel.com> Date: Thu, 10 Feb 2022 08:54:41 +0000 Content-Language: en-US To: Akhil Goyal , CC: , , , , , , , , , , , References: <20220208201111.420971-1-gakhil@marvell.com> <20220208222027.1364292-1-gakhil@marvell.com> <20220208222027.1364292-3-gakhil@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v6 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly X-User: ferruhy In-Reply-To: <20220208222027.1364292-3-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0351.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1760c33-6061-48c5-b70d-08d9ec72fea6 X-MS-TrafficTypeDiagnostic: SN6PR11MB3374:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q8aM7aOUJ8ZBCbMyygZczUoz1X4rodpm49fCsXYxVT9aw8WKxHC1lMmqCF9PED/jpqbGtbT0Gv4W2z61QlaYTyEvx1kBN6VWgJ0mqdCQo7WRMdZ8rChsUPa38uLkw67BFsJTQDXRvry8ftaB4N21jX8K7fFJlHHbzCegSxsHKeIin2sAkNuFZCpW0ROZHdHqXfobHcuShWnver+8lEms0GbV8tHQYzWFgnPNqI38V7VNEk4NWWjq1JLiAs+tdBjhpHyIUjFeGgGkvj/4H8/pV6/jexayVJnPjwhVBLOaW4lmEXdha6QFYnAEkl4uk+9zmlQIoRN/2b8yeTJaMTpncM0hGaV0/QXNpSnbvP8IhhmrFFEcRYnSfbS9AkKf7UXf6dVnaPQFVCrvPQ/cY3jdwSOmEWbML6y5JZ5fwjbn9AB+fmqoRZstx1Q7kLIG/eMckaofec0m7zRg47Hw6rdx9WiNA6KjQFY257u2ejX7hq2nN+sH0mczV7Tn+3AggdlbjIZ66ZkhN9BW4OAMzqCTtTvAW/z1DUuVq1c6MBqpG91oX7tK4neKE3C3Ejgh4LRAmtnSS1ntQm7yHMA1R5iMTb4fhXw9W+OX5et8yWAz2lKo6Phexwhqqbi2jTD8k4zoKDlRju9U5rj2jU1zBY9YT0ndlsrfzCNnlMbumR+V4iT2YXETs3O8qilc5ulsHiVmGgJBhKZk6/V1MKYzIdIKGg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(186003)(508600001)(6486002)(2616005)(6512007)(7416002)(31686004)(38100700002)(66556008)(4326008)(8676002)(66946007)(66476007)(4744005)(44832011)(5660300002)(316002)(6666004)(36756003)(31696002)(6506007)(2906002)(86362001)(8936002)(53546011)(82960400001)(55236004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDFYU2xyQXR0T1k1UVFRQWZRYmcvKyt2OXJPeGZVOUVsZEFUZThad1ZMUmJJ?= =?utf-8?B?U05uekE1NEk3REs0cW9DZnhpaWdJMlljcDVoQTJMak0xdE4weFZrV3JxbndU?= =?utf-8?B?azF3SCtFTkF1SlhsUCtRV3NlU09uM1BSRTMvZjFyRTZ6TC9GRHEwRSt1Ri9k?= =?utf-8?B?M0gxZEEzWXZEZktyWjRKeHprSmhRRHU0NUoyV0RxbVNSRXdtOTVQSFhJSkVC?= =?utf-8?B?Mm81NjR3Q1NhaFhSVnovZ2FvL2RNdmg5OFBKZDFuNk9Hb21QaTRid2tWQTAy?= =?utf-8?B?WXR2MFpsTlBXMGVaZU0vYTZEWFNFTzNZSUZpQ0JLZVc4ZHZQU2FhaEFsNm1t?= =?utf-8?B?dTYzdUJlNWxGNk51eWh6KzJhaDFtV0hQYzJsaGlhZ1JuL3JQWEp4SHVxVm45?= =?utf-8?B?VStTdWFJWitzNHpneFl1ZDJEenErY1Q0aUREWlZHUlJQdWZMNnhZUk9VNU9Q?= =?utf-8?B?SStrUHVuRkVzQ2Y2VHZtd1RvYUhpbDdydTVkZ29xdUpGbkEwQUJVaEl2Vmda?= =?utf-8?B?alZvUzcxeUJHY25hbG54d29XWW5va2JkMXA3Mi9wMmJuQUcwOFk5dkpQR2VB?= =?utf-8?B?djlWQ244cWpmSmxnUmpjUjNzSVkycUNWUXBZaE9CQjFVR3JUTkQrNk8xVmY3?= =?utf-8?B?cm81WHhUSDVjbGhFSDc1STF3T2NlYlBtbTBIQ21VNW5rMEhGTVBINjJ2MEJP?= =?utf-8?B?OU82SmRKTm9GMkZSMFNIRlVWUE55ZGh1MHNpTnk1T1dETHE3RGZKRGRUdmNp?= =?utf-8?B?bWxCMWVldXRnNm4zKy96Mnk1aWxtdEpKdlQzdTc4U2NlYkRIQVlSY01leWd1?= =?utf-8?B?U1pQTngzWDIrVjRqN2tWVWJjV1k2T2Fic3AyVTUzbVI2VUtBcStHNUtvRFo4?= =?utf-8?B?dnpFQlRhUEpsS3c1cEk1WTZTZGxIS1llYWFpSnAyNkdpVnpFdWVvVjYwQVJL?= =?utf-8?B?cWV0bGRDMW1rTzZBWVVZRldnLzhEeEpDbVFPNjBEQlRBc2JiM2FQQUI0Vm9Z?= =?utf-8?B?cmdoQStEWTB6c1BHTkFhNnN1dWI4QnE2cTJlMnZGWmIxdzdKUFAreTdacEI4?= =?utf-8?B?TXVFK255ZEVTU29MYkVxV2VsczdWNXArL012YlR5Y2dwQUxWdlJuWTFLZHI4?= =?utf-8?B?T3ViME9BUVpTVEpUcTJtSmQ2UnVvVUpvUEVlL2UySUxZZTNIejdSQmI1c1ZM?= =?utf-8?B?WENPdGZYTnFqZmhCZ1BoRklTVWtDcnk3YzAwU1hKWDBtdlRyNWt5b2RUcmYx?= =?utf-8?B?NVpRVlFWNVQ0ZEN6N0ZWZFdtWE9kbEFQQjRqYkhBQ0d2cDhiWndWeDNkSWFh?= =?utf-8?B?ZlJ4ZThYVHVHM1Zsa3BTZ1NEK0hpTmtKMVlHTGprMm1VUnB6ZHA2M0ZrVXcx?= =?utf-8?B?Q3hScmtFalZTTHUya2tGc21ZQ2t5ejZhMDR4c0FneGNuQnlkQmdsS1NtR0tJ?= =?utf-8?B?U2JNNCtETGZmMTcyRU03b3AycGNIR2t0UmxoZWo2QnkzSGtxU0Vpa2ZyYlMz?= =?utf-8?B?cmRTd0xsMjVDQmRwV0dnZmhoVEhURWFHd2dmdFFEcXJzaVhPWFI0SjQ4aUZ1?= =?utf-8?B?Z0YyT253VEZOeHdyZDZpN3RSUGo3T2dYRHozMmhQNkVmT1BvUC83WTlJT29N?= =?utf-8?B?eDQ3RFpuNUFUVUVMY2hhRDV0emJscTArdk54UjNlejRMd1g3ckZHa1ppbnRU?= =?utf-8?B?UE51Z3h0L3lvNENnc2tPWmZiL0I3MkhpOGYxVXBNV2IxYTRUOFFnYlU1WjM4?= =?utf-8?B?S2NBeFBpWm5OMllGUFE5SWNKQSszeEs1dzErOWhrRmwwYyt0Mm5TSDhTbGFa?= =?utf-8?B?bkphMlJMYXlyU2F3VDMxcnZrUUFSbUhHTkxOU2kwNmtkWDBXMkViK0Z4MTYx?= =?utf-8?B?OUNrRld0Zk91Y3Z4VmlQa0JXdW1CK0piV3lCZlhTa1laN1ZuRVpIa1JOQlZE?= =?utf-8?B?RjBkOWtyaHYxT0xRNURaVmU3OE5SR3A5SVg0TXBKTktWaGRIVUh3b2dGQ0p0?= =?utf-8?B?d1NhVk1MZTMwK2ZZcDJEbmZjR25NeU11WFprS3k2dHozSHpEVnF5L283aE9W?= =?utf-8?B?cTdmRDBlOXhaTS9OdVl2dVNGUUFuNTJYeGlkd2JjS0VpN0RTeVBkQW5iQmRk?= =?utf-8?B?VHdvUlRSa3NBOEVFSU1oSXVTSEV3VkRPQXBldUNVbUhURGlPVG5HZFc2NVo1?= =?utf-8?Q?Sgl2gwJ1taBG1nITyd+ObPc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f1760c33-6061-48c5-b70d-08d9ec72fea6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:54:49.4756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rpiKm7B/YpkBKldYYCDUkWs8G0BUucn/qiWCGzuLXrAjjBwZp5LyUrGP4mCBjuC69GeYgI25Dfl+mao9mqg9AQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3374 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:20 PM, Akhil Goyal wrote: > Hardware IP reassembly may be incomplete for multiple reasons like > reassembly timeout reached, duplicate fragments, etc. > To save application cycles to process these packets again, a new > mbuf dynflag is added to show that the mbuf received is not > reassembled properly. > > Now if this dynflag is set, application can retrieve corresponding > chain of mbufs using mbuf dynfield set by the PMD. Now, it will be > up to application to either drop those fragments or wait for more time. > > Signed-off-by: Akhil Goyal Reviewed-by: Ferruh Yigit