From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 981992F42
 for <dev@dpdk.org>; Fri,  6 Oct 2017 23:42:05 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 06 Oct 2017 14:42:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,486,1500966000"; d="scan'208";a="907559714"
Received: from unknown (HELO [10.241.225.2]) ([10.241.225.2])
 by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2017 14:42:04 -0700
To: Nirmoy Das <ndas@suse.de>
Cc: dev@dpdk.org
References: <20170829150613.10597-1-ndas@suse.de>
 <08b26c8d-a239-87b9-cb96-20730f0fb206@intel.com>
 <6ed1338c-e9b3-6765-b31b-7f1156f31dbd@suse.de>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9730e482-04b0-a945-a10f-013cce777dae@intel.com>
Date: Fri, 6 Oct 2017 22:42:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <6ed1338c-e9b3-6765-b31b-7f1156f31dbd@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 21:42:06 -0000

On 9/5/2017 10:55 AM, Nirmoy Das wrote:
> 
> 
> On 09/04/2017 11:46 AM, Ferruh Yigit wrote:
>> On 8/29/2017 4:06 PM, Nirmoy Das wrote:
>>> compilation error:
>>> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error:
>>> ‘struct net_device’ has no member named ‘trans_start’
>>>   dev->trans_start = jiffies;
>>>
>>> Signed-off-by: Nirmoy Das <ndas@suse.de>

<...>

>>> @@ -55,7 +83,9 @@
>>>  
>>>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 7, 0) || \
>>>  	(defined(RHEL_RELEASE_CODE) && \
>>> -	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4))
>>> +	 RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 4)) || \
>>> +	 (defined(SLE_VERSION_CODE) && \
>> defined check is not required, since SLE_VERSION_CODE always defined [1].
>>
>> It can be either:
>> a) (SLE_VERSION_CODE && SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
>> or directly check:
>> b) (SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
> Thanks for your comments I will modify the patch.

Hi Nirmoy,

Reminder of this patch, would be able to send a new version?

Thanks,
ferruh

>>
>>> +	  SLE_VERSION_CODE == SLE_VERSION(12, 3, 0))
>>>  #define HAVE_TRANS_START_HELPER
>>>  #endif
>>>  
>>>
> Regards,
> Nirmoy
> 
>