From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id C4012804A for <dev@dpdk.org>; Tue, 9 Dec 2014 09:53:36 +0100 (CET) Received: by mail-wi0-f170.google.com with SMTP id bs8so9384699wib.3 for <dev@dpdk.org>; Tue, 09 Dec 2014 00:53:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=d8jc/mAM0m40sw34FswjdgRNuy2mmKFP7VxNTpALzl0=; b=SJJgh5GJpQzqZV5rGdo/eMlWkMS11YyO/t2fxB9o9noZFT9wQTIUNDm038ECKYUyxN U032Kw6wiH7R122CajgUQxIvbBt/CFKOmZTlottRshV7bzEraf59UiNsWLmA21wBlTfd 2cXbCZXcpHtyislbjVcYqY4o7TjzwjWue9+O2FcXt1oM9GDiECmATxkt4xgLt31cuFC0 lgqMZLekrTaouwYo/Wrdi1JGS1kRAIPmm/OPXbbBY/fZgC/xcyDIcMuCYC5Iw6fQrElt uJvB9cVgHQPb/gZ9HUSl3s9RAB1mOLt+4dEJsa+O9IPm+EPx18xQSRpuC9cjnUFXsBHd Ceyg== X-Gm-Message-State: ALoCoQnaS69aore9xxi5PkfAoSteSiZyewFDARbB9PRdCqaA3JYQaiNxbWwXkEjVR1DQAVH9/KuS X-Received: by 10.180.73.7 with SMTP id h7mr30482562wiv.83.1418115216660; Tue, 09 Dec 2014 00:53:36 -0800 (PST) Received: from xps13.localnet ([78.188.139.117]) by mx.google.com with ESMTPSA id iz19sm12917751wic.8.2014.12.09.00.53.34 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Dec 2014 00:53:35 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Ouyang, Changchun" <changchun.ouyang@intel.com> Date: Tue, 09 Dec 2014 09:53:03 +0100 Message-ID: <9733236.VQv0hsDDec@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511944494@shsmsx102.ccr.corp.intel.com> References: <1418019716-4962-1-git-send-email-changchun.ouyang@intel.com> <1941671.RlrZxTondI@xps13> <F52918179C57134FAEC9EA62FA2F962511944494@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 09 Dec 2014 08:53:37 -0000 2014-12-09 06:40, Ouyang, Changchun: > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, December 9, 2014 2:12 PM > > To: Ouyang, Changchun > > Cc: Qiu, Michael; Stephen Hemminger; dev@dpdk.org > > Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio implementation > > > > 2014-12-09 05:41, Ouyang, Changchun: > > > Hi > > > > > > > -----Original Message----- > > > > From: Qiu, Michael > > > > Sent: Tuesday, December 9, 2014 11:23 AM > > > > To: Ouyang, Changchun; Thomas Monjalon; Stephen Hemminger > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio > > > > implementation > > > > > > > > On 12/9/2014 9:11 AM, Ouyang, Changchun wrote: > > > > > Hi Thomas, > > > > > > > > > >> -----Original Message----- > > > > >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > >> Sent: Monday, December 8, 2014 5:31 PM > > > > >> To: Ouyang, Changchun > > > > >> Cc: dev@dpdk.org > > > > >> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio > > > > >> implementation > > > > >> > > > > >> Hi Changchun, > > > > >> > > > > >> 2014-12-08 14:21, Ouyang Changchun: > > > > >>> This patch set bases on two original RFC patch sets from Stephen > > > > >> Hemminger[stephen@networkplumber.org] > > > > >>> Refer to > > > > >>> [http://dpdk.org/ml/archives/dev/2014-August/004845.html ] for > > > > >> the original one. > > > > >>> This patch set also resolves some conflict with latest codes and > > > > >>> removed > > > > >> duplicated codes. > > > > >> > > > > >> As you sent the patches, you appear as the author. > > > > >> But I guess Stephen should be the author for some of them. > > > > >> Please check who has contributed the most in each patch to decide. > > > > > You are right, most of patches originate from Stephen's patchset, > > > > > except for the last one, To be honest, I am ok whoever is the > > > > > author of this patch set, :-), We could co-own the feature of > > > > > Single virtio if you all agree with it, and I think we couldn't > > > > > finish Such a feature without collaboration among us, this is why > > > > > I tried to communicate > > > > with most of you to collect more feedback, suggestion and comments > > > > for this feature. > > > > > Very appreciate for all kinds of feedback, suggestion here, > > > > > especially for > > > > patch set from Stephen. > > > > > > > > > > According to your request, how could we make this patch set looks > > > > > more > > > > like Stephen as the author? > > > > > Currently I add Stephen as Signed-off-by list in each patch(I got > > > > > the > > > > agreement from Stephen before doing this :-)). > > > > > > > > Hi Ouyang, > > > > > > > > "Signed-off-by" should be added by himself, because the one who in > > > > the Signed-off-by list should take responsibility for it(like potential > > bugs/issues). > > > > > > > > Although, lots of patches are originate from Stephen, we still need > > > > himself add this line :) > > > > > > Hi Thomas, > > > It that right? I can't add Stephen into Signed-off-by list even if I > > > have gotten the agreement from Stephen, What 's the strict rule here? > > > > Stephen sent the patches with his Signed-off, then you added yours. > > This is OK. > > Using git am, author would have been Stephen. To change author now, you > > can edit each commit with interactive rebase and "git commit --amend -- > > author=Stephen". > > No need to resend now. Please check it for next version of the patchset. > > > > So I understand correctly, Stephen need care for from patches from 1 to 16, > I need care for the 17th patch from next version. > What I mean "caring for" above is: debug and validate them and send out patches Just to be clear: you can send patches with Stephen's authorship. That's not a problem. Please try to change --author and check how it looks when you send them. -- Thomas