From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C0DA0547; Fri, 29 Oct 2021 16:15:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F20264111F; Fri, 29 Oct 2021 16:15:27 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 88C69410E1 for ; Fri, 29 Oct 2021 16:15:26 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 149BC3201E20; Fri, 29 Oct 2021 10:15:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 29 Oct 2021 10:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= inoD4rvt60J7xDYDQZ8IEILicpxnJ4kCkoSTVMiIx/k=; b=q9cJtvQJCRbInpjW R2pVTAnRuMBBZb2PkKod/aKmHM0K1Xshe8lcjA/MoV/YK8NH4j3s/gaea3TUA8L2 5o2KuxDIGNxUVWicBm8WH2FrDqBfgIGzI+jgp+i3RNOA/fNpEkpUrVlW9znMunCW qIGYBx2iW5cG6uvpju4kr6SHZLceB23FvIO7Rs0cBw7wPc8JP4HNzW5Hdp3NbUix 4ejDjqAU77MQNkN82tRka6R9S+iL+9YdS9RMnARY7AZUI8IjQPgzF+DkDvHzFxRu p6+v74vxaXrT4UYhtwXdr3HmgCROcgv16nUKb9pU/D1JG/+MpaFhsVVWww9kis7J OMnVqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=inoD4rvt60J7xDYDQZ8IEILicpxnJ4kCkoSTVMiIx /k=; b=S7gyPJU8fqt4ZAq+yJ2M14tSC/8kbosUC5uXPeV+b4Xq8AsCIga/fBTYk W+RyKvQctuLi4EuPXKtcISeipbbz5xgL9C9taimWYCb89lZcsj903FTwo+evtqjy Bboz9f0Q3mayjxbFOwCHY5IcZ8coiPvmMVVkeEP7mEOtCCP4lMyEhgtuwrimmjJx 2tvqW7oh5guzeW2hSUNvtlfGkLwB8PZfeZIgIs+1QTwzxHOBCKCAlh7DUCk5HWGs /B2S2zwnMNzdfEJcjMJbqFPoH9J1SbU9bm1Sv2UhPjXTWrBjAY1h/+GjoTh0LmNf UEP3HvsbsXq8hl3ZiEzzUxcJGBCiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdeghedgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Oct 2021 10:15:22 -0400 (EDT) From: Thomas Monjalon To: "Dumitrescu, Cristian" Cc: "dev@dpdk.org" , "Singh, Jasvinder" , "Ajmera, Megha" , "Liguzinski, WojciechX" , "david.marchand@redhat.com" , "Mcnamara, John" , bruce.richardson@intel.com Date: Fri, 29 Oct 2021 16:15:21 +0200 Message-ID: <9737300.GZd8KyKlGs@thomas> In-Reply-To: References: <20211025113208.3910951-1-wojciechx.liguzinski@intel.com> <1856407.E66k3sLkBB@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2021 16:06, Dumitrescu, Cristian: > From: Thomas Monjalon > > 28/10/2021 12:17, Liguzinski, WojciechX: > > > Implement PIE based congestion management based on rfc8033 > > > > An explanation is missing about why RED code is removed. > > I don't know whether it deserves a separate commit, > > but at least it should be removed consisently in lib and example code > > in the same patch. > > > > Cristian, please make efforts to help this patchset be properly organized. > > A blind ack is not enough. > > > > The RED code is not removed. It is simply the macro renamed to CMAN (Congestion Management) to include both RED and PIE. OK, and where this macro is defined? Why is there such #ifdef? Even the API is conditionally compiled!