DPDK patches and discussions
 help / color / mirror / Atom feed
* [Patch v2] net/netvsc: report correct stats values
@ 2022-03-24 17:45 longli
  2022-04-26 21:56 ` Ferruh Yigit
  0 siblings, 1 reply; 16+ messages in thread
From: longli @ 2022-03-24 17:45 UTC (permalink / raw)
  To: dev, Stephen Hemminger; +Cc: Long Li, stable

From: Long Li <longli@microsoft.com>

The netvsc should add to the values from the VF and report the sum.

Fixes: 4e9c73e96e ("net/netvsc: add Hyper-V network device")
Cc: stable@dpdk.org
Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/net/netvsc/hn_ethdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 0a357d3645..a6202d898b 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -804,8 +804,8 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
 		stats->oerrors += txq->stats.errors;
 
 		if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
-			stats->q_opackets[i] = txq->stats.packets;
-			stats->q_obytes[i] = txq->stats.bytes;
+			stats->q_opackets[i] += txq->stats.packets;
+			stats->q_obytes[i] += txq->stats.bytes;
 		}
 	}
 
@@ -821,12 +821,12 @@ static int hn_dev_stats_get(struct rte_eth_dev *dev,
 		stats->imissed += rxq->stats.ring_full;
 
 		if (i < RTE_ETHDEV_QUEUE_STAT_CNTRS) {
-			stats->q_ipackets[i] = rxq->stats.packets;
-			stats->q_ibytes[i] = rxq->stats.bytes;
+			stats->q_ipackets[i] += rxq->stats.packets;
+			stats->q_ibytes[i] += rxq->stats.bytes;
 		}
 	}
 
-	stats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;
+	stats->rx_nombuf += dev->data->rx_mbuf_alloc_failed;
 	return 0;
 }
 
-- 
2.32.0


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-05-10 18:03 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 17:45 [Patch v2] net/netvsc: report correct stats values longli
2022-04-26 21:56 ` Ferruh Yigit
2022-04-26 22:45   ` Stephen Hemminger
2022-05-03 18:18     ` Long Li
2022-05-03 19:03       ` Ferruh Yigit
2022-05-03 19:14         ` Long Li
2022-05-03 19:55           ` Ferruh Yigit
2022-05-03 20:48             ` Long Li
2022-05-04 12:33               ` Ferruh Yigit
2022-05-04 18:38                 ` Long Li
2022-05-05 16:28                   ` Ferruh Yigit
2022-05-05 16:40                     ` Stephen Hemminger
2022-05-05 16:57                       ` Ferruh Yigit
2022-05-10  5:33                         ` Long Li
2022-05-10 11:29                           ` Ferruh Yigit
2022-05-10 18:03                             ` Long Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).