DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>,
	"Chaoyong.He" <chaoyong.he@corigine.com>,
	Simon Horman <simon.horman@netronome.com>
Cc: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
	dev@dpdk.org, dev@dpdk.org, konstantin.ananyev@intel.com,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices
Date: Fri, 30 Jul 2021 18:50:41 +0200	[thread overview]
Message-ID: <9748766.xn9SluQUq0@thomas> (raw)
In-Reply-To: <YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com>

13/05/2021 11:59, Bruce Richardson:
> On Wed, May 12, 2021 at 09:43:57PM +0300, Medvedkin, Vladimir wrote:
> > Hi Bruce,
> > 
> > On 12/05/2021 19:32, Bruce Richardson wrote:
> > > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote:
> > > > From: "Chaoyong.He" <chaoyong.he@corigine.com>
> > > > 
> > > > Set the Rx multi-queue mode to NONE when configuring a port that is
> > > > associated with hardware that only supports a single Rx queue.
> > > > 
> > > > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > > > Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> > > > Signed-off-by: Simon Horman <simon.horman@netronome.com>
> > > > ---
> > > > +		if (dev_info.max_rx_queues == 1)
> > > > +			local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
> > > > +
> > > 
> > > While it makes sense to do this when the port only supports a single queue,
> > > would it not also make sense to do this when the requested queues are 1
> > > too?
> > > 
> > > Adding some lookup library maintainers on CC - I assume that the RSS value
> > > is not actually used for lookup anywhere in l3fwd.
> > > 
> > 
> > As far as I can see the rss hash value is not used anywhere in l3fwd. In
> > LPM/FIB this is not required at all, in EM CRC or Jenkins hash is used.
> >
> That's what I thought from looking at the code too. Since this is not
> really a bug fix, I think it can be pushed till 21.08.
> 
> With or without the change I suggest above:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, sorry it has been waiting so long.



      reply	other threads:[~2021-07-30 16:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 16:53 Heinrich Kuhn
2021-05-12 16:32 ` Bruce Richardson
2021-05-12 18:43   ` Medvedkin, Vladimir
2021-05-13  9:59     ` Bruce Richardson
2021-07-30 16:50       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9748766.xn9SluQUq0@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=heinrich.kuhn@netronome.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=simon.horman@netronome.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).