From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79663A0C40; Fri, 30 Jul 2021 18:50:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 110D340040; Fri, 30 Jul 2021 18:50:46 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id CB4174003F for <dev@dpdk.org>; Fri, 30 Jul 2021 18:50:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 461BF5C0109; Fri, 30 Jul 2021 12:50:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Jul 2021 12:50:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= MS87gbgBv/qWWfqpRADQyEcQgV+o1uwjwawZEaULxmQ=; b=gqj7qy1jvRFNw4yU AEE+vSD8MDQ86PEDqX8Ylv2tUiKfrp46q45poD2Lfw7tZejTrxfc4dqOotj2RRSu 7NefLekqruOGjAXTN/WlUjFYvVzvA3sSRWOh9K0rt7vADOMJBdpmp3ywK/IQfCs5 5xhdgVUHSZFDiu//oPxNdfl16ZsZUQhKjgG2aifmVFgcsKS2k/VW8mKDpu6dZ7EP WMj06rp4VpQfPsWj8/9OPiFyl+m6cgGNlyt67UO/rG7sKu8omuzQYS49nMUbFpS6 Hs+ReV3nM8nVhRKZaVbLgsCPhXsLes96/O4/+u4XC6E53cXzbCy0kXFPtPQYRhgs k4tEoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=MS87gbgBv/qWWfqpRADQyEcQgV+o1uwjwawZEaULx mQ=; b=GSEqi47zmKBDVkxHUm0HMqaZN19PGz12Kd22VmEtOWd0T2xOXTytWWw/A 3SpjhtZVpdAlGWvN6yLFWD/DycBt1+3hKM0s7qHmy0wtWvy/zcehl9IYPIQgDeIP 4BYHEvPQX28iqW5zu8jUUB3d8Xga23GybbY7FGUNqtVS+JSF7vAVWM/r57yDzBoq ciRAhpLZYdqSsX/2qVy3TWqK60414Ic2u0J6pXDeA7YGGbHAD/ttT9CdrqRJAI0Y tm6qHOoVlCQTloQEvJTZSahr0QmcsjCURnFgWyCLTSEsyfsnZpg2471Ofnh+p3r6 oKZ2ICXUPMM7DTbpvCc7l9eYAjQZA== X-ME-Sender: <xms:4y0EYQzgl7fDs8sJkPgQj0gxgDoP-a_eprssTVercVTOFiAJvID_Yg> <xme:4y0EYURJ-9mmp9R8yzNkVScugG2xJODBnfX6c8Vep0VoRe6CHWXMTR_DT3dPqbOQ8 owsloeVPv7LFTVZcg> X-ME-Received: <xmr:4y0EYSWi4Q0NDj_7dK_D__gIJVRLXEE2fzECWwzg7TjGaFZ0VTWXkuLNrTanYMq0DxB-_pWhWYgDz4I-hbGCxEsuwA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrheehgdellecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudfgleetueeludffueehgeeuvdejgedvhfffheevfedttedtkeel fefhgfefgfenucffohhmrghinheprhigmhhouggvrdhmqhenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: <xmx:4y0EYeizvnWwc9Xa392chWulAVQb9XLIWo7Ao4Vq1curVvpFlzEZDg> <xmx:4y0EYSDO-L3k3H85p47UAQ6U2S3rqLB2ghWpedLMBzl9wHsXOGvzKw> <xmx:4y0EYfIfh7KAYRLUX41l92z5bsmN5Q2gCt9MvVGX_1BUOFol-8ulug> <xmx:5C0EYU1gLX5CdfF2JJQ6Sq3t5DStdgzn_tM3fDi9pWWMBJ7G_wdaVw> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jul 2021 12:50:42 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Heinrich Kuhn <heinrich.kuhn@netronome.com>, "Chaoyong.He" <chaoyong.he@corigine.com>, Simon Horman <simon.horman@netronome.com> Cc: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>, dev@dpdk.org, dev@dpdk.org, konstantin.ananyev@intel.com, Bruce Richardson <bruce.richardson@intel.com> Date: Fri, 30 Jul 2021 18:50:41 +0200 Message-ID: <9748766.xn9SluQUq0@thomas> In-Reply-To: <YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com> References: <20210510165319.9153-1-heinrich.kuhn@netronome.com> <fc0e7fac-6141-cbc8-4527-11f70efbcfeb@intel.com> <YJz4a6T4GF5iswIh@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: change mq-mode on single queue devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 13/05/2021 11:59, Bruce Richardson: > On Wed, May 12, 2021 at 09:43:57PM +0300, Medvedkin, Vladimir wrote: > > Hi Bruce, > > > > On 12/05/2021 19:32, Bruce Richardson wrote: > > > On Mon, May 10, 2021 at 06:53:19PM +0200, Heinrich Kuhn wrote: > > > > From: "Chaoyong.He" <chaoyong.he@corigine.com> > > > > > > > > Set the Rx multi-queue mode to NONE when configuring a port that is > > > > associated with hardware that only supports a single Rx queue. > > > > > > > > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com> > > > > Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com> > > > > Signed-off-by: Simon Horman <simon.horman@netronome.com> > > > > --- > > > > + if (dev_info.max_rx_queues == 1) > > > > + local_port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE; > > > > + > > > > > > While it makes sense to do this when the port only supports a single queue, > > > would it not also make sense to do this when the requested queues are 1 > > > too? > > > > > > Adding some lookup library maintainers on CC - I assume that the RSS value > > > is not actually used for lookup anywhere in l3fwd. > > > > > > > As far as I can see the rss hash value is not used anywhere in l3fwd. In > > LPM/FIB this is not required at all, in EM CRC or Jenkins hash is used. > > > That's what I thought from looking at the code too. Since this is not > really a bug fix, I think it can be pushed till 21.08. > > With or without the change I suggest above: > Acked-by: Bruce Richardson <bruce.richardson@intel.com> Applied, sorry it has been waiting so long.