From: Jeff Guo <jia.guo@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"orika@mellanox.com" <orika@mellanox.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Cao, Yahui" <yahui.cao@intel.com>,
"Su, Simei" <simei.su@intel.com>
Subject: Re: [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types
Date: Thu, 16 Apr 2020 11:22:19 +0800 [thread overview]
Message-ID: <9748e316-108c-59a1-660c-12e8732cfc73@intel.com> (raw)
In-Reply-To: <683076bf-4833-16d5-f5c3-d7e7e1474b9a@intel.com>
hi, ferruh and bernard
On 4/16/2020 6:13 AM, Ferruh Yigit wrote:
> On 4/15/2020 4:38 PM, Iremonger, Bernard wrote:
>> Hi Jeff,
>>
>>
>>> -----Original Message-----
>>> From: Guo, Jia <jia.guo@intel.com>
>>> Sent: Wednesday, April 15, 2020 6:11 PM
>>> To: Iremonger, Bernard <bernard.iremonger@intel.com>;
>>> orika@mellanox.com; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
>>> <qi.z.zhang@intel.com>
>>> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Cao, Yahui
>>> <yahui.cao@intel.com>; Su, Simei <simei.su@intel.com>; Guo, Jia
>>> <jia.guo@intel.com>
>>> Subject: [dpdk-dev v5 1/3] ethdev: add new RSS offload types
>>>
>>> Defines some new RSS offload types for ETH/S_VLAN/C_VLAN/L2TPV3/
>>> ESP/AH/PFCP/L2_SRC_ONLY/L2_DST_ONLY.
>>>
>>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>>> Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>
>>> ---
>>> v5->v4:
>>> rename ETH_RSS_ETH_XXX to ETH_RSS_L2_XXX.
>>> ---
>>> lib/librte_ethdev/rte_ethdev.h | 11 ++++++++++-
>>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
>>> index d1a593ad1..138c15a16 100644
>>> --- a/lib/librte_ethdev/rte_ethdev.h
>>> +++ b/lib/librte_ethdev/rte_ethdev.h
>>> @@ -511,6 +511,13 @@ struct rte_eth_rss_conf {
>>> #define ETH_RSS_GENEVE (1ULL << 20)
>>> #define ETH_RSS_NVGRE (1ULL << 21)
>>> #define ETH_RSS_GTPU (1ULL << 23)
>>> +#define ETH_RSS_ETH (1ULL << 24)
>>> +#define ETH_RSS_S_VLAN (1ULL << 25)
>>> +#define ETH_RSS_C_VLAN (1ULL << 26)
>>> +#define ETH_RSS_ESP (1ULL << 27)
>>> +#define ETH_RSS_AH (1ULL << 28)
>> I have a patch in flight to add ETH_RSS_ESP and ETH_RSS_AH.
>> I have used the same values as you have used.
>> http://patches.dpdk.org/patch/68550/
> Both patch sets touch similar area, both in ethdev and testpmd, and both sets
> has external dependencies, so not easy to manage.
> But since the changes are trivial, I hope it can be resolved while merging, if
> not one may be required to be rebased, based on merge order.
> btw, using same values is good idea, it helps to resolve conflict.
Agree and thanks.
>>> +#define ETH_RSS_L2TPV3 (1ULL << 29)
>>> +#define ETH_RSS_PFCP (1ULL << 30)
>>>
>>> /*
>>> * We use the following macros to combine with above ETH_RSS_* for @@ -
>>> 524,7 +531,9 @@ struct rte_eth_rss_conf {
>>> #define ETH_RSS_L3_SRC_ONLY (1ULL << 63)
>>> #define ETH_RSS_L3_DST_ONLY (1ULL << 62)
>>> #define ETH_RSS_L4_SRC_ONLY (1ULL << 61)
>>> -#define ETH_RSS_L4_DST_ONLY (1ULL << 60)
>>> +#define ETH_RSS_L4_DST_ONLY (1ULL << 60)
>>> +#define ETH_RSS_L2_SRC_ONLY (1ULL << 59)
>>> +#define ETH_RSS_L2_DST_ONLY (1ULL << 58)
>>>
>>> /**
>>> * For input set change of hash filter, if SRC_ONLY and DST_ONLY of
>>> --
>>> 2.20.1
>> Regards,
>>
>> Bernard.
>>
next prev parent reply other threads:[~2020-04-16 3:22 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 17:03 [dpdk-dev] [dpdk-dev 0/4] add RSS configuration for iavf Jeff Guo
2020-03-18 17:03 ` [dpdk-dev] [dpdk-dev 1/4] ethdev: add new RSS offload types Jeff Guo
2020-03-18 17:03 ` [dpdk-dev] [dpdk-dev 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-03-18 17:04 ` [dpdk-dev] [dpdk-dev 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-03-18 17:04 ` [dpdk-dev] [dpdk-dev 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 0/4] add RSS configuration for iavf Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 1/4] ethdev: add new RSS offload types Jeff Guo
2020-04-07 17:02 ` Iremonger, Bernard
2020-04-08 0:15 ` Zhang, Qi Z
2020-04-09 2:04 ` Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-03-29 8:44 ` Ori Kam
2020-03-30 8:29 ` Jeff Guo
2020-03-30 10:18 ` Ori Kam
2020-03-31 8:50 ` Jeff Guo
2020-04-05 15:56 ` Ori Kam
2020-04-07 5:37 ` Jeff Guo
2020-04-12 9:58 ` Ori Kam
2020-04-14 3:05 ` Jeff Guo
2020-04-14 5:57 ` Ori Kam
2020-03-26 16:40 ` [dpdk-dev] [dpdk-dev v2 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 0/4] add RSS configuration for iavf Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 1/4] ethdev: add new RSS offload types Jeff Guo
2020-04-13 0:13 ` Zhang, Qi Z
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 2/4] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-13 2:02 ` Zhang, Qi Z
2020-04-14 3:42 ` Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 3/4] app/testpmd: support GTP PDU type Jeff Guo
2020-04-11 0:09 ` [dpdk-dev] [dpdk-dev v3 4/4] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 0/3] add RSS configuration for iavf Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-14 9:42 ` Ori Kam
2020-04-15 2:31 ` Zhang, Qi Z
2020-04-15 3:11 ` Jeff Guo
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-15 2:29 ` Zhang, Qi Z
2020-04-14 17:42 ` [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-14 9:48 ` Ori Kam
2020-04-15 8:08 ` Jeff Guo
2020-04-15 16:31 ` Stephen Hemminger
2020-04-16 8:55 ` Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 0/3] add RSS configuration for iavf Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-15 15:38 ` Iremonger, Bernard
2020-04-15 22:13 ` Ferruh Yigit
2020-04-16 3:22 ` Jeff Guo [this message]
2020-04-16 6:57 ` Ori Kam
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-15 17:11 ` [dpdk-dev] [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-15 15:01 ` Iremonger, Bernard
2020-04-16 7:51 ` Jeff Guo
2020-04-16 9:14 ` Iremonger, Bernard
2020-04-16 10:22 ` Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 0/3] add RSS configuration for iavf Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-16 19:19 ` [dpdk-dev] [dpdk-dev v6 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-16 10:40 ` Ori Kam
2020-04-16 15:16 ` Jeff Guo
2020-04-16 11:16 ` Iremonger, Bernard
2020-04-16 15:15 ` Jeff Guo
2020-04-16 15:52 ` Ferruh Yigit
2020-04-17 1:50 ` Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 0/3] add RSS configuration for iavf Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-21 10:14 ` Iremonger, Bernard
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-17 18:31 ` [dpdk-dev] [dpdk-dev v7 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-19 6:53 ` Ori Kam
2020-04-21 9:44 ` Iremonger, Bernard
2020-04-21 12:37 ` Jeff Guo
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 0/3] add RSS configuration for iavf Jeff Guo
2020-04-21 17:15 ` Ferruh Yigit
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 1/3] ethdev: add new RSS offload types Jeff Guo
2020-04-21 17:15 ` Ferruh Yigit
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 2/3] net/iavf: add RSS configuration for VFs Jeff Guo
2020-04-22 1:02 ` [dpdk-dev] [dpdk-dev v8 3/3] app/testpmd: add new types to RSS hash commands Jeff Guo
2020-04-21 14:29 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9748e316-108c-59a1-660c-12e8732cfc73@intel.com \
--to=jia.guo@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).