From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73AF942D08; Tue, 20 Jun 2023 15:06:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E7904068E; Tue, 20 Jun 2023 15:06:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 43825400D6 for ; Tue, 20 Jun 2023 15:06:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687266392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U7JUJ5E1Gfz+yHNjQaCbcifm4fSUv9XoyG0rXyO9Xo4=; b=WqdFGNqOXKCVca+5tklqD0Ajj2TMbEOanXLjDFD6lo5zH4bSd4fBoaXWjjvJjSwDAAHtLh H8DhmQVNlSa2hv0cuS3MnGzFnreKJ2ZwA5CiNh4XWLer4uTlcfuTjzAbEIlnKvFmA8Hkod Z+QlkcNDlR3lnroI76hj/KF3jkXXzdk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-0g0StQsYM4iPl8H7uPnQjA-1; Tue, 20 Jun 2023 09:06:25 -0400 X-MC-Unique: 0g0StQsYM4iPl8H7uPnQjA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f9068f47ceso64521555e9.3 for ; Tue, 20 Jun 2023 06:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687266384; x=1689858384; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U7JUJ5E1Gfz+yHNjQaCbcifm4fSUv9XoyG0rXyO9Xo4=; b=QhIczbSeDJC6CUJ0MZa1c0XQjfc+qMZApuFEBtv/bvhEinRRiLidNOeY/HouGJ3bLA nIgE1KiZS2BU5cNkQgaKS1hcX2H+8j4kXe+BUu4+llJe3z14n9dAYs0xw4dor1Rcgyod GfZAH19TlkCvWhggkWiWsDItpIo0CxOrGknvuBI4z4dRwAAdzvWKJkKHyfljgyjd1PXI EQ9kNfBpAoA2UvGi6cndlujAQoxd5LumiZIkGnr0CHOIDhGmvZ4uuTLgZxCuRZEHMHOS VKiZtxx58YaVT/JLbF9qs1aGn/hRKEHJ6/yf2mf5M/g984+wCTCZUofbT3BdikcsYxwF waSg== X-Gm-Message-State: AC+VfDxaaSqxTIaV4NcsH3DFqcOFDv0kYkJabiPIcbGL9/DLVPYkFqJD g2vSsJz8lwgu20HN9EJldYROry85XtoSAxWEk0QHl1SDwm2OnV2bd++Vr2IVMFwY/z4N1a44I8J 8yaQ= X-Received: by 2002:a05:600c:22c6:b0:3f9:b244:c294 with SMTP id 6-20020a05600c22c600b003f9b244c294mr4844221wmg.35.1687266384304; Tue, 20 Jun 2023 06:06:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EEALOsLDLR+VhM7JYmBG+5y6qBkwfcUB0QgSwEj8gvZoR2f11IvHxTRkjuGywt2cvPoBxUg== X-Received: by 2002:a05:600c:22c6:b0:3f9:b244:c294 with SMTP id 6-20020a05600c22c600b003f9b244c294mr4844206wmg.35.1687266384022; Tue, 20 Jun 2023 06:06:24 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id u9-20020a05600c00c900b003f9b0cfbe34sm5785927wmm.33.2023.06.20.06.06.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jun 2023 06:06:23 -0700 (PDT) Message-ID: <97597f47-bbd9-a597-f1a0-50e076fbc370@redhat.com> Date: Tue, 20 Jun 2023 14:06:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 To: David Marchand Cc: Jerin Jacob , Luca Boccassi , "Xueming(Steven) Li" , dev@dpdk.org References: <20230619204650.3348681-1-david.marchand@redhat.com> <131df642-00ea-8317-bd09-9cc347a0d194@redhat.com> From: Kevin Traynor Subject: Re: [PATCH 1/2] test: add graph tests In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 20/06/2023 12:52, David Marchand wrote: > On Tue, Jun 20, 2023 at 12:32 PM Kevin Traynor wrote: >> >> On 20/06/2023 07:56, David Marchand wrote: >>> On Tue, Jun 20, 2023 at 8:50 AM Jerin Jacob wrote: >>>> >>>> On Tue, Jun 20, 2023 at 2:17 AM David Marchand >>>> wrote: >>>>> >>>>> We forgot to add graph unit tests to the CI testsuites. >>>>> >>>>> Signed-off-by: David Marchand >>>> >>>> Could we add Fixes: ? >>>> Either way, >>>> Acked-by: Jerin Jacob >>> >>> Indeed. >>> I don't think the graph unit tests and code changed much, so it should >>> be ok to backport down to 20.11 and enable these ut in the CI. >>> >>> >> >> Sounds ok to me to add "Fixes:" tag and backport. If they pass, great - >> if they don't, the graph maintainers would need to spend time updating >> the tests etc or we could just drop the patch. > > Modulo some easy to fix conflict when backporting, the graph tests pass fine: > - 20.11: > 2023-06-20T11:30:44.7171265Z 87/96 DPDK:fast-tests / graph_autotest > OK 0.13 s > 2023-06-20T11:30:44.7171724Z 88/96 DPDK:fast-tests / node_list_dump > OK 0.13 s > > - 21.11: > 2023-06-20T11:32:37.2132951Z 90/101 DPDK:fast-tests / graph_autotest > OK 0.17 s > 2023-06-20T11:32:37.2133397Z 91/101 DPDK:fast-tests / node_list_dump > OK 0.17 s > > - 22.11: > 2023-06-20T11:50:48.2519983Z 92/106 DPDK:fast-tests / graph_autotest > OK 0.17 s > 2023-06-20T11:50:48.2520344Z 93/106 DPDK:fast-tests / node_list_dump > OK 0.17 s > > Thanks David. In that case lgtm.