From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D5C8141C15;
	Mon,  6 Feb 2023 13:08:46 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6777640FAE;
	Mon,  6 Feb 2023 13:08:46 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id AB6FF40E25
 for <dev@dpdk.org>; Mon,  6 Feb 2023 13:08:44 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4P9Q3n6RQJzJsHV;
 Mon,  6 Feb 2023 20:07:01 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.34; Mon, 6 Feb 2023 20:08:41 +0800
Subject: Re: [PATCH v8 1/5] eal: add lcore info in telemetry
To: Robin Jarry <rjarry@redhat.com>, <dev@dpdk.org>
CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, Kevin Laatz
 <kevin.laatz@intel.com>
References: <20221123102612.1688865-1-rjarry@redhat.com>
 <20230202134329.539625-1-rjarry@redhat.com>
 <20230202134329.539625-2-rjarry@redhat.com>
 <72396994-5403-99f9-20a8-9c785dfb2b89@huawei.com>
 <CQBC232ECKAO.3KAGAZLN8GH59@ringo>
 <a359d084-7bb6-88a3-b727-5f439120c344@huawei.com>
 <CQBGE6PVPAD2.2E5D9E869WWJU@ringo>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <975da32d-2a02-9102-015b-373487df7e90@huawei.com>
Date: Mon, 6 Feb 2023 20:08:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CQBGE6PVPAD2.2E5D9E869WWJU@ringo>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/2/6 19:46, Robin Jarry wrote:
> fengchengwen, Feb 06, 2023 at 12:22:
>> Just invoke callback on one specific lcore.
>>
>> In this patch, the lcore_telemetry_info_cb() only valid on specific lcore, but it was implements by rte_lcore_iterate which will iterate all lcores.
> 
> Ok I see. I don't think this would be worth the effort. There will never be more than a few hundred cores. The performance gain would be negligible. What do you think?

Okay for not add.

And for this patch,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

> 
> 
> .