Re: [PATCH v1] usertools/telemetry: fix unused parameter

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 5/18/2023 2:47 PM, Samina Arshad wrote:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
> 
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> ---
>   usertools/dpdk-telemetry-client.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..3441b6b02e 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,7 +55,7 @@ def getFilepath(self, file_path):
>           # Gets arguments from Command-Line and assigns to instance of client
>           self.file_path = file_path
>   
> -    def setRunpath(self, file_path):
> +    def setRunpath(self, file_prefix):
>           self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
>                                        RUNTIME_SOCKET_NAME)
>   

Does this fix anything? The path is generated from args.file_prefix 
anyway, so this change will have no effect, I think?

-- 
Thanks,
Anatoly