From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D222E2BD5 for ; Thu, 7 Mar 2019 04:27:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 19:27:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,450,1544515200"; d="scan'208";a="305072868" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by orsmga005.jf.intel.com with ESMTP; 06 Mar 2019 19:27:00 -0800 To: Thomas Monjalon Cc: "dev@dpdk.org" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" References: <20190306041634.12976-1-anand.rawat@intel.com> <20190306041634.12976-3-anand.rawat@intel.com> <2585800.7Z22QRaGj1@xps> From: Anand Rawat Message-ID: <97a6242f-6d56-0c12-aba0-5e1f4c609a49@intel.com> Date: Wed, 6 Mar 2019 19:27:00 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <2585800.7Z22QRaGj1@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 03:27:02 -0000 On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > 06/03/2019 05:16, Anand Rawat: >> Added header files to support windows on x86 platforms. >> Updated rte_config to include rte_windows.h for windows >> build. > [...] >> --- a/config/rte_config.h >> +++ b/config/rte_config.h >> +/* windows specific*/ >> +#ifdef RTE_EXEC_ENV_WINDOWS >> +#include >> +#endif > > Include in the config file looks wrong. > >> --- /dev/null >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > I think we could remove the sub-directory exec-env. > Could we include this file from rte_common.h? rte_windows.h defines types and substitution macros which are needed to support common code on windows. So it should be included as a global include for every library on windows. rte_common.h is not included in all the source code and headers we currently build for windows. > >> @@ -0,0 +1,23 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2019 Intel Corporation >> + */ >> + >> +#ifndef _RTE_WINDOWS_H_ >> +#define _RTE_WINDOWS_H_ >> + >> +#ifdef __cplusplus >> +extern "C" { >> +#endif >> + >> +#define __extension__ >> +#define __thread __declspec(thread) >> + >> +#define strerror_r(a, b, c) strerror_s(b, c, a) >> + >> +typedef void *ssize_t; >> + >> +#ifdef __cplusplus >> +} >> +#endif >> + >> +#endif /* _RTE_WINDOWS_H_ */ > > It is missing comments to explain the need of each line. > > Will be done in v3 -- Anand Rawat