From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Santosh.Shukla@cavium.com>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
(mail-by2nam03on0084.outbound.protection.outlook.com [104.47.42.84])
by dpdk.org (Postfix) with ESMTP id 0D18C7CE7
for <dev@dpdk.org>; Thu, 5 Oct 2017 11:22:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=YCnhq0Q/AWEAiFlubyLs4Wtr9XrjqWkptCWg0sxqT0k=;
b=hp1tC6h0/ahOqmmz8rRAlOGr5atsTtu7empFl8HGnmi+wTEbgsf6iGU6i5JoIVQzxujBV7tHwK9Vb2iDSwAFCZiwIj6ItPV4C4FPND0SMCesQZSU1tYwzS/rETEV2b9PXsGeZWcz7YiyK2qFlzAT5hXVBIYFeEkYFNqES+ujE40=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=Santosh.Shukla@cavium.com;
Received: from [IPv6:2401:4900:1984:75ec:516e:bc2f:cd22:9551]
(2401:4900:1984:75ec:516e:bc2f:cd22:9551) by
MWHPR07MB3104.namprd07.prod.outlook.com (10.172.95.10) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
15.20.77.7; Thu, 5 Oct 2017 09:22:02 +0000
To: "Hunt, David" <david.hunt@intel.com>, dev@dpdk.org
References: <1506342429-199695-1-git-send-email-david.hunt@intel.com>
<1507108515-186477-1-git-send-email-david.hunt@intel.com>
<1507108515-186477-3-git-send-email-david.hunt@intel.com>
<eb73493c-52c1-1637-8088-d7bc96f1432b@caviumnetworks.com>
<cf0cc715-c4ef-7bec-c16f-c4b160d1ed50@intel.com>
Cc: konstantin.ananyev@intel.com, jingjing.wu@intel.com,
Nemanja Marjanovic <nemanja.marjanovic@intel.com>,
Rory Sexton <rory.sexton@intel.com>
From: santosh <santosh.shukla@caviumnetworks.com>
Message-ID: <97a6d374-87b5-484e-bd34-7060e5276ae1@caviumnetworks.com>
Date: Thu, 5 Oct 2017 14:51:47 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <cf0cc715-c4ef-7bec-c16f-c4b160d1ed50@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Originating-IP: [2401:4900:1984:75ec:516e:bc2f:cd22:9551]
X-ClientProxiedBy: MA1PR0101CA0024.INDPRD01.PROD.OUTLOOK.COM (52.134.136.162)
To MWHPR07MB3104.namprd07.prod.outlook.com (10.172.95.10)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d9e81d3c-8505-4fe3-a25d-08d50bd28b54
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);
SRVR:MWHPR07MB3104;
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3104;
3:gUXO8/X9tC+sebd4TagpuEZd2+9lg8AY3Moe7XkpMr2LiBcS9cWhk/th6qpLGVZWdSkx3RUFfgqvzztgeykVFuvj0aDOaICzpJ+zYmYGDHNuNsgeD2xlwzmHgGl8qVDZ3emXJQrq6/YpueQ9apqu53zyRcEmHbrrIPmdlh2pVF3Jr/CtGyq3MbqSVYeGMrEve3luJMEM4Y08O7pJsqptIRANw4+1Ub4ImbryemK06CF/bQJwn2/alNUWsRm85yPx;
25:7o86lLjbqyHt/EN3Hov2GGdQhlvdlG/Zc/CM3xrnpAYEGw89hqYlU6eUj0bg+e2LpkeYBtaBfOK/VQORtwboxnmuRlC6JJEhbFoUfpQfu7y489MOYBKiaEXkcncCjsuEZX00A4d12v0ljc9FD89SqnW1QfQKZfauB+J1xFdkIX2BHoIrlB88UcX13QqHCRN0Y60be7+9R9fb/VrHOCgmsSsbf1JfiMrzkpxvwUaczjFV34FZDmqL09wgSbIpwN6NgzhvYi4VQ355D5pD6zOsYtA2P/Uj0z4U4nX4PsZ4TRyuzFAvp0Z+Cg1FJP7du/mfVxCuROh3F/BGqWteRpQYdg==;
31:aUBLmszWvvZ1L0DWUbqBQIBHQZX0+VBp8ElbiK9juFbUxP8DFjIqQriqQa9JFsbLyZ/IXUEJpjxUPxM7HMlTbzqY4cao2QNEohMk88gOBCBzdjSrRSmTb0h1CyQMqaYRokX6/EcA0fTJnIENxipFCqfks0DiYFnmoGV6LsOLD6opo0dxEbElfp112PamNtc8psOJGBKQp6d29yCLkhnyGojpmP29VT7nPcT0IJKWF8I=
X-MS-TrafficTypeDiagnostic: MWHPR07MB3104:
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3104;
20:+EPrPUEJhfbZ48Ml0w0I5KSmHnpCOp4V8c3qbaXTS8OU2rYDOEY2YaesY8AnnPUieniIh4IUQIAjNcK+VJPRfe0+UDXyn41bUSCeyMVpP9M7DR6XzDqoEI4y9SG/FtKz6ghr3C0XGoRHxpVZXzYye5RrnTbjHBQuPdSMiiKWsWNREHa4/PWA/e5DoGersoQX+tTcxWNLGUclN/6Ter5ts3CdzNw4hdDPgbOqdoIjFIQFXbc5Szt4/gqhOz1jld9j6kFOXbxXs45U+4989+HHninCjOA48SvsSqZtRrPeGXIbrKn+U/nigfTIXh/j+S3fA9jPR4V9jnLuuRIOhEqilnmI/ToiVJzRiLn2y1W3V32407f442Umu1NK0cIpzjQmGA9GylJGySimD7CV1L+flvdK07fGnocuu2lcm8qYrkvMo4k0KTeL8Q6HEyWoVv06m+ncPFQqC5t1+R0K1GCI7xGZWB+gnYEFCkiZrQOjJYfk5UB9sjWf+ERvUa0mwMuV/fxhPclD/ki9D3iMnDefJ7ZwLqNzSe6ok0DaLwwuij9oz9btrJ3AaI9RkJRWpOtS0GBLJ4LaopMk15EU3At43UTplR8oXQ2JGK8sM70cpgA=;
4:ywfZlaIDrnPutScZawxYihliqk8meJT/OzDLOBSXxUzSfOMp2M/lkexURrNI/anq93qfDw5VLO2iGTqVHfBA9+Bnjjz9aT0tZl1P2ZriOMORUaAT1rmogEZ1Dd8RVW1xOxK5s7+GD+CCp27BuS8NCL3uuEv4yNwTtgSXO/MYwJ9r42O0dD+Yr6LDxMxoGCRayP/CykaewcMHYi+0E+GEiJ1wtk0WYb2/91nMDKQtSTKL3pMl39Je4h9MCuZRqppQKX+sT6jVjP0Yhs5YgweEm50IpcISf+GkLSm5nXOxxQs=
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-Microsoft-Antispam-PRVS: <MWHPR07MB3104A052E0DD1A2FAA2B19D5EA700@MWHPR07MB3104.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);
SRVR:MWHPR07MB3104; BCL:0; PCL:0;
RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
SRVR:MWHPR07MB3104;
X-Forefront-PRVS: 04519BA941
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6059001)(6009001)(346002)(376002)(51444003)(24454002)(377454003)(189002)(199003)(81156014)(93886005)(33646002)(8676002)(83506001)(81166006)(305945005)(64126003)(4326008)(7736002)(50466002)(6486002)(65826007)(1706002)(76176999)(72206003)(478600001)(47776003)(6666003)(25786009)(8936002)(50986999)(5660300001)(65956001)(54356999)(65806001)(230700001)(316002)(105586002)(229853002)(2906002)(54906003)(2950100002)(53936002)(42882006)(53546010)(6246003)(97736004)(106356001)(86152003)(31696002)(6116002)(189998001)(23746002)(31686004)(58126008)(36756003)(101416001)(68736007);
DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3104;
H:[IPv6:2401:4900:1984:75ec:516e:bc2f:cd22:9551]; FPR:; SPF:None;
PTR:InfoNoRecords; MX:1; A:1; LANG:en;
Received-SPF: None (protection.outlook.com: cavium.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR07MB3104;
23:wByvhkKxeBE+cGSD3uIbBz92uZQafCj5DgHHb?=
=?Windows-1252?Q?E/1ANikqjztzfz4xyQ4ML6yQzDdwDPP9VL8WXBOyjvF/MpdhyIsWxSzG?=
=?Windows-1252?Q?F4jvADvdGEEeyKZMIWLDhTKz9s1OrkwLjnSKnEB9A/TgNIxM+2C+vpjY?=
=?Windows-1252?Q?AwbVH3++hOWa5J5j8yBQBvmsSyu1RELBpuq0fLv9pH6/c6YNg2OXhNAq?=
=?Windows-1252?Q?PzFOCPE7k0LjA7fxWb8qcBtvUoV8+Lf5w9L0w8HRbizawpQ9EdcUQicl?=
=?Windows-1252?Q?TiF7xSSyaLcb4Nq3DFY1dvNrKx0oQnS5VJl+NnJtJXDV1yOLXxW7PLf/?=
=?Windows-1252?Q?4npPLvJGuZ0WLjZt3iXL9MZblTzheVFiYcOEvIlFCZU0Vh7qzspM8sdm?=
=?Windows-1252?Q?Gl0kq4J0YnpZDFq6/nRFs6wX1vCk4IjFzUNX2RilmuJWD9h480vtFxpo?=
=?Windows-1252?Q?4+N6i9wz1Nrm9nskx3pNG7kuWrNssPLTA2Mm3OBRlaYtLkK0pANi44L3?=
=?Windows-1252?Q?F9SJsIEAE5FCnCIPV+QweBym7KzGzTEKewjxqwS0amicwbnpjAuWxap7?=
=?Windows-1252?Q?EKarpPcFM+xNAUtYqudH84clcqY2gnJcY3v6Lo+f8USHhCTKZwwBWmox?=
=?Windows-1252?Q?GaRGSndoYRlWHQ9/oq438vZWKGxP8GmJNXKlBRAXiql+atQhEGgqFeU+?=
=?Windows-1252?Q?N3Obw3kPILOkU7g4/I6JjtWx/szMN+khfbL6KkD3iei5SNHte2COYdRF?=
=?Windows-1252?Q?l61BTqZL252euzPwshn2sOPhTPnRkm3koK9OP3L+21arwrGk6R48sZSa?=
=?Windows-1252?Q?8ZPl1QIexOW7xjlNY0Fs4YttYxJaOBr2+HVQUtKYLJvq3CjTNjcpF2iW?=
=?Windows-1252?Q?A2JvalPq25Cdm4DkX+1lGPFjvP0GILhcrqE+7wPsYlnzH0Ka2/Ld8+ev?=
=?Windows-1252?Q?ccIhT+txU6EZUhlKFIHr1QNZ6/rtatjsmJ5d+NOaiB+2PmzD6Gin+Xw3?=
=?Windows-1252?Q?CT0EmnORI2LMWMOSmOQiJ6jlTz7MheFmUsNwsEC4sozdeEHeuj6PF7ic?=
=?Windows-1252?Q?8cAu2PI7HtV/m3G2n6AYO4x5/UlPlHO2MvYHsxCKg/AL/rIVyF2KT3GV?=
=?Windows-1252?Q?NltnHQJbdyW40i5DFpMloZRWmTiCWyQjiJITZMfNvu2dfA+gcu2dC2Oa?=
=?Windows-1252?Q?TyhLuoiyRXtCGwXohYJZXlvd2HiAJQ20M+vQHek9cG/XaJxzhe3EyHLb?=
=?Windows-1252?Q?0rtC5wIzaCpdf+TzV7BNqaKTdwxg0UWL6IxgxwgMQ1hBCAtmDTQ4TnCd?=
=?Windows-1252?Q?St+XVTxegA2Z4Yj3BpozcwTu7S8DUlyMn+3oj/32/BERPIfUQrwuYIeB?=
=?Windows-1252?Q?n49rZBDbETltgCbxKHuLupyEhbaUj0ouUQr2aZt70aNnLV1TU6QYJ3j7?=
=?Windows-1252?Q?2i6ginpvBrCSNI8diz9?=
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3104;
6:dTCC8RueMXtl1OR69AlsAPc2vby7gG38b5HHhLVk5EDNPw+oQyJiJgnufe5crF6DjspTGXm921Uhz0Ni76tjTjLkxF07CG+Yio4Uli24AeyM6ZYQo79mHpMhfsPAA/Rq/ArdYcXMhCDMyZ7DngB4gjEw0s2ZK7mTOdFEPuTkWnc8iFep14fh1CFqniUlYpF7WB3ksi3jSQ7iCIWXr3vYfV3M2FHC14Bq/szdgGtKbgr2eJJX34sZb87n8ZkqiLmcyugc1WVLJqKH7kDOV2yj1ZzK34MDjg7djRd8HErMZJzLhOgswK1Nuk8Zd4vTcfDxAIC8WfrhgydwYwftn5C6hg==;
5:IQaR/WYpInzsjiw0z4as8Q0/4VPrMkozuzuB4UVAi4YZ+NF3M46JmcNNUlvLkqZeowYh7jKMoqoVVTd7ehSN5RjpAxU0uBx5/Su5OmO8cZCulk7xuV9aac581OoNePbyK1HBX7xh0GYaTum03ctkYQ==;
24:tncbGSfmpxxfah+1n3oTkYP8FQ61ritTBmhShvc3queIwW3YwB6i2WJjKfWfUse0rRuA0ZAvmCGTyimBReFeVgviYyfyFpIvTDuCQQq4kLk=;
7:tkp4/s5KEuYcKlXranMP/iR/zOy9VbrLm4sLBZXRIsQsrt6GqmIMZJkNn76IIuHl1wEaWbthlnu8EPuWAD6PtiBrxyxPmnE0xg2Ym5sGUq67ViVM60Q5aGxI/RxGV9Xv3FOv6WTIK9a7NNPlzUJt3t6zTLuG/O5TEGq2hdVSKh3v2zvDFvv2MhzqLqGyXVIDEaXVYkYVSCtunA8nUzpcP7rG79b7vKxllw3+iu6QuHE=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 09:22:02.8753 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3104
Subject: Re: [dpdk-dev] [PATCH v4 2/9] lib/librte_power: add extra msg type
for policies
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Oct 2017 09:22:07 -0000
Hi David,
On Thursday 05 October 2017 02:08 PM, Hunt, David wrote:
>
> Hi Santosh,
>
> On 4/10/2017 4:36 PM, santosh wrote:
>> Hi David,
>>
>>
>> On Wednesday 04 October 2017 02:45 PM, David Hunt wrote:
>>> Signed-off-by: Nemanja Marjanovic <nemanja.marjanovic@intel.com>
>>> Signed-off-by: Rory Sexton <rory.sexton@intel.com>
>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>> ---
>> my 2cent:
>> General comment on implementation approach:
>> IMO, we should avoid PMD details in common lib area.
>> example: file channel_commons.h has ifdef clutter referencing
>> i40e pmds all over.
>>
>> Perhaps we should introduce opaque handle example void * or introduce pmd
>> specific callback/handle which points to PMD specific metadata in power library.
>>
>> Example:
>> struct channel_packet {
>> void *pmd_specific_metadata;
>> }
>>
>> Or someway via callback (I'm not sure at the moment)
>> so that we could hide PMD details in common area.
>>
>> Thanks.
>
> I would agree that PMD specific details are good left to the PMDs, however I think that the initial
> example should be OK as is, and as new PMDs are added, we can find commonality between them
> which stays in the example, and any really specific stuff can be pushed back behind an opaque.
>
> What about the v5 I submitted (without the #ifdef's)? Are you OK with that for this release, and we can
> fine tune as other PMDS are added in future releases?
>
Yes. But in future releases, we should do more code clean up in power lib and example area..
meaning; current example implementation uses names like _vsi.. specific to intel NICs,
we should remove such naming and their dependency code from example area.
Thanks.
> Regards,
> Dave.
>
>