From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8241F44018; Mon, 13 May 2024 10:23:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3370402CD; Mon, 13 May 2024 10:23:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 016804028A for ; Mon, 13 May 2024 10:23:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715588595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rJQ0uw3bap8i+3TX7I1yQUSRCvV9tAxAgRAIFp+m88Q=; b=BJWFlYtfPfstujH7cAzKMzbYCYp17migHtllJSAa6CODqspneZeogDg05UiLKHpP5UUfSY JaWaoCDdZajEMBAFeW66EmFK7KwBMwU+ey2loyDe91nIw3eFAPYQLCUi7B9MIUY9/D34YU Ba9RdzmIK+DJape8hHoDro3VCHH1+0o= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-0q38zWfyMV2CqyAp0cpI_w-1; Mon, 13 May 2024 04:23:12 -0400 X-MC-Unique: 0q38zWfyMV2CqyAp0cpI_w-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6a1530209deso102565866d6.1 for ; Mon, 13 May 2024 01:23:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715588591; x=1716193391; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rJQ0uw3bap8i+3TX7I1yQUSRCvV9tAxAgRAIFp+m88Q=; b=YhExDBBVTXUge79RSUbh8AHhCZbVT/5Wc5L3Fal+i4WJB6C+mxkAyXMW1fu75rBxnY 2u4WQxqZnI3L9l7aRxrWACQVPpG7Ka4b2eAzs5X428bMX97gAxo+teCVJjABNvGoKjMy OMYib+P0HuuG4ycNQqVtRklWE+6kkXvNlsVV3ELjt2l+gkWOhVmpr2OHWlOwogdst4P/ nzaDQ6FC8zJw+DrzL+jcSsCe0LlYPOmy+ljnz8Oj/VS8vGGx4HCEgaYUYd1X7DSvr75l i03uiuI1gjic63OGjrKsbulsbFwUQgD3V2qQKhJ0qk0KbwmEKHdyqOQ3tmA4tkH6ghre SoEg== X-Gm-Message-State: AOJu0YxcoKLpLrDRUtMUxfar9jrYk1bePmR0H7xgW6wbZDONUfaHldYG zIbeH68AGXghq0//3Dd+Vr5SUBWuc7CKVqFOfNjin2kDmyE3XIh8tIceK80PcmWBEs2IR3QQgiN 0Fje4HTmIRjjsWEKVgBsShKzu5leOOj8gz0Ib82CmxNCNkHQlnAKKI2XrvKYJHCCNEcTQS5IdO1 /6BSBbspLEs29XV15WiJ9NJPg= X-Received: by 2002:a05:6214:3a88:b0:6a0:a8f2:5f8e with SMTP id 6a1803df08f44-6a167904557mr160101276d6.1.1715588591341; Mon, 13 May 2024 01:23:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXZJhfTDa33hrh3/CN8EWHdY0fdT+GrheD5BHPZFQzgR8FMSCuJ9LwTbYbllyhDREtcix3RA== X-Received: by 2002:a05:6214:3a88:b0:6a0:a8f2:5f8e with SMTP id 6a1803df08f44-6a167904557mr160101096d6.1.1715588590685; Mon, 13 May 2024 01:23:10 -0700 (PDT) Received: from [192.168.0.12] ([78.18.17.228]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f09847csm41554496d6.0.2024.05.13.01.23.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 May 2024 01:23:10 -0700 (PDT) Message-ID: <97be801a-bc5c-47bd-bb1f-23cca7f1fbcf@redhat.com> Date: Mon, 13 May 2024 09:23:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic To: dev@dpdk.org References: <20240510100358.18815-1-ciara.loftus@intel.com> <20240510100358.18815-2-ciara.loftus@intel.com> <20240510080612.7b420011@hermes.local> From: Maryam Tahhan In-Reply-To: <20240510080612.7b420011@hermes.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------kmE5vUCXTE0HPjONybFXPufH" Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------kmE5vUCXTE0HPjONybFXPufH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/05/2024 16:06, Stephen Hemminger wrote: > You don't have to use local statistic for this, there already is one in the dev struct > i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find > what dev is. I think the diff id that dev->data->rx_mbuf_alloc_failed would reflect the pure HW(NIC) failed allocations where as the local alloc_failed would reflect the failed allocations on the xdp side. Both should be accounted for. --------------kmE5vUCXTE0HPjONybFXPufH Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 10/05/2024 16:06, Stephen Hemminger wrote:
You don't have to use local statistic for this, there already is one in the dev struct
i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find
what dev is.

I think the diff id that dev->data->rx_mbuf_alloc_failed would reflect the pure HW(NIC) failed allocations where as the local alloc_failed would reflect the failed allocations on the xdp side. Both should be accounted for.

--------------kmE5vUCXTE0HPjONybFXPufH--