From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [RFC 2/4] hash: add dynamic polynomial calculation
Date: Thu, 10 Oct 2024 13:32:29 +0100 [thread overview]
Message-ID: <97cd875a-1f2b-4ac2-ace1-34d944fbf102@intel.com> (raw)
In-Reply-To: <20240908171124.07ec714f@hermes.local>
Hi Stephen,
Thanks for the review.
No particular reason, will change it to uint32_t in v2.
On 09/09/2024 01:11, Stephen Hemminger wrote:
> On Fri, 6 Sep 2024 16:53:16 +0000
> Vladimir Medvedkin <vladimir.medvedkin@intel.com> wrote:
>
>> +struct divisors {
>> + int n; /* number of divisors */
>> + int div_arr[MAX_DIVISORS];
>> +};
> Why int instead of a fixed size unsigned, like uint32_t?
--
Regards,
Vladimir
next prev parent reply other threads:[~2024-10-10 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 16:53 [RFC 0/4] RSS hash key generation Vladimir Medvedkin
2024-09-06 16:53 ` [RFC 1/4] thash: add RSS hash key generation API Vladimir Medvedkin
2024-09-09 0:09 ` Stephen Hemminger
2024-09-06 16:53 ` [RFC 2/4] hash: add dynamic polynomial calculation Vladimir Medvedkin
2024-09-09 0:11 ` Stephen Hemminger
2024-10-10 12:32 ` Medvedkin, Vladimir [this message]
2024-09-06 16:53 ` [RFC 3/4] hash: implement RSS hash key generation API Vladimir Medvedkin
2024-09-06 16:53 ` [RFC 4/4] test/thash: add tests for RSS " Vladimir Medvedkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97cd875a-1f2b-4ac2-ace1-34d944fbf102@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).