From: oulijun <oulijun@huawei.com>
To: Wisam Monther <wisamm@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: Linuxarm <linuxarm@huawei.com>
Subject: [dpdk-dev] 答复: [PATCH] app/testpmd: update uninitialized member when set fwd mode
Date: Wed, 1 Jul 2020 07:12:25 +0000 [thread overview]
Message-ID: <97d41bfcdb5c45398bd8789855c49e13@huawei.com> (raw)
In-Reply-To: <AM0PR05MB6610011DA1DB6674C2A883B8A96F0@AM0PR05MB6610.eurprd05.prod.outlook.com>
Thanks. I will send the V2.
-----邮件原件-----
发件人: Wisam Monther [mailto:wisamm@mellanox.com]
发送时间: 2020年6月30日 22:10
收件人: oulijun <oulijun@huawei.com>; dev@dpdk.org; ferruh.yigit@intel.com
抄送: Linuxarm <linuxarm@huawei.com>
主题: RE: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member when set fwd mode
Hi Lijun,
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou
>Sent: Tuesday, June 30, 2020 4:25 PM
>To: dev@dpdk.org; ferruh.yigit@intel.com
>Cc: linuxarm@huawei.com
>Subject: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member
>when set fwd mode
The member is actually initialized before so I think the title somehow misleading, What about: "fix missing set for current forward engine"
>
>When set the forwarding mode of the pkt, it needs to update the fwd_eng
>that it is the member of cur_fwd_config. Otherwise, an error will occur
>when executing the set command and show confg fwd.
>the flows as follows:
> 1. ./tespmd -w xxx -l xx -n 4 -- i
> 2. set fwd mac
> testpmd> set fwd mac
> Set mac packet forwarding mode
>
> 3. show config fwd
> testpmd> show config fwd
> io packet forwarding - ports=1 - cores=1 - streams=8 -...
> Logical Core 1 (socket 0) forwards packets on 8 streams:
>
>When run the 1 ~ 3 step, it should show the packet forwarding is mac.
I think this should be consider as a fix, and you need to add the fixed commit and cc It's auther
>
>Signed-off-by: Lijun Ou <oulijun@huawei.com>
>---
> app/test-pmd/config.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>a7112c9..ee0e904 100644
>--- a/app/test-pmd/config.c
>+++ b/app/test-pmd/config.c
>@@ -3158,6 +3158,7 @@ set_pkt_forwarding_mode(const char
>*fwd_mode_name)
> fwd_mode_name,
> retry_enabled == 0 ? "" : " with retry");
> cur_fwd_eng = fwd_eng;
>+ cur_fwd_config.fwd_eng = fwd_eng;
> return;
> }
> i++;
>--
>2.7.4
prev parent reply other threads:[~2020-07-01 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 13:25 [dpdk-dev] " Lijun Ou
2020-06-30 14:09 ` Wisam Monther
2020-07-01 7:12 ` oulijun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97d41bfcdb5c45398bd8789855c49e13@huawei.com \
--to=oulijun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@huawei.com \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).