From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2120143B67; Fri, 8 Mar 2024 14:19:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BC0943256; Fri, 8 Mar 2024 14:19:30 +0100 (CET) Received: from smtp-fw-9106.amazon.com (smtp-fw-9106.amazon.com [207.171.188.206]) by mails.dpdk.org (Postfix) with ESMTP id 2A01D406BC for ; Fri, 8 Mar 2024 14:19:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1709903969; x=1741439969; h=from:to:cc:date:message-id:references:in-reply-to: mime-version:subject; bh=+2csZlp2Au0cDgwi6gVtb9w5T5mdYLaEVcOhLoB1dyM=; b=sAgz8B5BwMFEyFIWgZmgiVyJutvk7NsqdT79N0oGiejeH+S/cKU79Nej +f6UYxLCztZoXxEN4MHyIlgwmGKqEeAvwCii5qOw8KnKGwrK3KaFTP4bx uKFnh8hrLcnsyOSPQn8o6aMf+Bv0PJniKS/h0XKksmMG3bSRS0fiNr7IE Q=; X-IronPort-AV: E=Sophos;i="6.07,109,1708387200"; d="scan'208,217";a="709649332" Subject: RE: [PATCH v3 26/33] net/ena: cosmetic changes Thread-Topic: [PATCH v3 26/33] net/ena: cosmetic changes Received: from pdx4-co-svc-p1-lb2-vlan2.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.210]) by smtp-border-fw-9106.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 13:19:20 +0000 Received: from EX19MTAEUC002.ant.amazon.com [10.0.43.254:20231] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.9.238:2525] with esmtp (Farcaster) id 7cc22d57-e836-4da7-adf0-8ee42023691f; Fri, 8 Mar 2024 13:19:19 +0000 (UTC) X-Farcaster-Flow-ID: 7cc22d57-e836-4da7-adf0-8ee42023691f Received: from EX19D007EUA003.ant.amazon.com (10.252.50.8) by EX19MTAEUC002.ant.amazon.com (10.252.51.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 8 Mar 2024 13:19:19 +0000 Received: from EX19D007EUA002.ant.amazon.com (10.252.50.68) by EX19D007EUA003.ant.amazon.com (10.252.50.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 8 Mar 2024 13:19:19 +0000 Received: from EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc]) by EX19D007EUA002.ant.amazon.com ([fe80::1295:20d9:141e:47cc%3]) with mapi id 15.02.1258.028; Fri, 8 Mar 2024 13:19:19 +0000 From: "Brandes, Shai" To: Ferruh Yigit CC: "dev@dpdk.org" Thread-Index: AQHab8FoMeIkqraQR0WOc3ReG0liM7EttQiAgAAh6HQ= Date: Fri, 8 Mar 2024 13:19:18 +0000 Message-ID: <981e2919-f14c-48ac-aa78-df2302ece11e@email.android.com> References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-27-shaibran@amazon.com>, <5cde2436-7105-40fa-b322-92411bf60066@amd.com> In-Reply-To: <5cde2436-7105-40fa-b322-92411bf60066@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_981e2919f14c48acaa78df2302ece11eemailandroidcom_" MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_981e2919f14c48acaa78df2302ece11eemailandroidcom_ Content-Type: text/plain; charset="windows-1255" Content-Transfer-Encoding: quoted-printable Thanks Ferruh, we will fix and upload a new patchset =E1=FA=E0=F8=E9=EA 8 =E1=EE=F8=F5 2024 13:18,=FE Ferruh Yigit =EB=FA=E1: CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you can confirm the sender and know the= content is safe. On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > This patch makes several changes to improve > the style and readability of the code. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > --- > drivers/net/ena/hal/ena_com.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.= c > index b98540ba63..2db21e7895 100644 > --- a/drivers/net/ena/hal/ena_com.c > +++ b/drivers/net/ena/hal/ena_com.c > @@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev = *ena_dev, u64 *timestamp) > > /* PHC is in active state, update statistics according to r= eq_id and error_flags */ > if ((READ_ONCE16(read_resp->req_id) !=3D phc->req_id) || > - (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) { > + (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) > /* Device didn't update req_id during blocking time= or timestamp is invalid, > * this indicates on a device error > */ > phc->stats.phc_err++; > - } else { > + else > /* Device updated req_id during blocking time with = valid timestamp */ > phc->stats.phc_exp++; > - } > } > > /* Setting relative timeouts */ > @@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *= ena_dev, void *data) > timestamp =3D (u64)aenq_common->timestamp_low | > ((u64)aenq_common->timestamp_high << 32); > > - ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestam= p: [%" ENA_PRIU64 "s]\n", > + ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestam= p: [%" ENA_PRIu64 "s]\n", > 'ENA_PRIu64' is not defined yet in this patch, so patch by patch build fails. --_000_981e2919f14c48acaa78df2302ece11eemailandroidcom_ Content-Type: text/html; charset="windows-1255" Content-Transfer-Encoding: quoted-printable
Thanks Ferruh, we will fix and upload a new patchset

=E1=FA=E0=F8=E9=EA 8 =E1=EE=F8=F5 2024 13:18,= =FE Ferruh Yigit <ferruh.yigit@amd.com> =EB=FA=E1:
CAUTION: This email originated from outside of the= organization. Do not click links or open attachments unless you can confir= m the sender and know the content is safe.



On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:
> From: Shai Brandes <shaibran@amazon.com>
>
> This patch makes several changes to improve
> the style and readability of the code.
>
> Signed-off-by: Shai Brandes <shaibran@amazon.com>
> Reviewed-by: Amit Bernstein <amitbern@amazon.com>
> ---
>  drivers/net/ena/hal/ena_com.c | 13 +++++----= ----
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_c= om.c
> index b98540ba63..2db21e7895 100644
> --- a/drivers/net/ena/hal/ena_com.c
> +++ b/drivers/net/ena/hal/ena_com.c
> @@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_c= om_dev *ena_dev, u64 *timestamp)
>
>            = ;   /* PHC is in active state, update statistics according to req= _id and error_flags */
>            = ;   if ((READ_ONCE16(read_resp->req_id) !=3D phc->req_id) |= |
> -           &nb= sp;     (read_resp->error_flags & ENA_PHC_ERROR_= FLAGS)) {
> +           = ;      (read_resp->error_flags & ENA_PHC_ER= ROR_FLAGS))
>            = ;           /* Device did= n't update req_id during blocking time or timestamp is invalid,
>            = ;            * this = indicates on a device error
>            = ;            */
>            = ;           phc->stats= .phc_err++;
> -           &nb= sp; } else {
> +           = ;  else
>            = ;           /* Device upd= ated req_id during blocking time with valid timestamp */
>            = ;           phc->stats= .phc_exp++;
> -           &nb= sp; }
>       }
>
>       /* Setting relative timeouts */ > @@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_co= m_dev *ena_dev, void *data)
>            = ;   timestamp =3D (u64)aenq_common->timestamp_low |
>            = ;           ((u64)aenq_co= mmon->timestamp_high << 32);
>
> -           &nb= sp; ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%&q= uot; ENA_PRIU64 "s]\n",
> +           = ;  ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: = [%" ENA_PRIu64 "s]\n",
>

'ENA_PRIu64' is not defined yet in this patch, so patch by patch build
fails.

 --_000_981e2919f14c48acaa78df2302ece11eemailandroidcom_--