From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49B33A00C2; Tue, 23 Aug 2022 20:08:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74B62427F4; Tue, 23 Aug 2022 20:08:38 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) by mails.dpdk.org (Postfix) with ESMTP id 96B7B427F2 for ; Tue, 23 Aug 2022 20:08:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrkzKBiWtyWqLJ9fSIPOgbw+L0suZnartOwDUfBxpzoh3hPY7rJB3yOYZPPCD/vjcsYL32/1O4mN8kLILb9YQLezwcV6XPrf15rEuirDwSC/DcJbvJpUgWVWXPrqLjPxRws/FsBiiUMMJBWvwUdGY36ZPu0pTDZsM95OQHTsd5wEMc2RdyO3DxnKN4xKRUup1CYahUtNbJv98TEgvMhsqzPJtMilUglasQ6WlUNBxiYWQOSxGCICiSWsHiOEziKZmCifMgAk7O2kF5L450kuvO81dDffkhe/uiSWKyOIr6kjAXW+csSzQ3zAppToTyKc2kfXvG2MV50EnDmUkiNIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=on7Xoz0kxbGfw+CLWKXWrVpHL1Pr0E6dl1ykUge8Z7I=; b=cNvhBwsfSTHXgKrfzP6idT4NN9zfwWSAefPxmINg3r8ayVkXyXVrIJ8EbrDxxle9lxrKc6bjcMIZTDjAs4OoLRDgfbmBq+FemrG1LE68vPuWV9R3PIOi2Q7KlEEBKpGomx44vhiQuHebfz+IK+lTKBo3K19oYg9DpddbZ3b3/wVAZ4nszExkmzaagfUKBoqGs0KbByPw93EVdc3RDfKiEdB2lL+u9ldamzcX4zHZf4u5e/3UpFtBwG2s9GttdowlD4k/26iRqF+8+lPEDu220VJFEqBdjKoYr+2lpor4pUcWAeMgG2XGEjMligCvE74RtfSF6aGc8zzNCKwgQe6Gyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=on7Xoz0kxbGfw+CLWKXWrVpHL1Pr0E6dl1ykUge8Z7I=; b=odxxlU1/qUVCLqzVI7QpNbVzBBR9jm4KhauWERSNk3mlnKoRJv2sUNZpyT3k5cZgs9qnP39mbT+VBh8plOb4TsOva1sGDptcCUTDncw9LCu476QOemVeo2bnFBy8ChobFpTHoNsRPnDJ8pLmMMFJfowuxwC369TU5puHNJjsNMY= Received: from SA9PR13CA0137.namprd13.prod.outlook.com (2603:10b6:806:27::22) by SN1PR02MB3855.namprd02.prod.outlook.com (2603:10b6:802:31::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 23 Aug 2022 18:08:35 +0000 Received: from SN1NAM02FT0059.eop-nam02.prod.protection.outlook.com (2603:10b6:806:27:cafe::21) by SA9PR13CA0137.outlook.office365.com (2603:10b6:806:27::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14 via Frontend Transport; Tue, 23 Aug 2022 18:08:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0059.mail.protection.outlook.com (10.97.5.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Tue, 23 Aug 2022 18:08:34 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 23 Aug 2022 19:08:33 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 23 Aug 2022 19:08:33 +0100 Envelope-to: david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net, dev@dpdk.org Received: from [10.71.194.74] (port=49447) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oQYKH-0007H1-FZ; Tue, 23 Aug 2022 19:08:33 +0100 Message-ID: <982092f2-f7ef-f2c1-1307-6fdc27734577@xilinx.com> Date: Tue, 23 Aug 2022 19:08:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 00/10] ethdev: cleanup deprecated defines Content-Language: en-US To: David Marchand , Andrew Rybchenko CC: Thomas Monjalon , dev References: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa900460-6160-45d0-0d8b-08da85327ece X-MS-TrafficTypeDiagnostic: SN1PR02MB3855:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6LpiiHfuzAtcMwC9K53MCUoiTU9ayy00GpMIepmUZQ+6u3FdPkBIjIEDGUz0JKv4VZi4PK/E35uBr9fo8WAdzkCpLWwlw8hVH3A7tRdvsjd8ox6EUHp3Wl/O8mUzIcmskaFaHX6v3pGsTmlb6L0kkZUDrCPi6nMqQSYNQMAbf1Wb7028FphWBTDeu8K8b7GlbXLGZ+0Ude99JnmU6w8O2LpJ9f62mvIllIVHm9cfKQU/sUv3VBMlrNWQjNt9YUNKe4+s+AOpnR0/uly0gPRY8x2SHp/bNP+uD5c5c5l5sJcriWR0ixSNDEXtlzoiOdnVGZe55xakl1KhQnkLH8y6tvotUYcaGX0LWWr+OHLzAOHEA2rAsskpQ+/iZh/k3i8bpO0Rb6OqavZsfiz/r6Bcpl88lAw133gxQTWpLrkvLttv4yUXuZgyGOLnzpFxkJvcOHOEcWwvAiNqJC7hIB8pecEjKCuYxxBK9Jc2dJIRZtaDamnq9FBhYMarNusxHd6eaZ1IqUIwIR5PfzVDQFDsVvps714wg1m1u8CJUcW552F/DsDtlMMBJRC11vLLMZBrd8r1ILeSG7EOHNg7WNGqTdAAksexSEAOkyIfYl55Kr+fi4VqQILSfQaMMYomQZ7ZzwzauNSG17JCMUGuqdIBJ2btx4up2Fn44Y2Z2yVCgR5ijX+IFrbrcPcUwQpc3VaXYk11AArNM6+Dt45DmhMR9HKqKKJ837jOzHRmtfuqnfy5m8+PLoHtkqlkc4px05978KVdaHm8QzYJ5jQxANThAKm/5hq/JmsUP5emivmjoRZC59iRPOVGZPK7CbyMfPqFlC7MOMOxRND0qNbJ2y/lA== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(136003)(376002)(346002)(39860400002)(40470700004)(36840700001)(46966006)(2616005)(31696002)(47076005)(336012)(426003)(186003)(83380400001)(82740400003)(356005)(7636003)(40460700003)(70586007)(31686004)(70206006)(36860700001)(4326008)(8676002)(36756003)(316002)(44832011)(8936002)(82310400005)(5660300002)(2906002)(9786002)(54906003)(478600001)(41300700001)(26005)(53546011)(110136005)(40480700001)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 18:08:34.6295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa900460-6160-45d0-0d8b-08da85327ece X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0059.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3855 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/23/2022 9:41 AM, David Marchand wrote: > On Thu, Aug 4, 2022 at 9:06 PM Andrew Rybchenko > wrote: >> >> Remove deprecated because of invalid namespace defines. >> >> Andrew Rybchenko (10): >> ethdev: remove deprecated link speed and duplex defines >> ethdev: remove deprecated Rx and Tx multi-queue mode defines >> ethdev: remove deprecated defines for RSS configuration >> ethdev: remove deprecated Rx and Tx offload defines >> ethdev: remove deprecated DCB and VMDq defines >> ethdev: remove deprecated tunnel type defines >> ethdev: remove deprecated flow control defines >> ethdev: remove deprecated VLAN offload configuration defines >> ethdev: remove deprecated maximum Rx MAC addresses define >> ethdev: remove deprecated metadata dynamic fields defines >> > > Same comment as for the mbuf flags patch, we have a cocci script to do > the migration to the "new" API: devtools/cocci/namespace_ethdev.cocci > We can reference it in the release notes. > Agreed. I will group release notes updates while merging. And note 'devtools/cocci/namespace_ethdev.cocci'. > I suspect the RN will grow quite big for 22.11. > Can we perhaps have a single entry for ethdev, listing all the > different defines in a sublist? I am also not sure about benefit of the multiple commits, I will keep as it is since it is already split. But maybe can be squashed while pulling from next-net. > (and looking again at the other cleanups, this last comment applies to > the mempool series too). > > > I sent some comments, but otherwise, the series lgtm and you can add my ack. Adding your explicit ack while merging: Acked-by: David Marchand For series, Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.