From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C079EA0350; Tue, 23 Jun 2020 19:46:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D41D1D6C4; Tue, 23 Jun 2020 19:46:18 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id F26651D6C1 for ; Tue, 23 Jun 2020 19:46:16 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 907235C019C; Tue, 23 Jun 2020 13:46:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 23 Jun 2020 13:46:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Q+WFOzUMWmQkPma7INt1OESLg+J3YpcWMMShkCc8fq4=; b=DQ28GAyjlZU0oA7n DvGeCENppvb6ZJWBoVQ96yivmQ89elWl3sMRL+EQJJnn5+fQSmC9bft8YXALYthn 7cQ/hh51cHjdWWGV6/MFO28t2zlP2xE9bC843RsBkVceZ46m4AC0Zu/evBnCf2Xz JBYIJmn4Uf4rUcvi8u+fZvXsUJ74HkU6MnHuBWsMAd5z2tAhoYS3toZ0I6KtsbNF GT/vgAXyOSew7Omev87rXOlaEGyHI6Htd7NghUTUIJMNhWmpDxZ7vkH7SDnKeScv TCABxRJGvGmuzAUYi4B81tmDsL0iB8rdQd7bZmT3I5swKbXU9kHt51idig7jQrWa hKlldA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Q+WFOzUMWmQkPma7INt1OESLg+J3YpcWMMShkCc8f q4=; b=M7CLdFWrwPWg2nPM++UN6bE6FQOOxyPs20g6SYZbcbFghFkD+/B+8S45x Z1WusoAh7kTj4E+D/hdjFo/5uvq3XgduOtD1tZ/qNRfTr494IyGlSvu8IfaPGEN4 aEX8kQxj8QLPX9KwEVQV6dCAVGoDVecx88Ocyurp4sIn8jAKk9zUyU4zjDXgObzG dtVq5b6te7ljbpFBgJp77tLbuqXQ+Xqf4M8C72b3RR4t/mjyWx+BqLzBMnBU6nSP JxBA2oBt2nZerXtAzd+J9wroB+b7ffXk/h/Th27Rt3e7lvuozKBptAZ3j3YthMF9 vICdoU39WxVdE8ChKJcqwaV7JVIOw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekhedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C8C9030673EC; Tue, 23 Jun 2020 13:46:13 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, bruce.richardson@intel.com Date: Tue, 23 Jun 2020 19:46:12 +0200 Message-ID: <9825717.Wu33RyZiCX@thomas> In-Reply-To: <20200608083227.16020-2-talshn@mellanox.com> References: <20200608083227.16020-1-talshn@mellanox.com> <20200608083227.16020-2-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: move OS common debug functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/06/2020 10:32, talshn@mellanox.com: > From: Tal Shnaiderman > > Move common functions between Unix and Windows to eal_common_debug.c. [...] > --- /dev/null > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -0,0 +1,58 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Mellanox Technologies, Ltd I think you should keep Intel copyright for this code. > + */ > +#include A blank line is missing after the copyright block.