From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C83BFA00C4; Fri, 7 Oct 2022 19:19:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78C8040687; Fri, 7 Oct 2022 19:19:37 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2082.outbound.protection.outlook.com [40.107.93.82]) by mails.dpdk.org (Postfix) with ESMTP id 74FD940151 for ; Fri, 7 Oct 2022 19:19:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQbMA+gv2PTpYumCVdCknALcC5yDlgKcCzi3u3C2e5wOr2jTgBMo+rNCX9RCcfzkJCR/dnMX8PR1jxXUhRIc0hJhC7XpCtsnRcZaZH991NUrnV25Vq8Yz2boEAsl0g2ogttaMWsjimeHZVZOu536bnvxWrxtDCbK1fCKdV1f2g2S7CXWZEhETOKP/LjtNn+Ggz4nUb8mYHminl867Fr0yGXzwdOnRrHcfSXB66OTz1r4cLFiyhPlogFM1ZxJK9Fj7Jry9B1fLZkAogiNveqf0W+KyPiZH2A6Fx6QHO7PVPl6jcZzwoidi9hNwuwoW6mjQ0ogsoombuGZ74oNbjUSOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1nzYcOigpYXh2Ss//8QnXj8WoRY/vdHPgCXarjD0ECc=; b=k7J5s7vrr5kYSh3HvVwLHqDPUexBlrD+T6yBgkQOR9V6Qhu60ebh+VhEskavjcWfIqqc29qxYCl7ACJ6fZOiC6ddxrPmrYSGf9NIuP4NHvb7WCPWdGD/MnBhWeAH/biMzED6MhuJgM8xl2ky6qiNmfSbEPYPrDNXI9t+L2cYBiVX4uk9yO/waK3XAQletK5LQtLTqOAa+jsJ3Z4pdLeeJl7VbUlvLO7XzlOIgAv+TGweSbDoCFW/YbJPNe5ITRUQxViMn5lklFPf7ChrwRcPBsFgtRXSIX83Q2qMIHkXxcDQ7+GaTzqgf5K1JyMuRNRAj3osXXaRURsRr+5wE0VlaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1nzYcOigpYXh2Ss//8QnXj8WoRY/vdHPgCXarjD0ECc=; b=UmvGpQdrAD6vY0zyVx0vaoaw/6JZXsJHfk6SdRrjn2/D20upPgMBAMliVLYjZpgc0JLirrTxQYaNTR+UuOsIY0Icr4lL3O597ZV2/szrlouOKNWKDjluvNNd4AEpTkuH4MEPG41P4go39sy/WMJrMcwMYIeFob34Vh/X95uiDys= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB6349.namprd12.prod.outlook.com (2603:10b6:8:a4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Fri, 7 Oct 2022 17:19:33 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%6]) with mapi id 15.20.5676.036; Fri, 7 Oct 2022 17:19:33 +0000 Message-ID: <983cf017-bb4d-0bd9-abb4-d3dcacab03ca@amd.com> Date: Fri, 7 Oct 2022 18:19:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v4 6/6] net/af_xdp: make compatible with libbpf v0.8.0 Content-Language: en-US To: Andrew Rybchenko , Ciara Loftus , Qi Zhang Cc: dev@dpdk.org, Bruce Richardson References: <20220624102354.1516606-1-ciara.loftus@intel.com> <20221006062654.1420349-1-andrew.rybchenko@oktetlabs.ru> <20221006062654.1420349-7-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <20221006062654.1420349-7-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::20) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM4PR12MB6349:EE_ X-MS-Office365-Filtering-Correlation-Id: 73374cbc-043a-45e3-5d05-08daa8881a26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QEyKkD3cg00oIVfKGOQ7LDNCIgs/bxSvdT5l8355BSO6FLdseRbLI8xSS+cKtB52CWnU9Dbqly5763aANFlTatAMWH218G/07aXF5JkrHnGZHab1fQfe/fPdQEUpzYjkAOnRuVb96VnxJTaAC4vFbYQw3WvLYfx4yDesyT+U9MvmIwtf/y7iaLHn6Vo2vcMn/GW9cmsgWInTOYsl37zQS48ZHi18ntzDBnPRAiIz6xjV59eO72QBCZzkEzWGbDE4Z3IQoChcuPFgY16Slt/BXV2Rvz7iR1opf92KjwiJuZFOEkZ1Brs4CT0b4f5lOjGiYazwOCclwOlnNKgP81F/eFuhk6eZpTuP18Aa47qwy7v/iak9ztL2HVpcC90ilP9rDNoiE0tkAUro259w/OyXOkaI33YeMY92XAA17ltQ1NCrGNxQqakMLcf7CYXlmofqcG96sJD2ypOtQvA5OqxocfYcpelnB9yJn5wW3zI2rQIEP5HFO5lnmP0oovowWwsU47lN6Rmwl3w2cRUaMZrnM/EQiqvNGwSzRvgXVW1jN+YdduG4DxOv9DHMIzpv8Rxu5YHBiIMaqtcGUGu2bJoti0E0qjeLt/yneafPg/5D6/FCTt5GSKHC1nLHlKLByYtfQlLlTVHtSonZLjwkXcMF3BcgHxUGCYQ+9lTmt8La0JXeP7iyf5ukini1w6kuqmx2dlFfjJ51xrfdDuw4GRHuzHZ14RSu7yn39mga5dX63T8GLjBsKCarhjOVAZQSCETnt3YXIdaftETFF7AmSFSZP4+ixQVIqdtJCG8vCgDr3eQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(451199015)(66946007)(66476007)(66556008)(6486002)(36756003)(2906002)(6666004)(83380400001)(38100700002)(478600001)(31696002)(316002)(186003)(8676002)(6506007)(2616005)(86362001)(44832011)(53546011)(4326008)(110136005)(5660300002)(26005)(31686004)(8936002)(41300700001)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFdxZFpRYVRodU9vSk05WEVvOXVSMU01UlluTm9IUDJSanY5NlNjOHVNeXJC?= =?utf-8?B?aCtLWGMrZk1UM3IrL29raEEwdWdCU1ZuWW5tMmFwalkzcVgzU0wzZ2hZMkx1?= =?utf-8?B?cU5DU2RsUGJEa29yR1R3U2N2anR1TjZTSytQbXFmbWNCZXVMcXdGVEJDREI3?= =?utf-8?B?akU3ZHdaanhLVG80b0JIYzRub0VRMmZNditHQzVxRmtnOHFaRlE2bWZ1UmZP?= =?utf-8?B?VFNZNE5ZQU43SVp3T2NkaW9DQXpNZ0FxT0wreDNhR0t2dzBQMVJnK3NSQkxY?= =?utf-8?B?S05mZVkydjFMNEE5OG93Rk4zUkdrcmFVcGRGZWUwWWhobkVRWnlFU0hSbTJ5?= =?utf-8?B?L0RHbVR0SVVHSW00MWU5NVNPNjMybTZhN3o2V0FTNTJ6OUtvM05GY2ZPbWY0?= =?utf-8?B?QlhXSDM4R01LaE5zalE5MzdDOVAxeklxY2p4UEZxVGZ1ZTZ6ZGtjcmpoejQv?= =?utf-8?B?SEYydUN6dzlOZHU4THNjZ0w1bUNyU0hwQmNndFpXNU1VeVJOV3Z4YTZwQjNm?= =?utf-8?B?aE0weUNpOVJ5OEVlVzFYRkZVVXFkTUVvZ1V1VklNREwxbVFjVkFhenJMZDRp?= =?utf-8?B?bExkUW5YVGZiRXBVZXpVK0JuOFRCWGZBaGN3cHpraGF6Zi8yQmF3Qlc5ek5W?= =?utf-8?B?RFZyWmtoS2lWV0dIcGFURXcwN2FoSkVuQ0d4YkRZeTh2MllBRkZmc2M1NTB1?= =?utf-8?B?M1N4TENjc2FyZFdCMFcwcktUaFJUVWZ2eWNkbHNDU0lvRkd3UTBzSThHbjU5?= =?utf-8?B?ZnEzQlpOK2grZ2R5a3Q3YlNrL3dtT2xFMCtVMUhuRndHV2dvRS94NjRyelY2?= =?utf-8?B?STRPZ0RRViszVG9pM21UaSsydkdYVHlNNFJnMmFVRW5aaTRmS2ZjTkQ4OU45?= =?utf-8?B?Z1FXZ3JkUEhQZnhiWjFSV3pLbkc2b3J2OTFweFVWOStmeG5IclBsWk1tcTcr?= =?utf-8?B?MCt1NE5OOExyRWZwQ0RaL25BRWZEZTRuQ1kxNVFyOUlBbG9QeVhtTmFaOTVi?= =?utf-8?B?WU1WU3BjR3F0eG5Tdlh3THNmYTFyOFhtaXJ2OEtScnQwS0ZKRVJLR1R2OHFX?= =?utf-8?B?VmRmSTVDZUoyUkZrOW0vZndCS2hjV2IyU2ovWjRGTkx4ODN2REhPc0dYY2JG?= =?utf-8?B?Tmx6YkFPb1FjT2dLTyttREZweXR1QXQycXB2c0dSYlNRMXNMRTlHUDQ5YUNZ?= =?utf-8?B?NEFMRXBYZm9sK1BwNnNTY0hmYnMzSWhXdXJabUFGaGgyVjBKUjZzYXdKUDY1?= =?utf-8?B?L2cyOFRQOC9xZ1lkOFhTd2JOWjZTZVdEM1JsVUxpaUlRTHFNcjlIWjhmZnJ3?= =?utf-8?B?VDRpb0VycXEvMEZIOE56UGFCTVozeVVwbitMbkpOdUFmTEh6bWtrM212Snpl?= =?utf-8?B?Z2t1UFJrL2kyc2YxdjEzYkxneUhNNEl3RWFwekRHYml4ajhvelNlRmdVRENr?= =?utf-8?B?WnFyTm5LSHAwMUdPenNXTi8zWWdLVHg1ak1ROXNERVpJcEhtSW1yNm5YbmxL?= =?utf-8?B?Ri9salM2UmlTbnVSSTV3TlpkaTNMWkFadG5xbU9RczFVUzJTUGhQYkU5OGQw?= =?utf-8?B?VmFrcDFDRldFQjZjR09FVzdTWnBYVGV3RUh2REYzRGhxUlkrTEZxaWNuSkh3?= =?utf-8?B?Zy83WWRkcUlMVFdSK3RIZm1OeGZVUWMyRjdaeTBadHdpbXB6eGJhUUdiWFhW?= =?utf-8?B?SklyTEFQbUprMXJ2YmJIYjl3VHF1TmN0NmZDdUdNeUxRNm5ZamdlWXFoSFZu?= =?utf-8?B?SUhLOHNBbC9WTVRsZVJJUGRHUWY2K3Y0R0tOQkNhQ3IrSUk4WWJhRWhtanFq?= =?utf-8?B?UjM1M2VuaDdKMmljcjV5ekdvZmtrQzVWTm5tNDlRMWladENpZjRVbzg5UGM4?= =?utf-8?B?TFFWNVVpWFdBVXdXY0JweExxcVZ2aUlMN0I1Z2xDTjY1eW9Mb25QeUhLc2NY?= =?utf-8?B?RE94YkJBU01GcXJ6OWdJajVhN0xWOHpqdG1vY0VWbk9Sa3kvTTFaMmdKZlp0?= =?utf-8?B?V0RVdncycXIzMG85Y2ZSZlFlNGNwM211d1BiNGNZR1BqcWdqSDFua3Jva2p6?= =?utf-8?B?cTVPN1B3OG5wZHBlYVQ0TXpmZWdPMThpekJHUkRXTTdNMmVlbFdGQUlmdjdP?= =?utf-8?Q?Zy8BPkG3crpA7pPhKEaDFJoFQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73374cbc-043a-45e3-5d05-08daa8881a26 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:19:33.6273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o3XDrdHKbXoSUSmjVxyRsLpfwQmmGacg4LTsIOdyiGM7D0aJeEE5x3979tHgyZvv X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6349 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/2022 7:26 AM, Andrew Rybchenko wrote: > From: Ciara Loftus > > libbpf v0.8.0 deprecates the bpf_get_link_xdp_id() and > bpf_set_link_xdp_fd() functions. Use meson to detect if > bpf_xdp_attach() is available and if so, use the recommended > replacement functions bpf_xdp_query_id(), bpf_xdp_attach() > and bpf_xdp_detach(). > > Signed-off-by: Ciara Loftus > Signed-off-by: Andrew Rybchenko <...> > diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build > index 9d5ffab96b..858047989e 100644 > --- a/drivers/net/af_xdp/meson.build > +++ b/drivers/net/af_xdp/meson.build > @@ -64,4 +64,9 @@ if build > dependencies : bpf_dep) > cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN'] > endif > + if cc.has_function('bpf_xdp_attach', > + prefix : '#include ', > + dependencies : bpf_dep) > + cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH'] > + endif meson is not detecting functions, I am getting following log, any idea what is going wrong: Run-time dependency libxdp found: YES 1.2.2 Run-time dependency libbpf found: YES 0.8.1 Has header "linux/if_xdp.h" : YES Has header "xdp/xsk.h" : YES Has header "bpf/bpf.h" : YES Checking for function "xsk_socket__create_shared" with dependencies libxdp, libbpf: NO Checking for function "bpf_object__next_program" with dependency libbpf: NO Checking for function "bpf_xdp_attach" with dependency libbpf: NO