From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: stable@dpdk.org, cristian.dumitrescu@intel.com, dev@dpdk.org,
jacekx.piasecki@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] cfgfile: avoid stack buffer underflow
Date: Tue, 07 Jul 2020 19:24:28 +0200 [thread overview]
Message-ID: <9842695.2Akpk08PZk@thomas> (raw)
In-Reply-To: <20200702092039.GC611@bricha3-MOBL.ger.corp.intel.com>
02/07/2020 11:20, Bruce Richardson:
> On Wed, Jul 01, 2020 at 08:05:58PM -0700, Stephen Hemminger wrote:
> > If cfgfile is give a line with comment character at the start
> > of the line, it will dereference outside of the buffer.
> >
> > Detected with address sanitizer:
[...]
>
> Good catch by the tool.
>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-07-07 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 3:05 [dpdk-dev] " Stephen Hemminger
2020-07-02 9:20 ` Bruce Richardson
2020-07-07 17:24 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9842695.2Akpk08PZk@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jacekx.piasecki@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).