From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5675CA00BE; Tue, 7 Jul 2020 19:24:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D5F31DEB3; Tue, 7 Jul 2020 19:24:32 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0E0761DEB2; Tue, 7 Jul 2020 19:24:31 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A31E55C01EE; Tue, 7 Jul 2020 13:24:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 07 Jul 2020 13:24:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= UZb0+6FKc/TFZnJR/CIgAccN3/6fSV3fN43NKGiazc8=; b=r2N45lj6ONtxLpat VLHl8hs2AbIGTuL+EwyrTweVJWnSGaROQf6xutHWJL9rivlABrMWkA2YsQFyKfHo gygsiTq/cWE+u6nlUMYF2At6HERNU6TOYFI8P0zU2Nq/A9xYCSb0wTxX4NFByRa2 MS4OJqPqwTGpcq0BLpsfp1YRhkIwosPGPGQBbXmB425lbK2y5vZ2VNo01/QgVLMC npHzCl2+U9jNzY6D8ZE8Df+jUylrPX/OBlKH6BMIhuz+PNgRn0hvKJfOMLYDudlp zsPLNtXR/JkuH5vn3YN5DoEMQmMQORoq/gr4HzWtimZJVhypHf3RPzPvdbe/DKF8 1EpsHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UZb0+6FKc/TFZnJR/CIgAccN3/6fSV3fN43NKGiaz c8=; b=lfRs4tBHJvWCIYwTzblbN2dyBhoJBzH71MGn2tP9AEQhQjYj+7WyDgjdv PtXGi6V8Z5y/cPJU+P7Uq0ylof67AECEGE8uPOQ4C2y7PDuHIe8aYqTYKCXn2GBe ct9Lw1COnbz3WYhiTjCSgmMvu6+1zEYexKA26wNecsoJR2cZxgZMF4H1I7R38sBd Mw6hmvgGyJ+5F5CZeBkN7xeRhtapw8cWxzWGAQGUz71zfGSawpTdwQdL/X76DN7l hOnTtYJ4IcgMf2vplVS8cseT8F+kjCDerjpU5DRq3X3TRnYSDPxqLjSvr7jClVDE tantz3NzsqYFcz6AaNldX5R6NmT4w== X-ME-Sender: <xms:zq8EX2uMz8zgqXAocwu-TSOUOucRgYviEDWqo7EhGnYUZI7KF7_H8Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehgddutdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:zq8EX7cHITF0QvnuiDKdZY-DHvH3GGlngLVJH4ByNqaySHM8hASTtw> <xmx:zq8EXxwLE17iu--rwsoYy6OY7KYCkhWcqw_falD0NYdp0Pl9mXBtrA> <xmx:zq8EXxNPyvQRVtSeDGygwpJivZeEgfP5XithgfVRjt20uvXi8JPURA> <xmx:zq8EX4KtADXarjnw_26fRFJUSkaQXbkj_9AKU7fYaK5F8cvlKyftzg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7D118328005D; Tue, 7 Jul 2020 13:24:29 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Stephen Hemminger <stephen@networkplumber.org> Cc: stable@dpdk.org, cristian.dumitrescu@intel.com, dev@dpdk.org, jacekx.piasecki@intel.com, Bruce Richardson <bruce.richardson@intel.com> Date: Tue, 07 Jul 2020 19:24:28 +0200 Message-ID: <9842695.2Akpk08PZk@thomas> In-Reply-To: <20200702092039.GC611@bricha3-MOBL.ger.corp.intel.com> References: <20200702030558.17852-1-stephen@networkplumber.org> <20200702092039.GC611@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] cfgfile: avoid stack buffer underflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 02/07/2020 11:20, Bruce Richardson: > On Wed, Jul 01, 2020 at 08:05:58PM -0700, Stephen Hemminger wrote: > > If cfgfile is give a line with comment character at the start > > of the line, it will dereference outside of the buffer. > > > > Detected with address sanitizer: [...] > > Good catch by the tool. > > Reviewed-by: Bruce Richardson <bruce.richardson@intel.com> Applied, thanks