From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id AB38D4F9B for ; Tue, 6 Nov 2018 00:08:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 38C3122967; Mon, 5 Nov 2018 18:08:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 05 Nov 2018 18:08:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=c3MU8VY6Dqh8VZkWbF1snDQEH9GB1TPzJLDPkheTwcE=; b=nqtdLavysr0b gchk+fKEfb0MJ+T7l7tQA9WU4JLIJlhmHyclDLY3zXjK3IUVF+Ss8jOmxj6NKTbc 1s+cg64zUV0fSjfyyq1csVl+ov4tRvckjFeberKVmZOEN1hCbZvZkgL/oyEqqiUK S+zeU+WSRuTzu0vLO1paqqzt1bVcOoA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=c3MU8VY6Dqh8VZkWbF1snDQEH9GB1TPzJLDPkheTw cE=; b=ktNNXVTsAhKPx0E7Erd7xmS+/tjh0ajsaI0fVkcoehguH29pqwGnHUikO 6vtBmCcMfYS3op7q4ZEaeS/Xl4Kuh9xlqVpBKzhKsDD0JLO97MRLCyLJPo1CTHrd Y5bW/RDZ+xMF6Nl8mcc+2xET5lcfZeVLDFQ+TRcmX0d6wW5beTcJnahKTZAPIOqg 9L5ZD5C8I6aCmGiYN8ZHbonfZC7gMYjRFK3tuEdc8zNykLnKUIJM4YAyFL1IA5By krf825/7bZ66KJUo2s7GNPDN2U7vmEIJNXLMZK7wpWjIHEunNHGfd6HeJayAwp96 XZijNoShtQI8/ceRiW1DXz8x3Al2Q== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 245C3E47C4; Mon, 5 Nov 2018 18:08:38 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: Kevin Traynor , ophirmu@mellanox.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, ian.stokes@intel.com Date: Tue, 06 Nov 2018 00:08:37 +0100 Message-ID: <9843117.IEzvs299zs@xps> In-Reply-To: <1715062.3G7La7yUx6@xps> References: <20181101144633.13429-1-thomas@monjalon.net> <13462be0-7835-144a-143f-1e0d30343503@redhat.com> <1715062.3G7La7yUx6@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: remove experimental tag for probe/remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 23:08:41 -0000 05/11/2018 14:13, Thomas Monjalon: > 05/11/2018 13:19, Kevin Traynor: > > On 11/01/2018 02:46 PM, Thomas Monjalon wrote: > > > The functions rte_dev_probe() and rte_dev_remove() are new > > > in DPDK 18.11 so they got the experimental tag by policy. > > > However they are too much basic functions for being skipped > > > by strict applications which do not use experimental functions. > > > > > > The alternative is to use rte_eal_hotplug_add() and > > > rte_eal_hotplug_remove(), but their API requires the application > > > to parse the devargs string in order to provide bus name, > > > device name and driver arguments. > > > > > > The new function rte_dev_probe() is really simpler to use and > > > more flexible by accepting any devargs string. > > > Let's encourage applications to use it. > > > > > > The old functions rte_eal_hotplug_* may be deprecated later. > > > > > > Signed-off-by: Thomas Monjalon > > > > one minor comment below, but it's no big deal.. > > > > Acked-by: Kevin Traynor > > Tested-by: Kevin Traynor > [...] > > > --- a/lib/librte_eal/rte_eal_version.map > > > +++ b/lib/librte_eal/rte_eal_version.map > > > @@ -262,6 +262,8 @@ DPDK_18.11 { > > > rte_eal_get_runtime_dir; > > > rte_eal_hotplug_add; > > > rte_eal_hotplug_remove; > > > + rte_dev_probe; > > > + rte_dev_remove; > > > > maybe you want to keep these in alphabetical order > > Oh yes, I must revise the alphabetical order! > Thanks Series applied with above change.