From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id B1DEE326B
 for <dev@dpdk.org>; Fri, 28 Oct 2016 09:26:13 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id e69so80454468wmg.0
 for <dev@dpdk.org>; Fri, 28 Oct 2016 00:26:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=AFQHefBVhxaO5LnzAD0Pw2PtDlmtbFK7am5Ae0lnVfs=;
 b=tiwr/t9+iSBaYqGakDO5tmRFWXJxZ/rA9Xae1o5hf4nD1XzcTvHg1U9YUl3C+JWtb/
 PHsQSGCtBYQE6Dhy/E+KuihqxzxPpXj25r3y0PBqN2qnjGSfA5bp5K3EvZY/BnxLzLla
 zwoNOF9yP/mwBeMdFBy42GJrVX4zJyQdwZqSjvGKTUx1o1N2vHIolXCt5F9iC0b/Pj6b
 mbiA4Qskc7omnvcMhIKhw/wEPp44Wy9YJwS0wrZWSNWd6dmQX5yt70FPXV6on8miHq93
 FFEnoCXqFKqKs3b48/ZPhWWpyf/CmyP7moRvX/V4/KUW+XBYH6OQJ/mWCccyQ5CDCLX5
 BifA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=AFQHefBVhxaO5LnzAD0Pw2PtDlmtbFK7am5Ae0lnVfs=;
 b=AUSGHINSzoCZvsoeNqoDk3/o4MsnnH8ilKWFOZIraOB4IA+GpERT6JlgXweaS+94Wb
 jw7ZbsWBMacAqCU6JHQ4uwHxRSNczaLcd2HZPp8z1vqWF1jmWh7WKsTrctqyc/KtL5pQ
 tL0X/RmXoWvBcmjBiTutMcmVQGedpKVxr4LgLtpaWyp3ni9QnUfUpuoeuw2LeQOOX882
 UCg6SS99+tgKVOlxVMWgSyYBa1OObCbHGtTZkmHhnl4PTkDDPZssaQrkaCASJPO0uzoe
 jQKcbfpBg2PzxkAsRqFBmHUcPe4z620NFZKbEsKVqwE7Iv8k85u2pSzw+q5oqiCfjoL7
 +IaQ==
X-Gm-Message-State: ABUngvcE4YRCwXhXHOlDizpFEpeZALK4uKmNYhJyWXZVpCYNySCsoK11/to75lkpQTWYMIJQ
X-Received: by 10.194.127.5 with SMTP id nc5mr12156390wjb.16.1477639573399;
 Fri, 28 Oct 2016 00:26:13 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id 194sm7355818wmj.20.2016.10.28.00.26.12
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 28 Oct 2016 00:26:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Date: Fri, 28 Oct 2016 09:26:11 +0200
Message-ID: <9851708.0H4Kn83q5Z@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1477636922-18546-1-git-send-email-rasesh.mody@qlogic.com>
References: <1772382.AymLqBrjhc@xps13>
 <1477636922-18546-1-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com
Subject: Re: [dpdk-dev] [PATCH] net/qede: fix advertising link speed
	capability
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Oct 2016 07:26:13 -0000

2016-10-27 23:42, Rasesh Mody:
> From: Harish Patil <harish.patil@qlogic.com>
> 
> Fix to advertise device's link speed capability based on current
> link speed rather than returning driver supported speeds.
[...]
> -	dev_info->speed_capa = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G |
> -			       ETH_LINK_SPEED_100G;
> +	memset(&link, 0, sizeof(struct qed_link_output));
> +	qdev->ops->common->get_link(edev, &link);
> +	dev_info->speed_capa = rte_eth_speed_bitflag(link.speed, 0);
>  }

No, that's wrong.
You must advertise a capability!
So what the device supports?
Are every qede devices support ETH_LINK_SPEED_100G?