From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A97E61094 for ; Mon, 3 Jul 2017 12:08:48 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2017 03:08:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,302,1496127600"; d="scan'208";a="103949507" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 03 Jul 2017 03:08:45 -0700 To: Rasesh Mody , dev@dpdk.org Cc: Dept-EngDPDKDev@cavium.com References: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com> <1498937402-25547-8-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: <98563df5-d18b-c80b-4326-445524ee4e6b@intel.com> Date: Mon, 3 Jul 2017 11:08:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1498937402-25547-8-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 7/8] net/qede: add missing check for VNI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 10:08:49 -0000 On 7/1/2017 8:30 PM, Rasesh Mody wrote: > Add missing check for VNI field while adding unicast filter. Can you please document the result of not having vni field? And if this is fixing an error, can you please use fixes syntax? > > Signed-off-by: Rasesh Mody > --- > drivers/net/qede/qede_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index ad264ba..a0616a4 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -571,6 +571,7 @@ static void qede_set_cmn_tunn_param(struct ecore_tunnel_info *p_tunn, > SLIST_FOREACH(tmp, &qdev->uc_list_head, list) { > if ((memcmp(mac_addr, &tmp->mac, > ETHER_ADDR_LEN) == 0) && > + ucast->vni == tmp->vni && > ucast->vlan == tmp->vlan) { > DP_ERR(edev, "Unicast MAC is already added" > " with vlan = %u, vni = %u\n", >