From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59BD2A034C; Wed, 23 Feb 2022 11:03:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 472A640E5A; Wed, 23 Feb 2022 11:03:18 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 00E5340DF6 for ; Wed, 23 Feb 2022 11:03:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645610596; x=1677146596; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=FbRnPfOvylnE1xXvnacpEq7ZfPwSnzNVx8lkZUOViw0=; b=Zv3SrEVQzuGZ5rMWEDHdqHjYjmI0CXZnF8ZWE2r50IFtQK4RwOGz5YhD Mb7wOIja7p3QucUv6vtSFHEJQXZKjktT8R2JcJf5uqTh7O61qRl6gD4dY Nz19osxIJmWSsdIb4orfjCCK5vd7MGSbWL3nNlsvWxHjBtSsUFxiPUvdP oVQcRvlWvw7G/JmSBUpJ9+uPucqu/J00K4FPtALgn+VZTAtEDLkjy5RZR NtGHYrqWYKc5BccwYCPGi74Lw9EVeBq+RNBN4djjIT3MxQ584QaLC9KeZ Xxmccei8fHfoUO0A9MfR3vXFP5Z2T/NkSBXFrtM8JmItda7IyRRkaItUa Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="252120109" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="252120109" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 02:03:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="591647888" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 23 Feb 2022 02:03:15 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 02:03:14 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 02:03:14 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 02:03:14 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 02:03:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VpEh3NZN8nIItj9a6DuxNEyIknzh9Cj0Q3MExuEmz7VKPW9y6CnpgldUMiwFZaWO3kxO1jJdpWrciPwj6SDfvdpQ/J5B8NiYD80oH195nzIVQ3T9bY21hn17euGmi6x58TdiZmx1iFt1CpQ41LvSkHAN1rXw3fiTaCJl9G5/2I+fBE9niXsHWRYL1R0cwysN5P6pRkFQ7S95tm5ekJqjovgL3nlnZlRURRg2WTN0ukII5fp3vkDfSZQsapnqbQUjtarZgXJg2MERowl9H/Z2MvUs2x/vKbd/DfRaoXMKO8AI9sEKdK56A3EKdX+h3f5o2w1wcrOyhS2s2LxgJF4m3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ddmVUfGu1djqP4hCP1jbpXUYsGYof6fisWUOXdHy+hw=; b=TIVSpYHYjMLo0SIZXihHYkCYwog7ev1YkEdjOFRlWy+9Vi+tyjnNxvf8TpRoF85+zPeM1AVE9ieqBzlf8UxVbgN3CRiWIpA9mtwMKWnIG5Wx+O+O0w9VJASKrik4TfhCbNQ3Ags0aLHMQ0auwgDhjcCR9ieooR30Bp/dcFgm0mu6HakW7z2sm+ukxURMLKTOZpBEw3x3iatQdL+ZPzb0O8kCm8teOdfT6pd0Uj1/j8qdkC9gkPruAtKE/K7717YHzPVTQKZD7/MssmHPj8jDd7gJs9vj6yCCAt9ZiqmqjBByxFXWMr4W3pmqBwI0cMsd71t3Ki/j7OhvT2nY9I9zsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB4400.namprd11.prod.outlook.com (2603:10b6:208:18c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.17; Wed, 23 Feb 2022 10:03:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 10:03:11 +0000 Message-ID: <985f6f5f-996a-cc29-f4af-3657a2f16ba9@intel.com> Date: Wed, 23 Feb 2022 10:03:04 +0000 Subject: Re: [PATCH] sched: fix integer handling issue Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Stephen Hemminger" CC: Megha Ajmera , , , References: <20220222131851.2944637-1-megha.ajmera@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D86EDB@smartserver.smartshare.dk> <20220222080306.1caf1fc9@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35D86EDE@smartserver.smartshare.dk> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86EDE@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0335.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94e918ad-8299-4a07-ce63-08d9f6b3b32a X-MS-TrafficTypeDiagnostic: MN2PR11MB4400:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kpLSIhm9Vwo8KRqCaJiw5xhXMhlY/wY1knbLU3VfuPBCHYLWXPXYDfW5U3W1GbmOQtx/fc9RWuxafGKjalnvrMKUgHyS6HNt3fhNQZaQbk0FZif+CuFDMYUyIIYS2/YIquqKzpn1eqX5Jwf941+M6rsZkAGfwYoWZYSh1sa/S/73nx4aDQAIStRBvo8hbaYhnQER22gAZrWerxTVZFqgC5QU/Rg6vNA4SElNTtmZLc9InPPFmE6WPu+cA8uJ8QgWgN9C5Nf7jd6GNP8V6gxWyVxPHsUTofmABeeKq6n1EsuhyQNu+qZQ/GfXDhzYzr+FsPhr1CnWWv+8xOCux22XjcFazdII0czpxTVgKMVgAhWQZqafTgGOQx1M0Ygiss2GzH8n857aw0dj8p+9p5rzaL8GBCgitV6f5KvGa6pdZCe95lflo9uecrqkdhWz5lmBFik0ejaOHrhi17Qxnw1at2F8tm6j6aIesd83zAoyfm2yhwbqraBU8V4mAlOEIEINcfZj+2PF+9y3AJjavjkSV8JOjwUbLTplxQAks+/86VxjJi987/QXE2FlIFK4ZLsUw6Nh5RJQNrTWKYOTobcBbnK3T9Ox2i1Y+5PSdHk01DXcmU7xU8Bs+j5xZIrWwb6Hqp0m09VruyXQAt6voBlqJXfXkLVwfkcFJC9UkB55dUTR7Oa9ZGHTcPcIvI6GXnVbZop5gZBUi2EJHU3CfGVKiA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(2616005)(6666004)(6506007)(6486002)(53546011)(508600001)(31686004)(6512007)(107886003)(2906002)(38100700002)(4326008)(186003)(5660300002)(66556008)(110136005)(26005)(8676002)(66574015)(8936002)(66476007)(316002)(44832011)(31696002)(82960400001)(86362001)(83380400001)(66946007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cDFiMWg5T3pXTE9kZGJTT01JTm40Y3U1V1lxdzVXVHNmUUx5MEhIRGhIMXZB?= =?utf-8?B?dkF5VS9EV1BuTXBqZEt3akJVWG5DbHNlV3lSd0VaQ1RYR1VCaWhxQkdKd09M?= =?utf-8?B?RlRKQXNwcGgza3NMaGVvenNtSktGZE9zNTVzaTJRaG81dFAzQkpTWUgycVpp?= =?utf-8?B?K1Vod01WYkM3WmE3cGZEckZJWXA0Q1U4MC9SQUprdVROTDVtRDhTVzFWMDZU?= =?utf-8?B?S3VscHZ0d3dBOXNrMTMyRkpnRy84aW9uVUNzb1RkYytyVDZuWHpNRjNTOTYy?= =?utf-8?B?T3BsaHJzQkNWV1Z3V1dRaE1QWnVOYWpYbmJXcUhpcm56U3phZ1ZCSkw4aFIz?= =?utf-8?B?eHBFVS9MdGEwdXVWVWphYWovWU1ONGR0amdYc2FZZVg5OThMeWFydWszTklU?= =?utf-8?B?dGJCWnhiV3lhdmZDck43VWtRZFRoVkxUMit1cW15d3lrRTkrYlFyUzU5V2Zt?= =?utf-8?B?S2RMc3IzU3VOK3ZPblNWcjVpZ1dqOG50b1p3bXplekRjWjluQkpYZnQvZnpC?= =?utf-8?B?MU1Oek0xQ1FrTnJ0djdqNnhzajEybUJPNExscytDUnBqdmtWLzJwbVY3SC9K?= =?utf-8?B?ZWtidHhteWFhUHZvcU01eEFKcEhuMUVQbFY1QWhhVnV3U0pNSDNSTmwzZk9T?= =?utf-8?B?Wit3djBjVC91YUlJdGhDcmZwVlNKSkNKSkJ6NnN1Q3ozakJlT0RFUTNaWWZC?= =?utf-8?B?TzcvTVNSUFpBeUswMTIzZjdOSTJ4Tml1WW4xckV6bkE1ZWJuQXN5Sko2ZVd4?= =?utf-8?B?cWFxNlFta21MNnh2UE9LSTRkUFdXUUZHTTBTL3hBQ1crTGgwYll2cmRtK3Vw?= =?utf-8?B?QkNTSzNwNGZ4eVZseWVYVHNEUnJpZWxKZSt4MHNKUm5kN1lKY0hHN1BGOTla?= =?utf-8?B?RWJjajdGblcreVE0QlV3U1RvcVRGQXhnYW1qUU82NVNIRnhIV1htajBqSS9Z?= =?utf-8?B?NmxIUUwzdDhVR0w1aDBBTzdUWDJTZXNVTGt4THNtQ3pBRStVbnFpUHg5Q2hq?= =?utf-8?B?RUZ2K3oyTjBFbFBlaEZ4YkpGK29mL3dnUFBDY1dUZmJ2d0Fob2o5dE5xRWJh?= =?utf-8?B?L2ZybEdLSEZDc1oxbXhiaHBqUFh2QllHL0J1d1RWaVdsVlJHVFdQMXdUaVFh?= =?utf-8?B?MjU5WGpqbnV4K2V3ZU9TSm9QK1REdXYwQkY1TjR1Z1V1dG5qYmFCVnFObllL?= =?utf-8?B?dFVraEEyQmh4VzR2RWtadTV1bmliUTdidkw3V3BzcFZQc3ZzL0ZZT0hkWHBy?= =?utf-8?B?N2FrYWE1M0pMd21LUnF0YXJzcWFtcENCd0VSb0xxckFVR1NaS2QzRVRQcC9r?= =?utf-8?B?S3BBRTF0QktyQjUyclVHYzBnZGlvVFBxSTdXNVkzTDhVRGYyU0VtbThUZnY5?= =?utf-8?B?Qm9TMkxZeTRobGpNc1BOSDVudlhUaXpPZld1anV5dVpDK3lxTGlReG0ySURU?= =?utf-8?B?SlEwVnJ5TENLeWt0NVpnVEdhbTNhOUJLczlqem1MVU1zU3JFdzBJOFFlOHpt?= =?utf-8?B?bnduRzgyc25Qcld5bC83RmxkVXk5c1hoVlc0SWRDZUtqZFhxc2EwMVZIOFBi?= =?utf-8?B?NDMxaGVOR3VuTEFncDFMWmpGcy9reXJ0RFQzZWtVcjdhR2hRR1JqdUFELzNV?= =?utf-8?B?WDlmYXZ0SGhDU0NhQ3FRV05sY3RNcmRFb2pDSWRBS0p6TDNLVXo3WVVLR1lB?= =?utf-8?B?dmdsRGlMUTFmcEFxZWd0UVJmY3MyTHNFY29qeU41a3FKYjMvNSs1Z0ZYck5E?= =?utf-8?B?YUcxSFBjL1BUbzJ0K2ZSa0dnRklDWUkvU2VEUHFwYUZpUUQrb0FiTXAxN2VD?= =?utf-8?B?SGJYQzIvd2NNT3lhVkdqVXhJMkhPWHNiNEtiVU92WDhJUG14Y3ZWWm1DMTMy?= =?utf-8?B?SnhaakczWnkzemsra290akZFNms0Q1ZNQldiVnByRHlpTFN2d1BNcGQwMitr?= =?utf-8?B?Q3BGTmRQdHF4ckN1WUhLT0pKOTFmL0UwV015MzNLYjBrRVhsbHFWc3pnY1Q5?= =?utf-8?B?TzhIYlJZanhXemQxSVovRENQNUcxRDF2c1NEeGxzUHJSeHkzWUVqK0tVMU4w?= =?utf-8?B?Q3UxWUs0Skw2dFd3cHVGRzZXbWNaV0UycW95YWJxMXJpKzZQOEhDKzJUZUpO?= =?utf-8?B?RmlxU2N0K3BNM2kwN0VkcytBeTZ5a1pSNURyN2JIdm82NmlBRlNYTlVyN20z?= =?utf-8?Q?opAFkWWfRddifKbMoxmZBsQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 94e918ad-8299-4a07-ce63-08d9f6b3b32a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 10:03:11.7953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NG3+iWwOEVsx32yxAUkTIhG+JdokZecA+LpgVNWUaElrvcQ/76YnNSeaX3wBv6azGwg8KWcvvQJ0er6+CYWJrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4400 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2022 7:17 AM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Tuesday, 22 February 2022 17.03 >> >> On Tue, 22 Feb 2022 15:13:53 +0100 >> Morten Brørup wrote: >> >>>> From: Megha Ajmera [mailto:megha.ajmera@intel.com] >>>> Sent: Tuesday, 22 February 2022 14.19 >>>> >>>> Masking of core mask was incorrect. Instead of using 1U for >> shifting, >>>> it >>>> should be using 1LU as the result is assigned to uint64. >>>> >>>> CID 375859: Potentially overflowing expression "1U << >> app_main_core" >>>> with >>>> type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit >>>> arithmetic, >>>> and then used in a context that expects an expression of type >>>> "uint64_t" >>>> (64 bits, unsigned). >>>> >>>> Coverity issue: 375859 >>>> >>>> Signed-off-by: Megha Ajmera >>>> --- >>>> examples/qos_sched/args.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c >>>> index 10ca7bea61..44f2f5640e 100644 >>>> --- a/examples/qos_sched/args.c >>>> +++ b/examples/qos_sched/args.c >>>> @@ -433,7 +433,7 @@ app_parse_args(int argc, char **argv) >>>> return -1; >>>> } >>>> } >>>> - app_used_core_mask |= 1u << app_main_core; >>>> + app_used_core_mask |= 1lu << app_main_core; >>> >>> Still wrong on 32 bit platforms, where long unsigned int is still 32 >> bits. >>> >>> Use this instead: >>> app_used_core_mask |= RTE_BIT64(app_main_core); >> >> DPDK now supports > 64 lcores. So all code using/assuming a 64 bit mask >> is broken. >> > > Good point. Is there a TODO-list where such a general review request can be filed, or should we just file it as a system-wide bug in Bugzilla? > > Nonetheless, I think this one-line fix should be accepted as a short term solution. > Hi Morten, I suspect there can be more places that testpmd assumes max core number is 64, someone needs to spend time to analyze and fix it.