From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E07794559D; Fri, 5 Jul 2024 23:12:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3EDE410FD; Fri, 5 Jul 2024 23:12:46 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2081.outbound.protection.outlook.com [40.107.101.81]) by mails.dpdk.org (Postfix) with ESMTP id 679C040285 for ; Fri, 5 Jul 2024 23:12:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KzFqjTPCL9a01SARBbvdaAbtp0VE5I/KaCZDo+qt4C9q5/Wq2plvkETd15hAfNqcq9O4dvonvYDceaki+uhxjT8XnizaBNPj2wjBeplzq3VjY1qwuBi006ndqodkgZZb/6AMG8qyyccHy16moxPZqtOTLmalV48LAH5gUXBzYAnVMDKa6DvX4PRNVrE2QBkorJsJpLfqifqh6j/GMC/rX8EWXYMiA9gJdl8Chk3TeyB7BgqIiysxDd4eAw2IM3tu9b+f2R3HrhNhwEY4277p1c+nFvfNar53Ru7LV7s22dbaqbWsR3VGPnIAHJLf1hSOhhFeH7v+Px3SToGKWLL48w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TEdxmNoSSZaWvWZSBJqcK8+r3jjzSpNFdaUyCK1tqxE=; b=Gmalh+L4QqITKqui3Y2AKmn1lIg5e7kfHgU5au4HRHWqtFusSESj5d4IXSHaVWwH7Ky/yGEi8Chgoat/uI1Y6VRgvRA3puAlQMZhttjtlYx2FlmU3j4L5vXvZDRJl7ibXWQom2GPTkHtYWBhompn79fda1noHWgRatw1s4UYUBaG1xjnH3eDMEuRV0/RUNPJ4c4ckBPUKi7eSHAnFLqsBlp7ZfiCbkFrXK0f99Ru2EYfJMasej07ZHZoJvj3F14jv4BMJexReYF0FnMmvft35ohGrvoVgpea4U8pZrKyEsEWxR4X3PM3H31nSHNoGV4ozWik4qfft/Qk/LPtRpTprA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TEdxmNoSSZaWvWZSBJqcK8+r3jjzSpNFdaUyCK1tqxE=; b=B9LbWJvSmtwqlkionRmt52Ldao0WuHKbu60aeL2JSksFiwkGAdpVNRzaWKnpoXdoPxFRBC99CVtvVJNqLn11bl6y5qLLz/u8+n09noj43mnvu5Zr3+5ePH5ctXpcUyuphuhfymyC3VU097RmdGNpqtqZPelnnLAoc97muFpkjZw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB9447.namprd12.prod.outlook.com (2603:10b6:8:1b4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.23; Fri, 5 Jul 2024 21:12:42 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7741.017; Fri, 5 Jul 2024 21:12:42 +0000 Message-ID: <9860873a-8071-4348-a3cc-62b192cc210e@amd.com> Date: Fri, 5 Jul 2024 22:12:37 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com, David Marchand , Thomas Monjalon References: <20240527061528.10072-1-howard_wang@realsil.com.cn> <20240613033650.5521-1-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240613033650.5521-1-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0090.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB9447:EE_ X-MS-Office365-Filtering-Correlation-Id: fd8fa505-7e3d-44af-9515-08dc9d37350c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?STZJSG1XSHErWHZlQ2hybFNJZHcyaVJlem05WEF4L29jWVdJQmRER3hlUWts?= =?utf-8?B?TlBqT2pSdXVQRXI2aXNqc3VTazExU0NhdDh6cXE4bDVURSt2RDlyamk1cXMz?= =?utf-8?B?Q1h3c1E4dXJCWVBtQkpzMnh2bWVvdjNjK3cvdTdpWnBBQUlNOW5pMXB2bzBX?= =?utf-8?B?Qi9WY3pMT0JJTXFOS1gydnp5bld6Zjd1ZEEwZmxON2lpVGpNRW9QYmNNRjlY?= =?utf-8?B?VFJjQ1ZwN1BYbllTVk1zWHdrMUNKemNuY2VNMkx2aHVJZzNrMklkU1FtbkNY?= =?utf-8?B?eGxFUFVvNnFHRnZ2SHlqcUhweGpQalZMWWc1OWpaQUd4bDY3ek9VZGdpOEha?= =?utf-8?B?ajNrYk1GK1cyTkxBZlhka2RtekI1N3lXZmhQQ0NmR0U4TUt6Y0dmamxxV25l?= =?utf-8?B?WDVBbExSaVU2VEt4NmQ3YkYvanZhY0FoZVRXSGt5VXF6am16UjYzMXo5Ty85?= =?utf-8?B?MWVkdGExQVNrWGJTWjZIcUorZ1c3YllyaHN6UFNvc09SQ2t3bmhKY0lkbTJI?= =?utf-8?B?RzJZYU1PaUhWYXNhTnZjTlkyeklieWJFUElWMGhnOFlEUlR3S000R2hObHVH?= =?utf-8?B?cVI5aTVtMk1ITUhVU3A3VFBnSjd5cFhsUnRGM0RKUytIWkR5V3I5OVRybFdx?= =?utf-8?B?c2dkeEVqdk92L0FZcksxdGlsYmtxeGtEaXUyQmZWaURLWGltQjNaRzZhOHZj?= =?utf-8?B?ZW1Xa0hINGZTMFAxQU1UR3BCa1c4Nk1OTGVlRHVyWDNvRm1QWE1uOHdSdnZZ?= =?utf-8?B?WlV6Q0JBeXVuNUtnbS9TemdHSjhFNkJMNHU5MG9HMXkycEhCc3grNFhzaHla?= =?utf-8?B?THoyVitpN0R0Rm9LbUduNFY4NWRiUWxpak9ZZGdLYkJkdzdRY29oTnh3S1dS?= =?utf-8?B?aFVZZHkwaWFKVnpoSlpRUVcwa1pXWXc3Wm9oZkRKM0FuUXBKeUdYd2QzaHM0?= =?utf-8?B?NG5QS2lvUmxnS3g0ZWM2dElXQVpveEJETVJHSE9wQU9QV3BIRnJpMC8xeGd2?= =?utf-8?B?aGJaNjJ2UC9wT1NPK3gvR2pDemFjd3gvQ2lUbmhLQTBPTzQxY3cyd0x2OW50?= =?utf-8?B?V3QyNmdGbWJ2cTFoSGp5cENSYWRTU08yWW9VcDJ3Q3c1V1o2V2NXZUtqejQ4?= =?utf-8?B?N29sRDJEdnpuV0dUWi9jaDdNaE81VitMbmNkSENwYWlJUW53K09RMTZ4SkR5?= =?utf-8?B?eWdLTE8yb3pjaWpnNVUrSm13YVk3RkFtN20zYzY0ajNhdyt1WCtDU2JvS2dk?= =?utf-8?B?bzRZSy9rQkJvSzhtNUduYTVGMXFzRGNoSDQ2V2dISU83ajE1ZGZEYTFuVDZD?= =?utf-8?B?RTVCdFdYejY4NEtkSnZNUE5sVm4zUUt0RG9sOHhqUkovS1pZSWxOQ3BFWW43?= =?utf-8?B?eWR1eVB2MzNBNkxjRkNUb0cwb1RMdjJyeGRISit6OHpJMjBqdnJXRmZvK3l4?= =?utf-8?B?SjYxV1FhNmxjME9WaVJrcEorN1FGNzQ0VWZ6Y1g3em8zeUlUcDEvUFNpTGZM?= =?utf-8?B?UFhPZjZuQWJCYmlaYTdVcDNzNmtWdGFRcnhtelltRmhpZW5ZZWhsZlhkbk5p?= =?utf-8?B?d3pydmJQK3JWdVNndTlFNC91eWVNWEZIelJPSGd3Zllhd1NtTXJNSG5MZ05q?= =?utf-8?B?V0dPb05pcnpkcVIzT0VPMEZHK2RCR0V4cWNCYjIxRHJvOW5CK0NzQURrZ0lF?= =?utf-8?B?cG1iVE5GRk5WVkpSQUd3MTJ0REpLV3lSNGdPSGt5TVJMbmRMSlRVdEQ2Q1Zh?= =?utf-8?Q?XW2g+hfhA5aUj3QQPU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rjh1K01IZHRnT0w5akxOUXExaDdlZWVMNjFvc0hWNFE2Vk9hUWhoZmJLWUhX?= =?utf-8?B?NFJtR09vZEVaWEFWYzRsZ1hjMnlHVVlnajZWRXRmNGRsbnhwMG0wajFBaXNk?= =?utf-8?B?ZWh2MDNKaVVxTjlVN04vVTJMaktoVTN1MFlxdmV0MGhVc3lCMHRxUXN3Zngv?= =?utf-8?B?ZS8wb0dyUlpJY1Z4MXhmTXgrSHQ2TlRFWlQ2OVZOVm5waXFuRlpKKzk1M200?= =?utf-8?B?WndYeklHU3Nqd1c1YllyajA1SElzU3E0a0RMSVg0RlAxREpRMWtwU1pSV0p1?= =?utf-8?B?N3pIc2VNNWFtbEtKazE3T3VuSGtUM1FiMUJ5TzhINmFLbE1WOEw4STFkdTg1?= =?utf-8?B?TUQ1S21kNVZHUkc3Z2lMb3ZDVXlrcDUwRDFTZ0QrWDgyRE9iWFJRQWZsclAy?= =?utf-8?B?UVUrL2I5VUFCUC9vQjdBSVRmb0txQnN5K1Q5WnhLbTRVemxCbGJQcWtLNldW?= =?utf-8?B?cllQN21USmExRFhndWYra1RrdmM4Q1BDVitUQVp4ZnNjRk42TXZXRDRuWVRY?= =?utf-8?B?a2tSL3FYOVozRUYxeVdBdzhzVG5ua280RTVEQTlPcEc3K3dtR2RRQ1hhUGkv?= =?utf-8?B?RTNpS2ovV3FnZmc3ZUJrSWV3d3JCb3VFQ3JaQzBLZXFkeEJMeDBwQ2IzL1dZ?= =?utf-8?B?RWFkVkRrb0xJWXFkbzlyS3pDc3c1SWRGdXVsbDliSDRUTys0MW5ud3YxclVl?= =?utf-8?B?WVhHeG5ib1FYSkthUFlqbGlWQVNyU2JVaGZzaWF0OTFxWnY2dEQ3UlFoR2J4?= =?utf-8?B?ZXNYVEt0ZCs5UkFBMVBocG1jTHdwcUN1VzVjYzBzdHN1dzd2cXhFKzNhNUox?= =?utf-8?B?djBrQ2hzNERTSWFOTmdtMmtIL1dzSWZ3VFROQzdaQkd4RjNBVkRJQ1l2UDla?= =?utf-8?B?T3lJcmhDQk1DdVJyRTZzZyttbDJWM2FqeDEyd3E2V3YwdGlKcHBvQjV4a0Fp?= =?utf-8?B?b1JMc3ZGdVlNbWpyMWYxWENFRGVJcDdzWEMvZHFXb3RPeTd4SVBPLzNRMHdn?= =?utf-8?B?dk5LSFpaUWhjMGNNMVhxbnA0UUExVnMrbUcxMXBHMTlnbmxmWmNpdVVwa29Z?= =?utf-8?B?YmpVR0FJYTVmWTVtZU5qSWtjMVBUNmRrUER1VER1bEo4NVZSSytSNEwzd1pY?= =?utf-8?B?OUc2WG4rWEdzSW0vT0NVL3VQWlJ1Q2pOTVdKQTJLNE5uQnkyR2FDV25YSlYr?= =?utf-8?B?Q1FKaHZiOFZXMjdLSFFMWlNDbUNXU3JGUkxsWEZaaVFiWis3TDNQalpGK1BS?= =?utf-8?B?L1phQ05qSEZ3RVcyOTE3Vys2KytWR0pRMHF5OE96TVUrL3hpbmd5bWI1NTgx?= =?utf-8?B?NWsydS9ZTjltYkZJRGsrRkE5VTArWFhzc1d1WkE3SlpNMlhkRjdKYnMwNzE5?= =?utf-8?B?TkZwOTUzRFhhRFV3OEg4R0pmbUNCL0JHbmNZU3NCdDRFNW9hdTdKdkhxaWlY?= =?utf-8?B?bElVbVVHVFJBMkhTcEsxQStPTGxYdzB2MHFNMnlzd2JOV0lrbTBMRFkxY2JR?= =?utf-8?B?Q2RCbGZzQjhIUXRBL2xlMjltSUQ2Uk5lY0pPT3Q1SHRzTmc4UFpJVEJMZVg2?= =?utf-8?B?YlBRTU1DTnpPN2N5Vjk3V2wxd3ZqeFpkNXZEM0hlamhPZXFscnFDelVjSVJX?= =?utf-8?B?OG84NnZVNU1uOGpURks1T2orbkVVTmwzZHF6Z2UrZFhzbnhhYllGYk1oT2Ev?= =?utf-8?B?MVpFK1ludkg4NkV4NlNRVmFCT3dscWNSd3JNbTdBNms3b1ZUZlQvWUxvSGtz?= =?utf-8?B?cW15bVFzQzllalJOK1lObmhrcmVCUDhIOGNOL3ZBZUlZZmozVm9Pa2RYWUJM?= =?utf-8?B?MitLUk02cGNEZy9vaUlZM3NmbnVxclFtNUxXSnVhOUptZWJzRW9wWkR6QjVL?= =?utf-8?B?NmFNdnFmbmRsQ1BtY0EyNDFZSDBVb3czQXA5eURwSHd2a0xxT0ZJRmMyYzUz?= =?utf-8?B?R0dTR1k4WTZOY2RZOWU2cnNaL2tRTUs4Z2w2RXZheEhRTmZCQlFPS2g0NEN5?= =?utf-8?B?TGIvQVNnMkxTdktsaG9ZbFgyUTdDeUNCOFNxdjlXOGpIQkxwdEtuaXNIU2dY?= =?utf-8?B?aW93N1ZMR0RIWmZMMXpMN2VvcldnZFNFU0lwK2JmN2NWQlpxVXlndERCM1h1?= =?utf-8?Q?An2Ds7A61UehHG1a9mvq/HTbN?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd8fa505-7e3d-44af-9515-08dc9d37350c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 21:12:42.0273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0K/+snXQsxNF4H7URainaeHSq237vftDVChOOju6P5LqWQugO5zAvYA9R/MD0MAt X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9447 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/13/2024 4:36 AM, Howard Wang wrote: > r8125 is for Realtek 2.5 Gigabit Ethernet NICs. > > Signed-off-by: Howard Wang > Hi Howard, Thanks for contributing to DPDK. I remember Realtek drivers mentioned a few times in the past, it is great to see it will be publicly available. Can you please give some more details which devices, SoC or specific boards etc supported with these driver(s) (r8125 & r8126 in other patch)? What is the motivation for the upstreaming, like is this for a customer or to enable people experiment DPDK on boards with Realtek NICs etc..? Btw, there were some offline suggestions from David & Thomas, let me try to summurise them first here: - Can r8125 & r8126 drivers combined into single driver, perhaps with some common code? Assuming two drivers are common enough to put together. - Can you please split the patch into multiple commits, so that it becomes easier to review and analyze later. There is another driver upstreaming in progress, you can check it as sample: https://patches.dpdk.org/project/dpdk/list/?series=32313&state=%2A&archive=both - Use a real person as maintainer, and in .mailmap file instead of alias Also I can see some binary data in the driver, are they necessary to keep in the driver, like: mcu_patch_code_8125a_2() rtl8125_real_set_phy_mcu_8125a_1() rtl8125_real_set_phy_mcu_8125a_2() phy_mcu_ram_code_8125b_1 ... phy_mcu_ram_code_8125d_1_1 ... They are taking space and as they are binary there is no way for driver to understand / update / fix them.. For both this one and r8126, I will wait for next version to review further. Thanks, ferruh